From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6E64C27C5E for ; Mon, 10 Jun 2024 08:08:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A2966B0085; Mon, 10 Jun 2024 04:08:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 129726B0088; Mon, 10 Jun 2024 04:08:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E717F6B008C; Mon, 10 Jun 2024 04:08:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C5DC46B0085 for ; Mon, 10 Jun 2024 04:08:17 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5B0E280D8D for ; Mon, 10 Jun 2024 08:08:17 +0000 (UTC) X-FDA: 82214251434.13.22C1C21 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf21.hostedemail.com (Postfix) with ESMTP id 6F6E91C0016 for ; Mon, 10 Jun 2024 08:08:14 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=hZNxW0W1; spf=pass (imf21.hostedemail.com: domain of linus.walleij@linaro.org designates 209.85.167.52 as permitted sender) smtp.mailfrom=linus.walleij@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718006894; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/L5y1Dv6ivY3eszYnYmdXRYc401x9YYY2yBAmmyUG/k=; b=u48oWrCG+rZNciMooSSLE7vm/caQaPi67g6HKmTJAvs5122cMT80WHBNRw1BhEIL2SESh5 trwER2Ej6/aGttbM9eEVfcZ3WjvDrnbMEvb0v6rJVAQCX87wpiL+6/jI3nr6MS4bgaLHyL 4KX/D1+eLrVPPTe3va1hYC8ixbnEa9M= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=hZNxW0W1; spf=pass (imf21.hostedemail.com: domain of linus.walleij@linaro.org designates 209.85.167.52 as permitted sender) smtp.mailfrom=linus.walleij@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718006894; a=rsa-sha256; cv=none; b=2QAqYGwcljYerWW9UKjFhE5Hspym/qWE4812A5U2vCIw3FeTEzumoUIz5j3GlBNWi7ufEf KHmVhrHg2xqqTeRCjeI2p1h638Qy81i9zg8X391fJuzbs1HPyGgfk5RDAqAxrgAHPPt2xv JTzXRAKJi1SmAEhWaV/FWiragUnz+t0= Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-52c525257feso2195143e87.1 for ; Mon, 10 Jun 2024 01:08:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718006892; x=1718611692; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/L5y1Dv6ivY3eszYnYmdXRYc401x9YYY2yBAmmyUG/k=; b=hZNxW0W1fpO8mApIYiZZplVZH4oKOMB1IefOY9jM0rtcVUFcrVOMgGCRRkVSVhw4lP w2I3HdJyMNIA8EWPSCLRR/xUszIWO8jNU10u7iZo/KVNgkCve5oUiHOiJmDjJ0TErLpy cDDbtufNXBAVz/M3Qa5v4+dfWIEf4C77Bu3RwYp3yKyblxEhut4LAUtscUiPHT0y5eqM Ooq4rHJAmYzNmmo22Vq/8BCWDoLAw4OO3JNK/6ldu79AWwFLk391E86TV7ec0y/olV1k znehtiQrn77RKv0P2Djw5f9WGO07n0vnTY3HS/G5g8HpNG94PA5IF0fKNGrFjXMD4mKM mM7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718006892; x=1718611692; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/L5y1Dv6ivY3eszYnYmdXRYc401x9YYY2yBAmmyUG/k=; b=Exlf7YA4vbI3h8A1t9Ey1Bvtjy72rvH1rrSv45TM4F0ZIN8gzRlh/b5/W6biCzJkyU Mke/H7oGGymFPPme7TPYyVaP7Y5R+zr/AwjoiCZFYn1m/AZvfRLul/ljbGoCkfGJ5ZBe e5BsmFaeVgctu9/wPV8RFHZCFyX7B2CFCVXZyvpFeXQoZDlZ6WUBcs+5uhQdj35nZpdg ZsPoy6JqDB3GdXWwKMHepfRZh6GNCoJTQvHvmMLCySM4eqev8fbzxlqotKjezJxG5FP+ YVgQlo0FwAKyFFfhjrS3goPKyy/gRtQFK1NAcASxLMHBXvtmz7NaNeVDV3ZePtMiZv0t Hg/A== X-Forwarded-Encrypted: i=1; AJvYcCWQ/2QFmKUOVR2Y4YKy172fLx1j/u7Y9jI4c8rcONVgrqqAqDUpPjn/ECw+V8mDIdoLnVqQzjTWwo7CNgQU3+p7Utk= X-Gm-Message-State: AOJu0YzGXVOOL+wa6xavcWMRNtUA1WjbbZ2P4PrJkIcmxN1r/HBUOi5p q62fLieUx/7EdnRT/Yvg8+J7nyPC4y4RTVHnadKZB9DnmDgpS4/2MjNQIRcqsDs7evM3GjKVvaY 9bfLVUieIiJx/u5f+7UGqVquASkhjpRST9C/hTw== X-Google-Smtp-Source: AGHT+IEoIIaopVbMhKiBzu+ZFeFG117iZrYhuaSy1PLsnicMvCE0nAaF1iUL9hhnUeVtUHqe9i20V059/u6XmSWe6yI= X-Received: by 2002:a05:6512:234d:b0:52b:be9b:cafe with SMTP id 2adb3069b0e04-52bbe9bcbadmr5940256e87.21.1718006892189; Mon, 10 Jun 2024 01:08:12 -0700 (PDT) MIME-Version: 1.0 References: <20240603211538.289765-1-andriy.shevchenko@linux.intel.com> <87tti9cfry.fsf@intel.com> In-Reply-To: <87tti9cfry.fsf@intel.com> From: Linus Walleij Date: Mon, 10 Jun 2024 10:08:00 +0200 Message-ID: Subject: Re: [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string() To: Jani Nikula Cc: Andy Shevchenko , "Rafael J. Wysocki" , Greg Kroah-Hartman , Corey Minyard , Allen Pais , Sebastian Reichel , Perry Yuan , Giovanni Cabiddu , Herbert Xu , Nuno Sa , Guenter Roeck , Randy Dunlap , Andi Shyti , Heiner Kallweit , Lee Jones , Samuel Holland , Elad Nachman , Arseniy Krasnov , Johannes Berg , Gregory Greenman , Benjamin Berg , Bjorn Helgaas , Robert Richter , Vinod Koul , Chunfeng Yun , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Nikita Kravets , Jiri Slaby , Srinivas Pandruvada , Stanley Chang , Heikki Krogerus , Abdel Alkuor , Kent Overstreet , Eric Biggers , Kees Cook , Ingo Molnar , "Steven Rostedt (Google)" , Daniel Bristot de Oliveira , Andrew Morton , Hugh Dickins , Abel Wu , John Johansen , Mimi Zohar , Stefan Berger , Roberto Sassu , Eric Snowberg , Takashi Iwai , Takashi Sakamoto , Jiapeng Chong , Mark Brown , Kuninori Morimoto , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-acpi@vger.kernel.org, linux-ide@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, qat-linux@intel.com, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-hwmon@vger.kernel.org, linux-i2c@vger.kernel.org, linux-leds@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, linux-gpio@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-staging@lists.linux.dev, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-hardening@vger.kernel.org, cgroups@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Naveen N. Rao" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , David Howells , "David S. Miller" , "Rafael J. Wysocki" , Len Brown , Sergey Shtylyov , Damien Le Moal , Niklas Cassel , Daniel Scally , Sakari Ailus , Michael Turquette , Stephen Boyd , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Heiko Stuebner , Peter De Schrijver , Prashant Gaikwad , Thierry Reding , Jonathan Hunter , Huang Rui , "Gautham R. Shenoy" , Mario Limonciello , Viresh Kumar , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Karol Herbst , Lyude Paul , Danilo Krummrich , Jean Delvare , Alexander Shishkin , Pavel Machek , Chen-Yu Tsai , Jernej Skrabec , Tony Lindgren , Adrian Hunter , Hu Ziji , Ulf Hansson , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Potnuri Bharat Teja , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Miri Korenblit , Kalle Valo , Mahesh J Salgaonkar , "Oliver O'Halloran" , Kishon Vijay Abraham I , Matthias Brugger , AngeloGioacchino Del Regno , JC Kuo , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Sebastian Reichel , Daniel Lezcano , Zhang Rui , Lukasz Luba , Thinh Nguyen , Helge Deller , Brian Foster , Zhihao Cheng , Tejun Heo , Zefan Li , Johannes Weiner , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Masami Hiramatsu , Mathieu Desnoyers , Jason Baron , Jim Cromie , Paul Moore , James Morris , "Serge E. Hallyn" , Dmitry Kasatkin , Clemens Ladisch , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Linus Torvalds Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6F6E91C0016 X-Stat-Signature: ozbw5h1smpe7tkaw3g9wy8skaa39384e X-HE-Tag: 1718006894-731558 X-HE-Meta: U2FsdGVkX1/ad6602Q2087iLqzOMZ4BELuvR/Zv2f1S60FOySRXrYZ8aDFi0Yd0SVh0BrNkiyORyr87tgYqN1R/7xr5vzWzwtTTOO0EkFyJokeoxTdxBsk/+O+HAOvckIxrtv2FV8vuRE//tROjgid2z2kVyahoOU74t8uFN4fsHOLN8ey+X2hkIVNS2hmNbuh8exsBpMe7kOXGuNjYZF2GugZkYZPJKZe5Ri0L+UqRWP0/h02ZbXWCqbsFcelM8zlFadZazHgpnfxT9nMOBRwtVUB59zwuACzfUA2DNqfSUbGI50qcEw+vWKuxeoHZzzK1fEOikC22oIhnDkm77nF52tTaAU/oWixyWMkxSLaLpWoEV/fsMJ54LJtd2j5iVpoKy07Zx3CU0tfuJ+SenDqO1uAealfkf89WcxjOKbyuNtmusu34OGizI66enDRhxZrapqd02690hZSc6pAyh+8iSo00U+bJ3URv3kaUyqubS/kaq5u5Mz+GXGN8j5+4KRV1nny9tPUxd7rdfRhh+Bqwvpz6SbcnbIcVzfgNiCsqoOc2SpuX0cwK5D2whQWhPPxQqzrmaPP/JDBR8kGV5GGKvHzhbqVAjN4TtC20YE7RnnYoD3anrGE4xSy8p8zC6g1WLY8ddBWtOpnXFxGiZmx+WFqX623/NDXDo3PDCsY/Vo9/OlcI1igwM+90WI07tOHhpzagMhqak5DdX1M/d/u2WMi82IIQf4suJhHR32ghuNuC6kLU3D8H5oMAXUGPkKv1GPyttbb7/bEghgy+PpPivwn1Aalw3UMPBuBZlFTj7Ssojb+TgSK+VTSOCweT1T3y6loZfCe7qlYB4x/BU+BJNHGLiVTuFMSUizoHYlaYCMWKzTNLIN2I+SGJhMPjhUiSNyWtlUMS7JJhShOU/UoEoIQn6s87oGZDYRHpEeSW3Y256YmWk5Je/YLkJTYfTAtiEIkEElN0png0jgsn +gXLMnlk +4hg/5oXcNE+Wpr4qbEXw//82yq50xsVyuRdbO7VLge9UjUQJunLJU8Tbs2qdg5Wj3THyS4fe+53EUxAaezIOtheGxSTDacV5wqBz/SkFHn68H+2RlU0JnA74YL73utIRioyuCbY6qJyh8Yl5CxLKIWZY168avy3IKk9+t3haHUpS8zHeUiRgiHEOJJR5KyfFLZE6dRuSebsSYNfN7jT9QNVQy3UGJae91gKv+my39GU4rOvr4A6krGEzslfyt6qtPlBFjkKHTp82KrNv8tps/BHNwIdOCbnT3JizSs9VAGWJ9ZRtw7Q92vDpF8rZ2p4aepcsJcfdNSs8uEQ44Vwa8m0uEIFOe5Lp26S66ZJjf6WqISo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 4, 2024 at 9:46=E2=80=AFAM Jani Nikula wrote: [Maybe slightly off-topic, ranty] > Why do we think it's a good idea to increase and normalize the use of > double-underscore function names across the kernel, like > __match_string() in this case? It should mean "reserved for the > implementation, not to be called directly". > > If it's to be used directly, it should be named accordingly, right? It's a huge mess. "__" prefix is just so ambiguous I think it just shouldn't be used or prolifierated, and it usually breaks Rusty Russells API rules times over. Consider __set_bit() from , used all over the place, in contrast with set_bit() for example, what does "__" represent in this context that makes __set_bit() different from set_bit()? It means "non-atomic"... How does a random contributor know this? Yeah, you guess it. By the token of "everybody knows that". (Grep, google, repeat for the number of contributors to the kernel.) I was considering to send a script to Torvalds to just change all this to set_bit_nonatomic() (etc) but was hesitating because that makes the name unambiguous but long. I think I stayed off it because changing stuff like that all over the place creates churn and churn is bad. Yours, Linus Walleij