From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C93EC388F7 for ; Mon, 9 Nov 2020 15:54:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D4CC8206D8 for ; Mon, 9 Nov 2020 15:54:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cu9PnxGU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4CC8206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2FE5E6B0036; Mon, 9 Nov 2020 10:54:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AF376B005C; Mon, 9 Nov 2020 10:54:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EEE36B005D; Mon, 9 Nov 2020 10:54:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id E36636B0036 for ; Mon, 9 Nov 2020 10:54:42 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8C45D8249980 for ; Mon, 9 Nov 2020 15:54:42 +0000 (UTC) X-FDA: 77465327604.01.turn75_0a15f0b272ed Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 6B694100473A8 for ; Mon, 9 Nov 2020 15:54:42 +0000 (UTC) X-HE-Tag: turn75_0a15f0b272ed X-Filterd-Recvd-Size: 4371 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Mon, 9 Nov 2020 15:54:41 +0000 (UTC) Received: by mail-lf1-f49.google.com with SMTP id d17so9715447lfq.10 for ; Mon, 09 Nov 2020 07:54:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zaCzvgU9o5xZazy31X3wBMAb90ixZmCS4/iAKGkiCnU=; b=cu9PnxGUwHzxdLsbkVLsxV2q/DAwkkroj0xBRUZDogvGcYVYx4Z3a9LHt/REXyp/5O zWPYCVmaO8qnoA2D6joBDMbRw2nfs5rMTW0GV45mD2ynsJE+rVjmc5CH28W7QXTOHw0v v9NR7ooKS2asKD+9d7OuL1wNIDd5sbFgimOU/azs21HY3hl/P5khS9ipnUg7vvT45PqP SAPxyttMPXLHdkJuHxGkDDLhtbhI9i/K2ORvGnZ0niRb01MeyhwO26c6jMcnGcTw/em3 UUPXX+LCTbVLcHpstvCHXXs4Xjq2zZGu3EHpUMe4zOR8jaBR3TCze0iQreZbA/Xu2htB Xc9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zaCzvgU9o5xZazy31X3wBMAb90ixZmCS4/iAKGkiCnU=; b=mJEZ8GwzJJHRbj3fr4QCHIevZ/EnByNNZo7K+GftOe4RXehFvccLD8BbkkCjCK+Etp YdwUMw31y/6a8STD7VRSm0MUYUE+SXYMyHNkfJR+aaoXIssNYf8zP2fQt9+VdGmxQtOI WdE8aqeTeJAS86XVPKKGvKHtLzgRc6QWNfHs0s4812EZ/XgWL60lGU1jrgoPZZTWIzfX RnULxB4b7JwIyV95Ixx58BX6f2oPlmKhNA0/gUhL2mWiZec2R31fQpEHpr1cA5a+aq9x wdv5Fd5dlxf9DSCT7jMAQX5zoxyuqph9drSUbXru4ZLxrevnUK/5ZTnMBv057O58Ou0R Z1NA== X-Gm-Message-State: AOAM533xZ0P/HEuMZ9KXGsLoTLgVJT1zQBT31imZ3YJ6PSEb4/l3Bjb/ tb3vGXieXBtIkYVtxvcE6QKOxhYVNonA193BlbBVOg== X-Google-Smtp-Source: ABdhPJyNi8mKNpWBQqjGurYAUC7dmShCyFEF/Y9AYZcvJVrfmhjSIosccE63RgAsggNqQqBBhSE+2+ZAncbwNhyDIJ0= X-Received: by 2002:ac2:50c1:: with SMTP id h1mr5563709lfm.333.1604937280274; Mon, 09 Nov 2020 07:54:40 -0800 (PST) MIME-Version: 1.0 References: <5fa49698.Vu2O3r+dU20UoEJ+%lkp@intel.com> <20201106210721.42351b86042b54d7d2c280e5@linux-foundation.org> <30c06c32-e3dd-4ce9-606b-d5731c0ae27c@arm.com> <20201108185522.a581d330cd4a9b25f5cbd339@linux-foundation.org> <16c1cfde-525c-1303-e1f6-d8d7fdd81cd9@arm.com> In-Reply-To: <16c1cfde-525c-1303-e1f6-d8d7fdd81cd9@arm.com> From: Linus Walleij Date: Mon, 9 Nov 2020 16:54:29 +0100 Message-ID: Subject: Re: [linux-next:master] BUILD REGRESSION 0a6f624a86e766a27d23cbb73c23be62231d10ff To: Anshuman Khandual Cc: Andrew Morton , kernel test robot , Linux Memory Management List , linux-arm-kernel@lists.arm.linux.org.uk, Russell King , Catalin Marinas , Ard Biesheuvel Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 9, 2020 at 7:01 AM Anshuman Khandual wrote: > Just build tested this. Observed that set_pud()'s arguments here seems > to have been reversed. If this looks okay, will send out. It sure looks good to me. (It doesn't hurt to have both patches.) > diff --git a/arch/arm/include/asm/pgtable-2level.h b/arch/arm/include/asm/pgtable-2level.h > index 3502c2f..9d4f5ee 100644 > --- a/arch/arm/include/asm/pgtable-2level.h > +++ b/arch/arm/include/asm/pgtable-2level.h > @@ -177,11 +177,28 @@ > * the pud: the pud entry is never bad, always exists, and can't be set or > * cleared. > */ > -#define pud_none(pud) (0) > -#define pud_bad(pud) (0) > -#define pud_present(pud) (1) > -#define pud_clear(pudp) do { } while (0) > -#define set_pud(pud,pudp) do { } while (0) > +static inline int pud_none(pud_t pud) > +{ > + return 0; > +} > + > +static inline int pud_bad(pud_t pud) > +{ > + return 0; > +} > + > +static inline int pud_present(pud_t pud) > +{ > + return 1; > +} > + > +static inline void pud_clear(pud_t *pudp) > +{ > +} > + > +static inline void set_pud(pud_t *pudp, pud_t pud) > +{ > +} Reviewed-by: Linus Walleij Yours, Linus Walleij