From: Linus Walleij <linus.walleij@linaro.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
kernel test robot <lkp@intel.com>,
Linux Memory Management List <linux-mm@kvack.org>,
linux-arm-kernel@lists.arm.linux.org.uk,
Russell King <rmk@arm.linux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [linux-next:master] BUILD REGRESSION 0a6f624a86e766a27d23cbb73c23be62231d10ff
Date: Mon, 9 Nov 2020 16:54:29 +0100 [thread overview]
Message-ID: <CACRpkdZCAMYnWCFH8TUN1NUNtHz6dK0duo6P1AJBhBySCagz4w@mail.gmail.com> (raw)
In-Reply-To: <16c1cfde-525c-1303-e1f6-d8d7fdd81cd9@arm.com>
On Mon, Nov 9, 2020 at 7:01 AM Anshuman Khandual
<anshuman.khandual@arm.com> wrote:
> Just build tested this. Observed that set_pud()'s arguments here seems
> to have been reversed. If this looks okay, will send out.
It sure looks good to me.
(It doesn't hurt to have both patches.)
> diff --git a/arch/arm/include/asm/pgtable-2level.h b/arch/arm/include/asm/pgtable-2level.h
> index 3502c2f..9d4f5ee 100644
> --- a/arch/arm/include/asm/pgtable-2level.h
> +++ b/arch/arm/include/asm/pgtable-2level.h
> @@ -177,11 +177,28 @@
> * the pud: the pud entry is never bad, always exists, and can't be set or
> * cleared.
> */
> -#define pud_none(pud) (0)
> -#define pud_bad(pud) (0)
> -#define pud_present(pud) (1)
> -#define pud_clear(pudp) do { } while (0)
> -#define set_pud(pud,pudp) do { } while (0)
> +static inline int pud_none(pud_t pud)
> +{
> + return 0;
> +}
> +
> +static inline int pud_bad(pud_t pud)
> +{
> + return 0;
> +}
> +
> +static inline int pud_present(pud_t pud)
> +{
> + return 1;
> +}
> +
> +static inline void pud_clear(pud_t *pudp)
> +{
> +}
> +
> +static inline void set_pud(pud_t *pudp, pud_t pud)
> +{
> +}
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
prev parent reply other threads:[~2020-11-09 15:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 0:19 kernel test robot
2020-11-07 5:07 ` Andrew Morton
2020-11-09 2:50 ` Anshuman Khandual
2020-11-09 2:55 ` Andrew Morton
2020-11-09 6:01 ` Anshuman Khandual
2020-11-09 15:54 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZCAMYnWCFH8TUN1NUNtHz6dK0duo6P1AJBhBySCagz4w@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox