From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7711C77B75 for ; Sat, 6 May 2023 15:00:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52DF26B0072; Sat, 6 May 2023 11:00:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 503B46B0078; Sat, 6 May 2023 11:00:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41A4C6B007B; Sat, 6 May 2023 11:00:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by kanga.kvack.org (Postfix) with ESMTP id 251AB6B0072 for ; Sat, 6 May 2023 11:00:14 -0400 (EDT) Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-b9ef06cb784so3818390276.0 for ; Sat, 06 May 2023 08:00:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683385213; x=1685977213; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZNkRsBy8jmIVOhIRX+lWXHSIur+vpg4Wn3ELaF1i2/0=; b=ZmdzqLS7xSvYD2Tbhfh/xD6/b0N0VaYrB7D3bpjpM36biGof/ncmLOhzLWoIRM4cxF rMZuyK/868Q8/3/uztmdNnPJk14WbMEzNvGdrov5+03ZViNqoXppPMxy9vrvL9j84D7g GSuNPVcmceAtcQ9+Uzt80t8DcXKwULrXUvm48lNt3y8Yhi8l2Zhx+QwAMG5ni2+AlBiJ 8hz3UAsQRprdGU/DBRYQE+5axbtEwRQoIz9QJ9KDBWWuU6JvPsIvZxjBedCh6FVtzjaJ vFtbxStWRajPCnXrtPlPHoocAmC6K5oWlSKo82gT/zfZCUHufdmxCEtmM7/o8TDNNtM9 sMmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683385213; x=1685977213; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZNkRsBy8jmIVOhIRX+lWXHSIur+vpg4Wn3ELaF1i2/0=; b=Sq1Y8FFUqgQxiDqkSeHoE3gCmzAaCXJ8WjoCMFlOaMhNBdIUfZTPSL4ylVnRBemE90 7MpEDrX9/EShomzo+SlENIdDINek2W3XBXgmgyWSwuvp4iC/Fhc7GNXBFWv0L/gA8ouH EFaqRicN0EvFaKdy75JaR2gZkGClNIUWLzkfwYyruAaZ4/2dZtzrjNvGdJWKX4ydnHyG Cd2Bdf9i0Q7UREzZxyhpsX9Nl0ZDdG8HMIHvcZH7URlJCmHsnIlYQ7AOcH5vKGIgwtGv m+yLFaK7F25NwIwuP4PjJbQ+Fay6IDa0i774nsxoQ5HqKLcAYylLvtyZ0bcAT46t8sWh Qlzg== X-Gm-Message-State: AC+VfDwn/QPYghacLcayehuGG2RRk0TjShTjqiEDyQNM28XmzWqGGM7T vnkw0ItOp6DyuoQiY1TCsDf3v7+Y17awzh9VbMx6xg== X-Google-Smtp-Source: ACHHUZ5ED6NTeLKj6ZlWakj64JmtHbV7+2WxtnKr2jb5gYyUufWJOGNRCQ+8FBR8LT9KgvEWrmKoBkfq7E5K8qY84V8= X-Received: by 2002:a25:abec:0:b0:b9e:7ec8:5d41 with SMTP id v99-20020a25abec000000b00b9e7ec85d41mr4713885ybi.55.1683385213473; Sat, 06 May 2023 08:00:13 -0700 (PDT) MIME-Version: 1.0 References: <20230506111628.712316-1-bhe@redhat.com> <20230506111628.712316-2-bhe@redhat.com> In-Reply-To: <20230506111628.712316-2-bhe@redhat.com> From: Linus Walleij Date: Sat, 6 May 2023 17:00:02 +0200 Message-ID: Subject: Re: [PATCH RESEND 1/2] pcmcia : make PCMCIA depend on HAS_IOMEM To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, schnelle@linux.ibm.com, linux-s390@vger.kernel.org, Arnd Bergmann , Dominik Brodowski , Jonathan Cameron , Thomas Bogendoerfer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 6, 2023 at 1:16=E2=80=AFPM Baoquan He wrote: > On s390 systems (aka mainframes), it has classic channel devices for > networking and permanent storage that are currently even more common > than PCI devices. Hence it could have a fully functional s390 kernel > with CONFIG_PCI=3Dn, then the relevant iomem mapping functions > [including ioremap(), devm_ioremap(), etc.] are not available. > > Here let depend PCMCIA on HAS_IOMEM so that it won't be built to > cause below compiling error if PCI is unset. > > ------------------------------------------------------- > ld: drivers/pcmcia/cistpl.o: in function `set_cis_map': > cistpl.c:(.text+0x1202): undefined reference to `ioremap' > ld: cistpl.c:(.text+0x13b0): undefined reference to `iounmap' > ld: cistpl.c:(.text+0x14a6): undefined reference to `iounmap' > ld: cistpl.c:(.text+0x1544): undefined reference to `ioremap' > ld: drivers/pcmcia/cistpl.o: in function `release_cis_mem': > cistpl.c:(.text+0x3f14): undefined reference to `iounmap' > > Signed-off-by: Baoquan He > Reviewed-by: Niklas Schnelle > Acked-by: Arnd Bergmann > Cc: Dominik Brodowski > Cc: Arnd Bergmann > Cc: Jonathan Cameron > Cc: Linus Walleij > Cc: Thomas Bogendoerfer Reviewed-by: Linus Walleij Yours, Linus Walleij