From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33456C55179 for ; Thu, 5 Nov 2020 10:52:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A3DF622227 for ; Thu, 5 Nov 2020 10:52:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="d/RC4QlH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3DF622227 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DA7BE6B00D7; Thu, 5 Nov 2020 05:52:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D58836B00DA; Thu, 5 Nov 2020 05:52:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF8296B00DB; Thu, 5 Nov 2020 05:52:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0132.hostedemail.com [216.40.44.132]) by kanga.kvack.org (Postfix) with ESMTP id 8C18A6B00D7 for ; Thu, 5 Nov 2020 05:52:43 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2D4C91EE6 for ; Thu, 5 Nov 2020 10:52:43 +0000 (UTC) X-FDA: 77450051406.24.anger71_2515e38272c9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id EBB671A4A5 for ; Thu, 5 Nov 2020 10:52:42 +0000 (UTC) X-HE-Tag: anger71_2515e38272c9 X-Filterd-Recvd-Size: 4890 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Thu, 5 Nov 2020 10:52:42 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id 2so1059390ljj.13 for ; Thu, 05 Nov 2020 02:52:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IbC7h6sutytvBKVgRkW8YBm4v4oQThhwvuIz3XlFJpw=; b=d/RC4QlHsEU0Pk+87b5hebgQR1nvUbGfz+KWgyYPw8avJty+oHtYWwRBfI9ZwNnjQk 6x1f9VNEkjxS+WacQizm9QFnRFRoNTRgXz7J8hUL7gDHTr1r0B4CDTIH++hxOUWPbRHA faB9Z1G3wfURCCb570cPMFzwdpYsz5NNLR9grwb6NletLAXur80zPGuj6TnPTgqIsI6W 73tvdQLbSeHs/ZIHScGvMbbglljfvtEcmDpRr1SmCjt0Cs2115AxcxEJIltrAcsJpAIs i7f4CKXDgFTYIlx2Oia+shgKsQ9vbBqcm5RZnKYsE+6tO+5eUkPHBV9yZoGBsu8zWwxP sFlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IbC7h6sutytvBKVgRkW8YBm4v4oQThhwvuIz3XlFJpw=; b=qkGv6BTgQOpHFwchFYtwUmjjS+juFUi+9BAtzovM31bl+Wkfprlzr1J1AG/svWBNza EMW7u2irQ8klD0sonXgjFKjZrjdQRiG+7/QGSo4zKMU1dLs+caUOcLAgK9BoKXH6nSyv fCUjQfloSyUzgtwmcVkBCJsj15qCAofdMIQuqmFcjma/cy4uJbT/k5LHlE5+Ig48wtPM jPYi42HMlcyQkHRLzWKrvyV4xXufOj9mAnuFOsH9gQ1aCNYuq65RUWecxkQhgnbNofFP LA8OxknN662Lzdrrf41xqNhLE0V2bBIcCxlbpjM/mf0mt/zV1vLfkJagcPcmceYCXNyC iRtw== X-Gm-Message-State: AOAM531AsEqP2fJSAzAzvLJ6+E9ILWQKGwPmK4BwnzP3w+s4L6/7rHeG psdxlcnJnDEmYZGUX8FBqc+oZYNYMs640QtRUdjlIQ== X-Google-Smtp-Source: ABdhPJwMZsQSFYx3yHXvvtRlVkabm7C64j8LuP2+XUU2+XVFwAx/DWoa4YDvNPprZ43yAgspd5XcguY3mqI1O9Ir5Vs= X-Received: by 2002:a05:651c:1205:: with SMTP id i5mr726163lja.283.1604573560846; Thu, 05 Nov 2020 02:52:40 -0800 (PST) MIME-Version: 1.0 References: <20201027121725.24660-1-brgl@bgdev.pl> In-Reply-To: <20201027121725.24660-1-brgl@bgdev.pl> From: Linus Walleij Date: Thu, 5 Nov 2020 11:52:30 +0100 Message-ID: Subject: Re: [PATCH 0/8] slab: provide and use krealloc_array() To: Bartosz Golaszewski Cc: Andy Shevchenko , Sumit Semwal , Gustavo Padovan , =?UTF-8?Q?Christian_K=C3=B6nig?= , Mauro Carvalho Chehab , Borislav Petkov , Tony Luck , James Morse , Robert Richter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Alexander Shishkin , "Michael S . Tsirkin" , Jason Wang , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Jaroslav Kysela , Takashi Iwai , Linux Media Mailing List , "open list:DRM PANEL DRIVERS" , linaro-mm-sig@lists.linaro.org, "linux-kernel@vger.kernel.org" , linux-edac@vger.kernel.org, "open list:GPIO SUBSYSTEM" , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev , Linux Memory Management List , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 27, 2020 at 1:17 PM Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Andy brought to my attention the fact that users allocating an array of > equally sized elements should check if the size multiplication doesn't > overflow. This is why we have helpers like kmalloc_array(). > > However we don't have krealloc_array() equivalent and there are many > users who do their own multiplication when calling krealloc() for arrays. > > This series provides krealloc_array() and uses it in a couple places. > > A separate series will follow adding devm_krealloc_array() which is > needed in the xilinx adc driver. The series: Acked-by: Linus Walleij I really like this. Yours, Linus Walleij