From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 211C4C4741F for ; Sun, 27 Sep 2020 09:25:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8C1CA23A40 for ; Sun, 27 Sep 2020 09:25:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Etk/NQgN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C1CA23A40 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8AF366B005C; Sun, 27 Sep 2020 05:25:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 85FAA6B005D; Sun, 27 Sep 2020 05:25:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 775336B0068; Sun, 27 Sep 2020 05:25:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id 61F726B005C for ; Sun, 27 Sep 2020 05:25:39 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1744C2839 for ; Sun, 27 Sep 2020 09:25:39 +0000 (UTC) X-FDA: 77308308798.24.patch80_5c087d227177 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id E41A91A4A0 for ; Sun, 27 Sep 2020 09:25:38 +0000 (UTC) X-HE-Tag: patch80_5c087d227177 X-Filterd-Recvd-Size: 3524 Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Sun, 27 Sep 2020 09:25:38 +0000 (UTC) Received: by mail-lf1-f68.google.com with SMTP id z17so7621641lfi.12 for ; Sun, 27 Sep 2020 02:25:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YmrerxLsDYMh/bkqTtdxYf9dKZLk+BUPlAAIqmKW+Kg=; b=Etk/NQgNueNG3pCn1cP9EiA81EAhV0eo3ir1H8266fAVMeDikRtqsl9O8MVaWrmQK1 NX1+GgKlMFfd6IzlcAX85tsNL1fa9+WCXPQBnES+bZsPazw47PtGx823CsMoUaz7aw2u VbmGSNykeEKeVlkK0yaO/ERmFh2T0BO0reB11t7sVS0RuIQKZVeOwAFHPHMH6ikSA0eu aD0HAeG8M5nX7xMOFGFGdX0BU+gQRV2lKlGKpKGjT4o60Xa9IAZ6DGeKHoYK5Nya0f0d MhwG9nPq0m2f4QwyJVd/0+uz7BdwE7VDxvkapzLyMTfRkGaHqw4IjQybuVyiIyTegfJx wuXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YmrerxLsDYMh/bkqTtdxYf9dKZLk+BUPlAAIqmKW+Kg=; b=CaFp4rN69iHgVsNEReJ7Sx1bCmaSI7MlcxjRKntkKD0bHd/GcZs1ouOY8E34Mu4W+c vbMjrru6UUa7E8go8PKOKausN/x3MBTi//3F9NtIT7p1ccTjVY5M3TJX8jKbf9zzavGJ FI5219D6wdhuWtOMHn3nA9RPVoShMHxvewaQod1RhOU5TsE2Lq8/9qPwHhDQ3sskCxyc Xb0uCZHeawrHsjrKUdmYQl8Jp29nSTNviRmnx95O6Y36a0yfk/cgV4lqiIXi7r1DKKpT APH/rfncCstXA2ZFE3zp+tlxwzAWdDWySQGyDw+mS+oiQNS+FUtu2jn662f4SUBrRIOy 8/IQ== X-Gm-Message-State: AOAM532hFdhtNRGB5G7nNo4Zteg2sIlfwRMRsHbKfWxhqHd9zbBD4oUq g1RpZqMpC8Y/FEzsBNJ52joEuWLzqjAEYN1mXQMO3A== X-Google-Smtp-Source: ABdhPJwJULgLjHe/a2sr/LvdH+5pKVGkZaiqS6R8otrTEm/iiiez/V7cPU39RQZ4WnDSRaLXAtulB/9BJtYtlSMuz1Q= X-Received: by 2002:a19:6c2:: with SMTP id 185mr2074813lfg.441.1601198736857; Sun, 27 Sep 2020 02:25:36 -0700 (PDT) MIME-Version: 1.0 References: <20200907153701.2981205-1-arnd@arndb.de> <20200907153701.2981205-2-arnd@arndb.de> In-Reply-To: <20200907153701.2981205-2-arnd@arndb.de> From: Linus Walleij Date: Sun, 27 Sep 2020 11:25:25 +0200 Message-ID: Subject: Re: [PATCH 1/9] mm/maccess: fix unaligned copy_{from,to}_kernel_nofault To: Arnd Bergmann Cc: Christoph Hellwig , Russell King , Alexander Viro , "linux-kernel@vger.kernel.org" , linux-arch@vger.kernel.org, Linux ARM , Andrew Morton , Daniel Borkmann , Alexei Starovoitov , linux-mm@kvack.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 7, 2020 at 5:37 PM Arnd Bergmann wrote: > On machines such as ARMv5 that trap unaligned accesses, these > two functions can be slow when each access needs to be emulated, > or they might not work at all. > > Change them so that each loop is only used when both the src > and dst pointers are naturally aligned. > > Signed-off-by: Arnd Bergmann That's a clever optimization idea, nice! Reviewed-by: Linus Walleij Yours, Linus Walleij