From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx101.postini.com [74.125.245.101]) by kanga.kvack.org (Postfix) with SMTP id 9C2B56B00F8 for ; Thu, 10 May 2012 10:25:52 -0400 (EDT) Received: by qcsd16 with SMTP id d16so1518710qcs.14 for ; Thu, 10 May 2012 07:25:51 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1336658065-24851-3-git-send-email-mgorman@suse.de> References: <1336658065-24851-1-git-send-email-mgorman@suse.de> <1336658065-24851-3-git-send-email-mgorman@suse.de> Date: Thu, 10 May 2012 10:25:51 -0400 Message-ID: Subject: Re: [PATCH 02/12] selinux: tag avc cache alloc as non-critical From: Eric Paris Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Andrew Morton , Linux-MM , Linux-Netdev , Linux-NFS , LKML , David Miller , Trond Myklebust , Neil Brown , Christoph Hellwig , Peter Zijlstra , Mike Christie , Eric B Munson On Thu, May 10, 2012 at 9:54 AM, Mel Gorman wrote: > Failing to allocate a cache entry will only harm performance not > correctness. =A0Do not consume valuable reserve pages for something > like that. > > Signed-off-by: Peter Zijlstra > Signed-off-by: Mel Gorman Acked-by: Eric Paris > --- > =A0security/selinux/avc.c | =A0 =A02 +- > =A01 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/selinux/avc.c b/security/selinux/avc.c > index 8ee42b2..75c2977 100644 > --- a/security/selinux/avc.c > +++ b/security/selinux/avc.c > @@ -280,7 +280,7 @@ static struct avc_node *avc_alloc_node(void) > =A0{ > =A0 =A0 =A0 =A0struct avc_node *node; > > - =A0 =A0 =A0 node =3D kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC); > + =A0 =A0 =A0 node =3D kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC|__GF= P_NOMEMALLOC); > =A0 =A0 =A0 =A0if (!node) > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0goto out; > > -- > 1.7.9.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" i= n > the body of a message to majordomo@vger.kernel.org > More majordomo info at =A0http://vger.kernel.org/majordomo-info.html > Please read the FAQ at =A0http://www.tux.org/lkml/ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org