From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7A19C19F21 for ; Wed, 27 Jul 2022 05:00:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16E088E0002; Wed, 27 Jul 2022 01:00:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 11EB88E0001; Wed, 27 Jul 2022 01:00:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00C8D8E0002; Wed, 27 Jul 2022 01:00:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E21D78E0001 for ; Wed, 27 Jul 2022 01:00:07 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B769141381 for ; Wed, 27 Jul 2022 05:00:07 +0000 (UTC) X-FDA: 79731678054.13.A914DBA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 358B14008C for ; Wed, 27 Jul 2022 05:00:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658898005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=328C7t/lfMBTNWuslbDt6MRb5wfKGX7Nq000FG5WAWM=; b=fqArFVbsoycuT/yYjGL0AfDZCiq5mVJsHcjo8PDdBVsKITz0SfS81ND7PXlwEBBuwe0fbG KtrsMuQDv42kM488eslmkZB8JUkYm3TfYZnAqCri462NcrN7CRl6j+cUbPHUuJO2RYh2eB /8weZrKRW2U/GRsxIq7iJH3pd5GV8pc= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-397-lqBXsWOLM-KSKbEkdY_CbA-1; Wed, 27 Jul 2022 01:00:04 -0400 X-MC-Unique: lqBXsWOLM-KSKbEkdY_CbA-1 Received: by mail-lf1-f72.google.com with SMTP id k7-20020a05651239c700b0048a9f539070so1384702lfu.16 for ; Tue, 26 Jul 2022 22:00:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=328C7t/lfMBTNWuslbDt6MRb5wfKGX7Nq000FG5WAWM=; b=OGEwR352rNL5a8k60VKKHKTIaJxREK9qXb1+K82B8p0aXVK6eQQtOJdoYVF3VtFehF FGEeuI273mnccQD4SalrvPYxE5ceomMafJRGzqYifx73V61Y6854oQTFz63bHIwakTYw Q0ccv2GxaVJPqQhP9UWKfIWjjB1JVL2rkeMdaAW7RIL927sYy7A1Xvlt0lefW8E+I+vJ cFq7ALBYR5rZv5Dk2qGdc0b1deDsHulKNVi4OMWNr6d6VBeN0QcDrhe+TigDCig45SNQ LBkgFMyQL4xYw9dKplJWx+c+yqz1oOpowy8vQ1DxQhh5np9Bc+npyFek8JQK81qMEwGb OoQw== X-Gm-Message-State: AJIora/H9JuHtXXkNPfpPFIpdzXGA3tsTUy3+fE/IIcCXgMixyuHMF2D I/Bs08u0+htmkl8xrM5NYuFTS43s/pKEwzkSni25JwsdphsX8JlngGBgjuCgOjpk1iRPvGm/kxx XafFiyuzbliz62YBrOk/HmC7lPl8= X-Received: by 2002:a05:6512:b0d:b0:481:5cb4:cf1e with SMTP id w13-20020a0565120b0d00b004815cb4cf1emr7237910lfu.442.1658898002515; Tue, 26 Jul 2022 22:00:02 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vPZY8nVY+qvmUV4ThmrrYh3uP7ne096VDRSFkv/b1xcj8u86DgdUtULwU3n9XG1Cd3R8XLqLMox4qIi7Z0n3o= X-Received: by 2002:a05:6512:b0d:b0:481:5cb4:cf1e with SMTP id w13-20020a0565120b0d00b004815cb4cf1emr7237901lfu.442.1658898002007; Tue, 26 Jul 2022 22:00:02 -0700 (PDT) MIME-Version: 1.0 References: <20220726131135.146912-1-wangkefeng.wang@huawei.com> In-Reply-To: <20220726131135.146912-1-wangkefeng.wang@huawei.com> From: Jason Wang Date: Wed, 27 Jul 2022 12:59:50 +0800 Message-ID: Subject: Re: [PATCH] mm: use is_zone_movable_page() helper To: Kefeng Wang Cc: David Hildenbrand , Oscar Salvador , Andrew Morton , linux-mm@kvack.org, "Michael S. Tsirkin" , linux-kernel X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658898007; a=rsa-sha256; cv=none; b=2GB+UfbFbpswEu7nUJwDQnOH18WzZpt6IlU4jsO8EgdxH3CMWez3PurAJ7rVKnQPg+FJRg PLhqnX+cLZAxQ0Usx+oIt1Z1fty8NrDm7gR47uqNt4PyOdOYoWraA/gFLucZ4ZMcY7pMJr G9OmNTUPUNIYvq2wYUtOpRucUV83RwI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fqArFVbs; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of jasowang@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=jasowang@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658898007; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=328C7t/lfMBTNWuslbDt6MRb5wfKGX7Nq000FG5WAWM=; b=LBhZxS9p6UGL/wgN6fBotI4PG11xien2zASncqZpmHVRNwaUZwd7LMftnzgiYAD8pmSaG3 zN1Tp6W26K6xzDmw9i2mxw/2V7XF0HnjRM0hsLLmfnTheAVGOypnwsnzs0E1Cy2oFl6pCR VpXNm8dWgx3fD4xySoF/yBZRn1rlqQc= X-Stat-Signature: jkfrao38f4ebazdyzeud7deo44nif1wq X-Rspamd-Queue-Id: 358B14008C Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fqArFVbs; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of jasowang@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=jasowang@redhat.com X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1658898006-623210 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 26, 2022 at 9:05 PM Kefeng Wang wrote: > > Use is_zone_movable_page() helper to simplify code. > > Signed-off-by: Kefeng Wang Acked-by: Jason Wang > --- > drivers/virtio/virtio_mem.c | 6 ++---- > mm/memory_hotplug.c | 2 +- > 2 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c > index e07486f01999..0c2892ec6817 100644 > --- a/drivers/virtio/virtio_mem.c > +++ b/drivers/virtio/virtio_mem.c > @@ -862,8 +862,7 @@ static void virtio_mem_sbm_notify_online(struct virtio_mem *vm, > unsigned long mb_id, > unsigned long start_pfn) > { > - const bool is_movable = page_zonenum(pfn_to_page(start_pfn)) == > - ZONE_MOVABLE; > + const bool is_movable = is_zone_movable_page(pfn_to_page(start_pfn)); > int new_state; > > switch (virtio_mem_sbm_get_mb_state(vm, mb_id)) { > @@ -1158,8 +1157,7 @@ static void virtio_mem_fake_online(unsigned long pfn, unsigned long nr_pages) > */ > static int virtio_mem_fake_offline(unsigned long pfn, unsigned long nr_pages) > { > - const bool is_movable = page_zonenum(pfn_to_page(pfn)) == > - ZONE_MOVABLE; > + const bool is_movable = is_zone_movable_page(pfn_to_page(pfn)); > int rc, retry_count; > > /* > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 1213d0c67a53..0f5914964a32 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -936,7 +936,7 @@ static struct zone *auto_movable_zone_for_pfn(int nid, > if (!page) > continue; > /* If anything is !MOVABLE online the rest !MOVABLE. */ > - if (page_zonenum(page) != ZONE_MOVABLE) > + if (!is_zone_movable_page(page)) > goto kernel_zone; > online_pages += PAGES_PER_SECTION; > } > -- > 2.35.3 >