From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F02D7C61DA4 for ; Tue, 31 Jan 2023 03:23:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3549E6B0072; Mon, 30 Jan 2023 22:23:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 305156B0073; Mon, 30 Jan 2023 22:23:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A5FD6B0074; Mon, 30 Jan 2023 22:23:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 09FDE6B0072 for ; Mon, 30 Jan 2023 22:23:23 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CF0A112027D for ; Tue, 31 Jan 2023 03:23:22 +0000 (UTC) X-FDA: 80413648644.03.CDF5823 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 0370920018 for ; Tue, 31 Jan 2023 03:23:19 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eTQ0ZDoM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of jasowang@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jasowang@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675135401; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ltkBGnwECMJmhbD7vrl7YLMiwdLoKe7LIr5e2nHG3PQ=; b=oXGZkX+l6+V1ZyKWucytfFGOoarJsxDcqpZ8IoGbWkg6wkbjfK+i72M7hMGaVF7G9IOE8w cImL/SGxQQK1i6MvH7IBUbSNpPK1wCqevGqbDUSdZr6l3JoFoCNsrcTD3y/W3ovXJclSjH lA1Wx6yDFBsueDemUmnr1nX1fBrtbG0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eTQ0ZDoM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of jasowang@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jasowang@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675135401; a=rsa-sha256; cv=none; b=tjfHGcTHjbfzxU2fbHR/3BZsRNtbNf6RbQQmKjrjHZt/GsGR3WcV1eBNL9fjqu4dznn762 GfiuSIvJT4hGYF0uxhik5J9w+QHD8Ge42rbtfu9xmqr9xIrm/LWpxkD6sktMmZ+CP7CNa/ kcW2W1tqdr+dRU6JZpPfptkCdN3ODx8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675135399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ltkBGnwECMJmhbD7vrl7YLMiwdLoKe7LIr5e2nHG3PQ=; b=eTQ0ZDoMQCpPpszFR/rOHB1amQnyUJDYFlBvmR9LLeicTmoV/+2IQZFrC0anHrGp9ii7RE +JIiAL0A3CNcSQcJtmR+ZMEkBNvX5mKZcItU/E2KVBApE8p8RGD+YQVPCj2xPTYozaSoSG T8ZgLsdsJcikT07ZD/MPLrDsMEDtON8= Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-8-b1GIuFU7OqKPQyNuk5j-Hg-1; Mon, 30 Jan 2023 22:23:08 -0500 X-MC-Unique: b1GIuFU7OqKPQyNuk5j-Hg-1 Received: by mail-ot1-f69.google.com with SMTP id j60-20020a9d17c2000000b0068bd57aa53aso1657135otj.17 for ; Mon, 30 Jan 2023 19:23:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ltkBGnwECMJmhbD7vrl7YLMiwdLoKe7LIr5e2nHG3PQ=; b=n9xyb9UzUmn15MB0SN4ltJeDpZslbD++/1UgdBBmxQnf0vVocIlqy47E1gO/X5yXJB 9w7Gb20kRxndw52haGU73bSoa4BOExqaTnfaOLAf9KZMcnz3D6vVdzzTHwfxt7xdhbKz 2HQltber3LePErtO95G68S7suRXRIepX3zZvp9hIjReHdJCSdcStOtaulxPCYn9IRfKN aSNLu0UObEyV1ubtgGKEr7ad1UFaiLn9uxj62cjnOu0S04XISshX0kITDMZ9dhm1+yvW opcUMh5zjAs7jmSyYlAIoNIbD5blAmiLVYbizYlURYkeHz5XISMK/JDCnS9vfEOtLV93 WUiw== X-Gm-Message-State: AO0yUKVa5/QldLeFJofGsSFYrdCVisQjb/L7wHUDKTMJBXBzawSmcSQL XDD9xm6+KlClbJksR/CibKVQZbBx11jwZd5KIg9NvHSPi9U0BZ5DvUon1US9y0XHdMhJ33kNgxu tqvzjIn1E2pKjNwf4EKcGj9k7saY= X-Received: by 2002:a05:6870:959e:b0:163:9cea:eea7 with SMTP id k30-20020a056870959e00b001639ceaeea7mr567826oao.35.1675135387518; Mon, 30 Jan 2023 19:23:07 -0800 (PST) X-Google-Smtp-Source: AK7set9Hu2HFEDPiDGXCaNnCjpBr1M/3mkKYHDHH6RsQ5EtesD62XsOTK7GEj1aXmBl8gjJeRQSyQJytKuQEUWxkdJU= X-Received: by 2002:a05:6870:959e:b0:163:9cea:eea7 with SMTP id k30-20020a056870959e00b001639ceaeea7mr567795oao.35.1675135387309; Mon, 30 Jan 2023 19:23:07 -0800 (PST) MIME-Version: 1.0 References: <20230130092157.1759539-1-hch@lst.de> <20230130092157.1759539-10-hch@lst.de> <20230130101747-mutt-send-email-mst@kernel.org> In-Reply-To: <20230130101747-mutt-send-email-mst@kernel.org> From: Jason Wang Date: Tue, 31 Jan 2023 11:22:56 +0800 Message-ID: Subject: Re: [PATCH 09/23] virtio_blk: use bvec_set_virt to initialize special_vec To: "Michael S. Tsirkin" Cc: Christoph Hellwig , Jens Axboe , Ilya Dryomov , Minchan Kim , Sergey Senozhatsky , Keith Busch , Sagi Grimberg , Chaitanya Kulkarni , "Martin K. Petersen" , David Howells , Marc Dionne , Xiubo Li , Steve French , Trond Myklebust , Anna Schumaker , Mike Marshall , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chuck Lever , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, io-uring@vger.kernel.org, linux-mm@kvack.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 0370920018 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: z3wzru9jqxyf1i6mi544tyyzcir6uku8 X-HE-Tag: 1675135399-980112 X-HE-Meta: U2FsdGVkX1/cX9wMDLonjBSy5ymh8omJnz4JFfZmBGRDKBj2Ism30m5Ts2eU+u4rmv94NZOmgmWzjtkP1+89Ry9XJJFKEjdaIwhLaB0L3octZhuY+N5A08P++e14iWADJMfK3abuDOgFUYWuAQ8QrBVORjNbKDq9looHxgbkZDleVwxi6xRq6vQ7kgcPFmXO91Q/uTRTifHSLo6YamO7vzVa4eGLA5o6XRSNl+kDuUolsU9Hqwd9oca67/5DX8+oGIJFoXPwss1Y+kU+rKKJBNE5qgzqMG3seYLRHFGnJcuAexO5epseTjTifvojCxZQu8upSieHC9pfa9QH/CpEw31p0UvnMqL38KrnfP3dnYXzWu7uYN+fO8WylfbNaRqaKJbIsoXbsqWhfiItRjCQUwRHmm9w+Dg8DGThBMLRMWnTjlMUv6nEe7p/9ITd2KFzQ8gtR8XCOzrqcSnahCjEdWWRp2A21R34JzefSIIRcKOQg+KxzwyGvLJ7duuo2y5J1TtbLAx8bdtHz/zYzMpXryBHWZo8GGVxTMKJT3dfOY4GI/03RL95sO+J1rNMvWutbGeYK7oNkZybS0PFxWBA/BaVJ/lXmAJereGEzodWvI/frhwVofUD/ce6z2n4vSOa2rgenUjEbufw7WNt/YrITwZS1+lsaxPOvEI3i7VtPwGEF0g98uBTlN3T89zFsENZoX1xlIGml4geIai1DKlTnhdpurMnclC9gfMQ1cUupMB/U+JQflEWOtNeb495wcpymA01v9aiKYAREMlSpx3U7QP7x7qk78ydF1LlgFD10TPQUF3YCrgwn5zSeYXIekdqOtXhsnabarcgPwTxVYKcISyqTxT4bz3rTJMUdtfvA6ucygike1FJjiVw7y1gxnpYNFjXIhoGy2uzPYjAviI0A41rtevfqIGwOCaLyHl4GNWLhRArjAibKsC8YSxbzDXiGUdHWegl7Xj44uaTwP4 bL6eGunv nIoLL7Qp9WaOkbhs6wN0kyFhirUEcN6DzMCazE2YS37YJSvu6/8lFDmcPz64QDgPsyaQctXnevJzdOJPgtzRtqOadVu0Hpe4VvFGHaYa7jqJyI53kruyEYeYAouPHJvt9Q7Fbr6xvRGH1kZGghF20vyFzq8wMI9Tu4Wf0712I+4eeP3hL8K2k8Au8yKbLcNUleUzYbCUwB7TWOD68I+ovzubFl5O28mHrM8wJpJqzc7Yo5KOcP8GNZu9HCT/LFTixUAg1Xw+/mZMWapFR1tB6Uvw4JDpAcKkv2InmT5HjzELh9DCZCEBi/hTaZ4Mvozcc8lUdhu1ZfEfMrWk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 30, 2023 at 11:18 PM Michael S. Tsirkin wrote: > > On Mon, Jan 30, 2023 at 10:21:43AM +0100, Christoph Hellwig wrote: > > Use the bvec_set_virt helper to initialize the special_vec. > > > > Signed-off-by: Christoph Hellwig > > Acked-by: Michael S. Tsirkin Acked-by: Jason Wang Thanks > > > > --- > > drivers/block/virtio_blk.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c > > index 6a77fa91742880..dc6e9b989910b0 100644 > > --- a/drivers/block/virtio_blk.c > > +++ b/drivers/block/virtio_blk.c > > @@ -170,9 +170,7 @@ static int virtblk_setup_discard_write_zeroes_erase(struct request *req, bool un > > > > WARN_ON_ONCE(n != segments); > > > > - req->special_vec.bv_page = virt_to_page(range); > > - req->special_vec.bv_offset = offset_in_page(range); > > - req->special_vec.bv_len = sizeof(*range) * segments; > > + bvec_set_virt(&req->special_vec, range, sizeof(*range) * segments); > > req->rq_flags |= RQF_SPECIAL_PAYLOAD; > > > > return 0; > > -- > > 2.39.0 >