From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68193C636D3 for ; Tue, 31 Jan 2023 02:31:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 948726B0072; Mon, 30 Jan 2023 21:31:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F8B16B0073; Mon, 30 Jan 2023 21:31:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 799316B0074; Mon, 30 Jan 2023 21:31:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6A6A76B0072 for ; Mon, 30 Jan 2023 21:31:37 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3CEB7160140 for ; Tue, 31 Jan 2023 02:31:37 +0000 (UTC) X-FDA: 80413518234.01.08D25B5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 4CF19C0007 for ; Tue, 31 Jan 2023 02:31:34 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Sv93uO8F; spf=pass (imf22.hostedemail.com: domain of jasowang@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=jasowang@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675132294; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=utT+RE/MkgWVBG/iNzPiYM+H0kp8FILH2HeviGKceUM=; b=cLCRmytz7bPMQsez/+jh8aj9gYHXHsoRytUjcE2peYSd2HQz3az3kHfIL4CrFaBE/asflQ jDH1dKOmdRo88h3dbGrgiqHF4Wx632gx8e9LUmMVkHJyYxtRG+a9XKFb1ZDSIhNyDFwnNp eJ//UkFrP0CuyXEfF1qgaP4B/FpAIhE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Sv93uO8F; spf=pass (imf22.hostedemail.com: domain of jasowang@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=jasowang@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675132294; a=rsa-sha256; cv=none; b=jeH3Mj1n/ZLLKpYtjzYZtTVFXAdlCL9B+AeAxlgrGF4bt/B8xG2FlMK0cMX3Jb6wdxrOhU bvRfQn9vo8oBGhhtU92sEGOdsJeqm8GWUcpeh3ArND6xgUEvakXtoO6sXpMjZ/YVzg30ef Irg7Ikt0AgL3F0DKOlb8vtLGtgd63hA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675132293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=utT+RE/MkgWVBG/iNzPiYM+H0kp8FILH2HeviGKceUM=; b=Sv93uO8FvO+E4UBZUNir1cVAxM4BDcMaSkeeY4kJ+ynJlrWluC0C3qV+Q0QF3XYJkxsO/I aF9XJREpdwyOKIWmKRfo/KZSOgJf4z+oFv5hCbOBFrzFYwmRIaXAWdmHAZmYuggPZVF4BV mfNYT5Qz/w9TINyjAROmG5v23y/F57s= Received: from mail-oa1-f70.google.com (mail-oa1-f70.google.com [209.85.160.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-301-4uEySH5ZPQiZwbWBosrV4g-1; Mon, 30 Jan 2023 21:31:29 -0500 X-MC-Unique: 4uEySH5ZPQiZwbWBosrV4g-1 Received: by mail-oa1-f70.google.com with SMTP id 586e51a60fabf-16385ab40f2so3092344fac.20 for ; Mon, 30 Jan 2023 18:31:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=utT+RE/MkgWVBG/iNzPiYM+H0kp8FILH2HeviGKceUM=; b=c0FZlIx9KLsMubpc71P5cxdMNwYAsVmhAKqZyeR3k41Y/HiATQuB3gmQWy7sMLyN9b fk0nn7G8J3nko1o6gwqzeraKJYw0/P0ynAQ1gBbaKUhhGDAcP80neZnS+ZKRmbhe5fmA 5WsIwofif4wVz38w5NQm1pinBUb0O0DJgfGaqTXXx5nlJOtnqyuZfaJNzb/oxjkon0Cf 7SUXLrUW9AiCPDaAT5BSyXXp/wmr3gRkysel/oPuYfCHtU6fZyh/6r5A9JVgpUMa6JyL 7u3/5JadnEAXrW2aijgRCIFctnDHoyljmNaaHyCFDwazLEI3yhX0X/YvdIK4tXpZUldS gEcA== X-Gm-Message-State: AFqh2kpXaAWUStrcSTeLSt+7BjMLfB0ZoWznHfn1Dh/t6JRFShlQqW8j ULiaAqyV6xEJe0MXGpVttPbT6euAD68917b0OyutWhHSdaTx/gpkajyh8Zs8eWusaY2ax0q029I O/1H/DJ7Rf/T6ZBOMuMg+OwMJSbY= X-Received: by 2002:aca:3f84:0:b0:36e:f5f8:cce1 with SMTP id m126-20020aca3f84000000b0036ef5f8cce1mr1057797oia.35.1675132289157; Mon, 30 Jan 2023 18:31:29 -0800 (PST) X-Google-Smtp-Source: AMrXdXssco6mBUOhDTHWFT4/t2hB47krC6OsHE12Ww1f+hysvA2CpNEADdT3xvxh0DzmLnnFuHE/ftXAK22WOSTVfWk= X-Received: by 2002:aca:3f84:0:b0:36e:f5f8:cce1 with SMTP id m126-20020aca3f84000000b0036ef5f8cce1mr1057763oia.35.1675132288910; Mon, 30 Jan 2023 18:31:28 -0800 (PST) MIME-Version: 1.0 References: <20230130092157.1759539-1-hch@lst.de> <20230130092157.1759539-23-hch@lst.de> In-Reply-To: <20230130092157.1759539-23-hch@lst.de> From: Jason Wang Date: Tue, 31 Jan 2023 10:31:18 +0800 Message-ID: Subject: Re: [PATCH 22/23] vring: use bvec_set_page to initialize a bvec To: Christoph Hellwig Cc: Jens Axboe , Ilya Dryomov , "Michael S. Tsirkin" , Minchan Kim , Sergey Senozhatsky , Keith Busch , Sagi Grimberg , Chaitanya Kulkarni , "Martin K. Petersen" , David Howells , Marc Dionne , Xiubo Li , Steve French , Trond Myklebust , Anna Schumaker , Mike Marshall , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chuck Lever , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, io-uring@vger.kernel.org, linux-mm@kvack.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: ieypgxp4op8zxg5zbj67h748zufyj67z X-Rspam-User: X-Rspamd-Queue-Id: 4CF19C0007 X-Rspamd-Server: rspam06 X-HE-Tag: 1675132294-306934 X-HE-Meta: U2FsdGVkX1+odWadTYJVHZvI8Jsju4zv3jXAhDji3tMJOZelo6+EZuMWAkpIfEeF9B3AH0DlRwKpClaEJZ7bTidIevZqVHyuIB99VMFn1ydV4ec6cZCMTagDIaYE5v687BP8dYBuK+BJKg5wObKR2GFuHVEBnAbmSFoc8DpIlO1L88JrrjdtWC4xuKw/zi9Rh7MloigrqILfrl0WACixxZfn7L0d4YHLv2bHwaEixEcO1scCzOgdgIub/oRTjbiTfclz6wNdiKaOkjru8MVPcePxI0WEjLfsTgTGXWJMyKrKBZn3jF9Tci+6RwGvLbFCxJ6ad9CU/K12mho/Dw8vjzjVK/U8O/n29hXEpCUrrNQaQ9gDOjkaDZONawqoTTbwaNGVH2+V21pHen0jm0nBlmjZbky6LlF8wKEgyYq695VNTaPh2u2pWmb0egdCEYPicq3/gRP52TL1yeDEy4lz04CaSgIE5hiP+UMQGrrJES+5KqpdbFx1T7GtlZhhiLkeG5W458Eki1C/oD3haOcrnTY9GPgOMdNT2AJfWJAkX9KyfbwM6bMTAy9LagtpG8Z2hxbATT7xDJByhOE8+5pMTbPJ0K6m8uFhS50t4D7vqpeCKwxPwEbB+BAny7hTWfQiymAVZwp46eKrVJwVBsjIJosa33LlioDtUnFwd/zFRNxCxnnX9tzc64uzWnv+e4tVM9o5zZunLXSs3b9lds5kwEXYcRj6NkjvmeLiatUB5fn/yIy6wVM/jTNNZyyb8BvcGG2u7iOkhAG3UhIXCR7eP/aQKHcIs2EUY1Zghpn5ZZ1TmMcs5k7xiNDN5eOLxcO/3HNKtEkmapOoxKtFurgYaVGROAS5vqyxm17nr9zax5kTC0PWGJqML+XL1ktuk096gN2t0eREXbDhl/SGAokcyHPZUP9BwYeCVBk59kahtnnNVKMCAyjlDtlTDQU3v/qCIX2w/0wbsbBe1jEAO0O BrVTdhlg cHPfcZvZsJXn9zcS/+rKhYh6QuiPbKuX3C9UaOZTFnEkWonWXAN4xq3m/EoxfFRJDSMhAwYRsHXcbQoUnPw/OaoCMguxsFqr0L2Ryh932kCs3YGd3cN10mWkjx8MyCYb5kzeonDcp/oEjkJ0G4AXRg+NEX+Bi5HPnbOA8UjQkHGaQ0ZM+RDvtxi9S2ZR+qAZy9hN3uznYZJXj7e/mxKFj2blAv2KJFoGtHiIRqR7YNOldFTvjZZ+T3SR9Nyf1Xz5xKXVxRB+NANuPJ035l4FLyvVv54ebarYatTXkK4hRpuVZ9nvsfkTl83nBtDyv9Xh+FcfYpG5HPbabNwc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 30, 2023 at 5:23 PM Christoph Hellwig wrote: > > Use the bvec_set_page helper to initialize a bvec. > > Signed-off-by: Christoph Hellwig A typo in the subject, should be "vringh". Other than this Acked-by: Jason Wang Thanks > --- > drivers/vhost/vringh.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c > index 33eb941fcf1546..a1e27da544814a 100644 > --- a/drivers/vhost/vringh.c > +++ b/drivers/vhost/vringh.c > @@ -1126,9 +1126,8 @@ static int iotlb_translate(const struct vringh *vrh, > size = map->size - addr + map->start; > pa = map->addr + addr - map->start; > pfn = pa >> PAGE_SHIFT; > - iov[ret].bv_page = pfn_to_page(pfn); > - iov[ret].bv_len = min(len - s, size); > - iov[ret].bv_offset = pa & (PAGE_SIZE - 1); > + bvec_set_page(&iov[ret], pfn_to_page(pfn), min(len - s, size), > + pa & (PAGE_SIZE - 1)); > s += size; > addr += size; > ++ret; > -- > 2.39.0 >