From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 528BBC33CA1 for ; Thu, 9 Jan 2020 13:36:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F05B22067D for ; Thu, 9 Jan 2020 13:36:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rmPFqplF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F05B22067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 42DDC8E000E; Thu, 9 Jan 2020 08:36:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DC9D8E0001; Thu, 9 Jan 2020 08:36:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CBDD8E000E; Thu, 9 Jan 2020 08:36:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0179.hostedemail.com [216.40.44.179]) by kanga.kvack.org (Postfix) with ESMTP id 1391A8E0001 for ; Thu, 9 Jan 2020 08:36:36 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id AB5EB180AD807 for ; Thu, 9 Jan 2020 13:36:35 +0000 (UTC) X-FDA: 76358195550.23.burst23_90d506e6d5c15 X-HE-Tag: burst23_90d506e6d5c15 X-Filterd-Recvd-Size: 4086 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Jan 2020 13:36:35 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id 195so3386213pfw.11 for ; Thu, 09 Jan 2020 05:36:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cf95WORT6GX1WJSn8Af/G1OCB1Irn/cMBwQxwXC43X4=; b=rmPFqplFiG2J23km4wRX/Ng/4kLCh6mrZt9F0tbMq9Fkk952L8sqSIO4o7LgYULfwU 1KtC1gWAKTfa0XSUUAQOR/AmiotKOiyRCtMVmsyZgWl7wiNros6lsyIzVBKk/lEPxX0N 5O4IjgJWkFY0lyOJzBgBeSNBDQagktLXZMzfFMLURXzGXfLJjyf9u7JhjvdvJVIPPoIV +FpzI1GmzdsT0mwz6RfBwpQvN5KYst18bnDXEZX/R66raaG4xngUb7fMMFDFr4XRrHLC HS0EaXm5BYy8/MMd3k9yPgsTCotJx3MtIWFki3GxVm5+umLuLYzDRu1kI/QqXQdGnzea 4fzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cf95WORT6GX1WJSn8Af/G1OCB1Irn/cMBwQxwXC43X4=; b=SXdMhBPzkvT4Jr8anXj8BaNQM5XJxRVNeXq4hmJOb+P71m2mCvoZkNlH9khjaYrUZl Rq8wtpXeloqErKbfQGhtqPghIwfFCz9gtSgwtmxKscLVezshD1WNJWYm1rkn63pOmCcw +sGRANnAItZhVUYMII7vtjqcVBdRfOPTxgq5P//VebVQe98qZCE1zJVAHJOQH+1vkfgi CMfcEoD2FxTvyyWC2CtTO03GDzlTpqfZp7+dxZBaLFimGg8CnTGkuweJ5MZdpkVh81rL vV8MCN1XIMk1Fn/k0zTjG/0ukluPFHeZDQtRCYYIE+XCbVRjKzOg2B8hkRwmxwYctvGY zXuA== X-Gm-Message-State: APjAAAUb4gylyycDQ1mMTbOztwDW0G/4nK70TQafrhFkxSSZLQnKqcVU OYZOdQXla4qlV+KDZK7GXnK/1iprTek08pX5BcM= X-Google-Smtp-Source: APXvYqzYs38vcWA8XTYQ6/bQR6VN+il7W5RyHWICEMlfnkK4VOVNx6yJKOpUbeM/o/gNmhfTvQD92qFBUgw0+jdnlik= X-Received: by 2002:a63:3dc6:: with SMTP id k189mr10954174pga.396.1578576993895; Thu, 09 Jan 2020 05:36:33 -0800 (PST) MIME-Version: 1.0 References: <20200108152100.7630-1-sergey.dyasli@citrix.com> <20200108152100.7630-5-sergey.dyasli@citrix.com> In-Reply-To: <20200108152100.7630-5-sergey.dyasli@citrix.com> From: Paul Durrant Date: Thu, 9 Jan 2020 13:36:22 +0000 Message-ID: Subject: Re: [PATCH v1 4/4] xen/netback: Fix grant copy across page boundary with KASAN To: Sergey Dyasli Cc: xen-devel@lists.xen.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , George Dunlap , Ross Lagerwall , Andrew Morton , Wei Liu Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 8 Jan 2020 at 15:21, Sergey Dyasli wrote: > > From: Ross Lagerwall > > When KASAN (or SLUB_DEBUG) is turned on, the normal expectation that > allocations are aligned to the next power of 2 of the size does not > hold. Therefore, handle grant copies that cross page boundaries. > > Signed-off-by: Ross Lagerwall > Signed-off-by: Sergey Dyasli > --- > RFC --> v1: > - Added BUILD_BUG_ON to the netback patch > - xenvif_idx_release() now located outside the loop > > CC: Wei Liu > CC: Paul Durrant [snip] > > +static void __init __maybe_unused build_assertions(void) > +{ > + BUILD_BUG_ON(sizeof(struct xenvif_tx_cb) > 48); FIELD_SIZEOF(struct sk_buff, cb) rather than a magic '48' I think. Paul > +} > + > MODULE_LICENSE("Dual BSD/GPL"); > MODULE_ALIAS("xen-backend:vif"); > -- > 2.17.1 >