From: Kari Argillander <kari.argillander@gmail.com>
To: Dirk Behme <dirk.behme@gmail.com>
Cc: "Alice Ryhl" <aliceryhl@google.com>,
"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
linux-mm@kvack.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: page: Simplify overflow check using checked_add()
Date: Sat, 20 Dec 2025 14:53:43 +0200 [thread overview]
Message-ID: <CAC=eVgSkqruKPn=-5RJW-1SR5TmPRj5BtbPH0Nu3_kuUqk53Eg@mail.gmail.com> (raw)
In-Reply-To: <9efae3dc-05d5-475b-bc69-250c2186dd70@gmail.com>
On 20.12.2025 10.41 Dirk Behme (dirk.behme@gmail.com) wrote:
>
> On 19.12.25 22:29, Kari Argillander wrote:
> > Option::is_none_or() would be nicer, but it requires Rust 1.82; the
> > kernel currently targets 1.78.
> >
>
> I just wonder if we would like to add a comment like
>
> // TODO: replace `map_or` with `is_none_or` once the MSRV is >= 1.82.
>
> like we do in e.g. transmute.rs [2]?
Sure, I can do that. I’ll send a respin maybe next Tuesday.
> [2]
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/rust/kernel/transmute.rs#n75
next prev parent reply other threads:[~2025-12-20 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 21:29 Kari Argillander
2025-12-20 8:41 ` Dirk Behme
2025-12-20 12:53 ` Kari Argillander [this message]
2025-12-23 7:12 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC=eVgSkqruKPn=-5RJW-1SR5TmPRj5BtbPH0Nu3_kuUqk53Eg@mail.gmail.com' \
--to=kari.argillander@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=dirk.behme@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox