From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id 3D8C16B0023 for ; Wed, 14 Sep 2011 05:26:44 -0400 (EDT) Received: by vws10 with SMTP id 10so2203739vws.30 for ; Wed, 14 Sep 2011 02:26:42 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1315941562-25422-1-git-send-email-sjenning@linux.vnet.ibm.com> Date: Wed, 14 Sep 2011 11:26:42 +0200 Message-ID: Subject: Re: [PATCH] staging: zcache: fix cleancache crash From: Francis Moreau Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Dan Magenheimer Cc: Seth Jennings , gregkh@suse.de, devel@driverdev.osuosl.org, linux-mm@kvack.org, ngupta@vflare.org, linux-kernel@vger.kernel.org On Tue, Sep 13, 2011 at 10:56 PM, Dan Magenheimer wrote: >> From: Seth Jennings [mailto:sjenning@linux.vnet.ibm.com] >> Sent: Tuesday, September 13, 2011 1:19 PM >> To: gregkh@suse.de >> Cc: devel@driverdev.osuosl.org; linux-mm@kvack.org; ngupta@vflare.org; l= inux-kernel@vger.kernel.org; >> francis.moro@gmail.com; Dan Magenheimer; Seth Jennings >> Subject: [PATCH] staging: zcache: fix cleancache crash >> >> After commit, c5f5c4db, cleancache crashes on the first >> successful get. This was caused by a remaining virt_to_page() >> call in zcache_pampd_get_data_and_free() that only gets >> run in the cleancache path. >> >> The patch converts the virt_to_page() to struct page >> casting like was done for other instances in c5f5c4db. >> >> Based on 3.1-rc4 >> >> Signed-off-by: Seth Jennings > > Yep, this appears to fix it! =A0Hopefully Francis can confirm. Ok I can give this a try and let you know. In the meantime, as I said to you privately, 3.1-rc3 doesn't have the issue whereas 3.1-rc5 has. Thanks --=20 Francis -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org