Re: [PATCH] z3fold: the 3-fold allocator for compressed pages

[Seth Jennings <sjenning@redhat.com>]

On Thu, Apr 14, 2016 at 12:45 PM, Vitaly Wool <vitalywool@gmail.com> wrote:
> On Thu, Apr 14, 2016 at 5:53 PM, Seth Jennings <sjenning@redhat.com> wrote:
>> On Thu, Apr 14, 2016 at 4:06 AM, Vitaly Wool <vitalywool@gmail.com> wrote:
>>>
>>>
>>> On Thu, Apr 14, 2016 at 10:48 AM, Vlastimil Babka <vbabka@suse.cz> wrote:
>>>>
>>>> On 04/14/2016 10:05 AM, Vitaly Wool wrote:
>>>>>
>>>>> This patch introduces z3fold, a special purpose allocator for storing
>>>>> compressed pages. It is designed to store up to three compressed pages
>>>>> per
>>>>> physical page. It is a ZBUD derivative which allows for higher
>>>>> compression
>>>>> ratio keeping the simplicity and determinism of its predecessor.
>>>>
>>>>
>>>> So the obvious question is, why a separate allocator and not extend zbud?
>>>
>>>
>>> Well, as far as I recall Seth was very much for keeping zbud as simple as
>>> possible. I am fine either way but if we have zpool API, why not have
>>> another zpool API user?
>>>
>>>>
>>>> I didn't study the code, nor notice a design/algorithm overview doc, but
>>>> it seems z3fold keeps the idea of one compressed page at the beginning, one
>>>> at the end of page frame, but it adds another one in the middle? Also how is
>>>> the buddy-matching done?
>>
>> Yes, as soon as you introduce a 3rd object in the page, zpage
>> fragmentation becomes an issue.  Having a middle object partitions
>> that zpage, blocking allocations that are larger than either
>> partition, even though the combined size of the partitions could have
>> accommodated the object.
>
> Yes, but this situation is easy to track down and work around by
> moving the middle object to either the beginning or the end. In case
> of the current implementation it is the beginning.
>
>> This also means that the unbuddied list is broken in this
>> implementation.  num_free_chunks() is calculating the _total_ free
>> space in the page.  But that is not that the _usable_ free space by a
>> single object, if the middle object has partitioned that free space.
>
> Once again, there is the code in z3fold_free() that makes sure the
> free space within the page is contiguous so I don't think the
> unbuddied list is, or will be, broken.

Didn't see the relocation before.  However, that brings up another
question.  How is the code moving objects when the location of that
object is encoded in the handle that has already been given to the
user?

Seth

>
> ~vitaly

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>