From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78E28C433FE for ; Tue, 8 Nov 2022 17:36:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF1F86B0072; Tue, 8 Nov 2022 12:36:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EA2546B0073; Tue, 8 Nov 2022 12:36:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D69AA6B0074; Tue, 8 Nov 2022 12:36:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C4C286B0072 for ; Tue, 8 Nov 2022 12:36:47 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 27F5C1C5D7A for ; Tue, 8 Nov 2022 17:36:47 +0000 (UTC) X-FDA: 80110980054.17.DC6C064 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf24.hostedemail.com (Postfix) with ESMTP id B6454180004 for ; Tue, 8 Nov 2022 17:36:46 +0000 (UTC) Received: by mail-lf1-f48.google.com with SMTP id l12so11095697lfp.6 for ; Tue, 08 Nov 2022 09:36:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ts1OMTgoNQBYMD+LlN12Djk7W/xNrL3YKKYYOB6HHfU=; b=oMZarAvONxb46BGzHmx6Ftds5jVZs/0IlpNrzqN2aIuIBIX0rHmaPTw3YWoCtWlpne xKPwjrjO6WLLT6GW9n102QzFRaVaBH7/MW7NMH4vWca8w8NgBCJeqa2//ch38ih9e3E+ 1x9Ul4PC3zVGGxBBVRIq9RNFTsmsCkgljQz3mXJyXQ+sRjvGA4MMEZuI9nBHr1v1+w1/ Tk//DoUg+JTmpDCdfWL/OmZ2fpplPZlfPURKUilddSVb73KqLciLSUsUHTPyF1imwDOs pFFC4ypI4V8fHF71xPXyM3xQ1EMQEnjBdPjNdz8MpASOrzKns3Ji2m8czg/DlXIBHNvd pkeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ts1OMTgoNQBYMD+LlN12Djk7W/xNrL3YKKYYOB6HHfU=; b=PhtM/yNPmiUWgiaRDNf0RI1uKsEACbanfxV0aAqROopexTGXF/nzHLuEpL1PE+M1sG vWvgyIsypFgQJgVHr0Eim7nIw3p0MQqSwuqRex/vUg7NuAjLp6zGRqXf1u/bwAetqyRq s5zxUZXUBTLpK0dNY1kbW+6CfYrFMmEcOqNVfqHzHngVa3Txr0niOi5V2PqgRAfhn7GM f5q91Qb5BeTWpbUv8GeIob7v8yNQMg2Wz3XRqrwe5ip2WGi9PHAoGYp8rRT+wmWIKp80 KWbWVkyVHupGVZrM04yfpxjRk6HTDMKwsdee3MdAnc0vrdpMPHlnKqve6jnM1xpKdoBI rEUQ== X-Gm-Message-State: ACrzQf1Pv+5L0D/tnw0pwIPYb6p3qsYqm2lOu8zri10c6uiDRvt2+v2b fdmek3eWlXXsxFoVYuF0+UwH6VGjT37vK6TsY2Y= X-Google-Smtp-Source: AMsMyM4wCSMKG2RIOFdKFrTl8wWVUroLuDY6QCPiegdFrPHvEDnsCc82ltZEEZA7D4YtSeZlJAaylakxPp3PL4Wbaro= X-Received: by 2002:a05:6512:1093:b0:4a2:a15a:3274 with SMTP id j19-20020a056512109300b004a2a15a3274mr18558654lfg.400.1667929004829; Tue, 08 Nov 2022 09:36:44 -0800 (PST) MIME-Version: 1.0 References: <20221108035232.87180-1-zhengqi.arch@bytedance.com> In-Reply-To: <20221108035232.87180-1-zhengqi.arch@bytedance.com> From: Akinobu Mita Date: Wed, 9 Nov 2022 02:36:32 +0900 Message-ID: Subject: Re: [PATCH v2] mm: fix unexpected changes to {failslab|fail_page_alloc}.attr To: Qi Zheng Cc: dvyukov@google.com, jgg@nvidia.com, willy@infradead.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667929006; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ts1OMTgoNQBYMD+LlN12Djk7W/xNrL3YKKYYOB6HHfU=; b=f9ASH5Ob5T/8c3Jbezwc4oYhXD7CDhi+a+s4vUZcjqOdyfTe7vBkTBA/xlNwtzds5GVXJH gp//5SqeTBe8kTysnbnOuCPKuDbI77PxYi2/OFK5F2Dl9WSyagKzoXw9WpjT70B93lRwIh 6ZO7LXWdCJ566mCdfNNn1d34uJujeJM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oMZarAvO; spf=pass (imf24.hostedemail.com: domain of akinobu.mita@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=akinobu.mita@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667929006; a=rsa-sha256; cv=none; b=il1cOTSpHlwlVZJEX0JC7xQiJ5rrvqMtVrEAQdCB0aiPwPKxQHFSPxUYEr8qaG6FX2hgZI BepuHUcLJmasux2btJQltTJrt7hqy6YW+RphIXTrVZ/t11do6pKBXo6LT4G42aX64pxIll CQ+0ne+If7KSeiquzuCNGKusMDo5GvM= X-Rspam-User: X-Stat-Signature: cm46ur3u3kb4pqew3z44mgsw8rpkbfjp X-Rspamd-Queue-Id: B6454180004 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oMZarAvO; spf=pass (imf24.hostedemail.com: domain of akinobu.mita@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=akinobu.mita@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam07 X-HE-Tag: 1667929006-537858 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2022=E5=B9=B411=E6=9C=888=E6=97=A5(=E7=81=AB) 12:52 Qi Zheng : > > When we specify __GFP_NOWARN, we only expect that no warnings > will be issued for current caller. But in the __should_failslab() > and __should_fail_alloc_page(), the local GFP flags alter the > global {failslab|fail_page_alloc}.attr, which is persistent and > shared by all tasks. This is not what we expected, let's fix it. > > Cc: stable@vger.kernel.org > Fixes: 3f913fc5f974 ("mm: fix missing handler for __GFP_NOWARN") > Reported-by: Dmitry Vyukov > Signed-off-by: Qi Zheng > --- > v1: https://lore.kernel.org/lkml/20221107033109.59709-1-zhengqi.arch@byt= edance.com/ > > Changelog in v1 -> v2: > - add comment for __should_failslab() and __should_fail_alloc_page() > (suggested by Jason) Looks good. Reviewed-by: Akinobu Mita