linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Akinobu Mita <akinobu.mita@gmail.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-mm@kvack.org, akpm@linux-foundation.org,
	axelrasmussen@google.com,  yuanchu@google.com,
	weixugc@google.com, hannes@cmpxchg.org, david@kernel.org,
	 mhocko@kernel.org, zhengqi.arch@bytedance.com,
	shakeel.butt@linux.dev,  lorenzo.stoakes@oracle.com,
	Liam.Howlett@oracle.com, rppt@kernel.org,  surenb@google.com
Subject: Re: [PATCH 2/2] mm/vmscan: don't demote if there is not enough free memory in the lower memory tier
Date: Wed, 17 Dec 2025 23:30:26 +0900	[thread overview]
Message-ID: <CAC5umygxuqYrV1w3kMc+uaZuBgqcx3sX4MsZ1C3tLpHHTFZW2w@mail.gmail.com> (raw)
In-Reply-To: <01d780a3-16ef-4f87-b57d-00d50afa4bed@suse.cz>

2025年12月17日(水) 21:55 Vlastimil Babka <vbabka@suse.cz>:
>
> On 12/8/25 10:40, Akinobu Mita wrote:
> > On systems with multiple memory-tiers consisting of DRAM and CXL memory,
> > the OOM killer is not invoked properly.
> >
> > Here's the command to reproduce:
> >
> > $ sudo swapoff -a
> > $ stress-ng --oomable -v --memrate 20 --memrate-bytes 10G \
> >     --memrate-rd-mbs 1 --memrate-wr-mbs 1
> >
> > The memory usage is the number of workers specified with the --memrate
> > option multiplied by the buffer size specified with the --memrate-bytes
> > option, so please adjust it so that it exceeds the total size of the
> > installed DRAM and CXL memory.
> >
> > If swap is disabled, you can usually expect the OOM killer to terminate
> > the stress-ng process when memory usage approaches the installed memory
> > size.
> >
> > However, if multiple memory-tiers exist (multiple
> > /sys/devices/virtual/memory_tiering/memory_tier<N> directories exist),
> > and /sys/kernel/mm/numa/demotion_enabled is true and
> > /sys/kernel/mm/lru_gen/min_ttl_ms is 0, the OOM killer will not be invoked
>
> Does this mean only mglru has the problem, or !mglru too?

!mglru has the problem, too.

> Also is min_ttl_ms = 0 a sensible setting? What happens without it?

Setting min_tto_ms = 1 or a longer value will cause kswapd
to trigger the oom-killer.

However, when the stress-ng devshm test was run in addition to
the above test to increase the load, the system remained inoperable
with only the oom-killer by kswapd.

> If !mglru doesn't have this problem, how does the fix affect it?

With this patch, the oom-killer will be triggered directly from
memory allocations, regardless of mglru or not.


      reply	other threads:[~2025-12-17 14:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-08  9:40 [PATCH 0/2] mm: fix oom-killer not being invoked when demotion is enabled Akinobu Mita
2025-12-08  9:40 ` [PATCH 1/2] mm: memory-tiers, numa_emu: enable to create memory tiers using fake numa nodes Akinobu Mita
2025-12-16 20:24   ` Andrew Morton
2025-12-17 13:55     ` Akinobu Mita
2025-12-08  9:40 ` [PATCH 2/2] mm/vmscan: don't demote if there is not enough free memory in the lower memory tier Akinobu Mita
2025-12-17 12:55   ` Vlastimil Babka
2025-12-17 14:30     ` Akinobu Mita [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAC5umygxuqYrV1w3kMc+uaZuBgqcx3sX4MsZ1C3tLpHHTFZW2w@mail.gmail.com \
    --to=akinobu.mita@gmail.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=axelrasmussen@google.com \
    --cc=david@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@kernel.org \
    --cc=rppt@kernel.org \
    --cc=shakeel.butt@linux.dev \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=weixugc@google.com \
    --cc=yuanchu@google.com \
    --cc=zhengqi.arch@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox