From: Akinobu Mita <akinobu.mita@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/2] x86: use memblock_alloc_range() or memblock_alloc_base()
Date: Fri, 29 Aug 2014 00:50:14 +0900 [thread overview]
Message-ID: <CAC5umygnUybkmut9NogAxRD14kQp-NAq5=m14QRVng8pYEAhHg@mail.gmail.com> (raw)
In-Reply-To: <20140827135348.9c9ccefebccc74083f7ba922@linux-foundation.org>
2014-08-28 5:53 GMT+09:00 Andrew Morton <akpm@linux-foundation.org>:
> On Sun, 24 Aug 2014 23:56:02 +0900 Akinobu Mita <akinobu.mita@gmail.com> wrote:
>
>> Replace memblock_find_in_range() and memblock_reserve() with
>> memblock_alloc_range() or memblock_alloc_base().
>
> Please spend a little more time preparing the changelogs?
OK, I'll be careful next time.
> Why are we making this change? Because memblock_alloc_range() is
> equivalent to memblock_find_in_range()+memblock_reserve() and it's just
> a cleanup? Or is there some deeper functional reason?
This is just a cleanup and I thought there are no functional change.
But I've just realized that the conversion to memblock_alloc_base() in
this patch changes the behaviour in the error case.
Because memblock_alloc_base calls panic if it can't allocate.
So please drop this patch from -mm tree for now.
> Does memblock_find_in_range() need to exist? Can we convert all
> callers to memblock_alloc_range()?
There are two callsites where we can't simply convert with
memblock_alloc_range (arch/s390/kernel/setup.c, arch/x86/mm/init.c).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-08-28 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-24 14:56 Akinobu Mita
2014-08-24 14:56 ` [PATCH 2/2] mm: use memblock_alloc_range() Akinobu Mita
2014-09-02 17:10 ` kmemleak: Cannot insert [...] into the object search tree (overlaps existing) (mm: use memblock_alloc_range()) Sabrina Dubroca
2014-09-02 23:04 ` Akinobu Mita
2014-08-27 20:53 ` [PATCH 1/2] x86: use memblock_alloc_range() or memblock_alloc_base() Andrew Morton
2014-08-28 15:50 ` Akinobu Mita [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC5umygnUybkmut9NogAxRD14kQp-NAq5=m14QRVng8pYEAhHg@mail.gmail.com' \
--to=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox