From: Akinobu Mita <akinobu.mita@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/4] debug-pagealloc: add support for highmem pages
Date: Wed, 24 Aug 2011 00:26:41 +0900 [thread overview]
Message-ID: <CAC5umygVhjAAH-o_KGp+hkHeqfGpX9J+GP8aS68H_=GSLEdNWg@mail.gmail.com> (raw)
In-Reply-To: <20110822134348.a57db0e1.akpm@linux-foundation.org>
2011/8/23 Andrew Morton <akpm@linux-foundation.org>:
> This seems more complicated than is needed. Couldn't we just do
>
> static void poison_page(struct page *page)
> {
> void *addr;
>
> preempt_disable();
> addr = kmap_atomic(page);
> set_page_poison(page);
> memset(addr, PAGE_POISON, PAGE_SIZE);
> kunmap_atomic(addr);
> preempt_enable();
> }
>
> ?
This code looks much better. I'll update the patch.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-08-23 15:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 16:29 [PATCH 0/4] debug-pagealloc improvements Akinobu Mita
2011-08-22 16:29 ` [PATCH 1/4] debug-pagealloc: use plain __ratelimit() instead of printk_ratelimit() Akinobu Mita
2011-08-22 16:29 ` [PATCH 2/4] debug-pagealloc: add support for highmem pages Akinobu Mita
2011-08-22 20:43 ` Andrew Morton
2011-08-23 15:26 ` Akinobu Mita [this message]
2011-08-22 16:29 ` [PATCH 3/4] string: introduce memchr_inv Akinobu Mita
2011-08-22 16:57 ` Pekka Enberg
2011-08-22 17:09 ` Jörn Engel
2011-08-22 20:52 ` Andrew Morton
2011-08-22 21:50 ` Andrew Morton
2011-08-22 21:56 ` Eric Dumazet
2011-08-22 20:59 ` Geert Uytterhoeven
2011-08-23 14:31 ` Christoph Lameter
2011-08-22 16:29 ` [PATCH 4/4] debug-pagealloc: use memchr_inv Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC5umygVhjAAH-o_KGp+hkHeqfGpX9J+GP8aS68H_=GSLEdNWg@mail.gmail.com' \
--to=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox