From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C622C67861 for ; Tue, 9 Apr 2024 03:51:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BA926B007B; Mon, 8 Apr 2024 23:51:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16B1B6B0082; Mon, 8 Apr 2024 23:51:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0593C6B0083; Mon, 8 Apr 2024 23:51:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DB7AD6B007B for ; Mon, 8 Apr 2024 23:51:45 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4B46714024E for ; Tue, 9 Apr 2024 03:51:45 +0000 (UTC) X-FDA: 81988619370.03.00D372E Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf27.hostedemail.com (Postfix) with ESMTP id 6DB364000E for ; Tue, 9 Apr 2024 03:51:41 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=snu.ac.kr header.s=google header.b=gW9OV+RP; dmarc=pass (policy=none) header.from=snu.ac.kr; spf=pass (imf27.hostedemail.com: domain of sangyun.kim@snu.ac.kr designates 209.85.208.170 as permitted sender) smtp.mailfrom=sangyun.kim@snu.ac.kr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712634703; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O58wUtxGh4NGHQWQ0EAHELetLY3dLS2Bi4fslGeprZk=; b=JK0ip281TFOOoZDY4ZCQFyu6uTD4JWQjqKP5QgaEcGTxtvk5Dv7nlutQMHm/qnwWRrPg7B wGAmtD4RgulAI1E68legl+a2Q8e8rVm++e3qjlddKmdG1neuasrvwfCjfY0LuaS80bPYmc tHl4K9j8aynzpW6QljE19nb/AsqT7DY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=snu.ac.kr header.s=google header.b=gW9OV+RP; dmarc=pass (policy=none) header.from=snu.ac.kr; spf=pass (imf27.hostedemail.com: domain of sangyun.kim@snu.ac.kr designates 209.85.208.170 as permitted sender) smtp.mailfrom=sangyun.kim@snu.ac.kr ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712634703; a=rsa-sha256; cv=none; b=gjAOUEGwrbmYhHebSqssuwyYGrw5/zYihhwUBCi5XJr1NTiRGiXWL/GvmpgsgZQPc6sSt3 d5GYCjfj54iycLo7ICX2VBUaRRYuU2b7Ppy+P6Y4VNtELpfSigskAyfCVj0y9v/084uDyi TyixAluo0LP1I0ewQDQzvvyjDeq/Rxg= Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2d6a1af9c07so58526741fa.3 for ; Mon, 08 Apr 2024 20:51:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=snu.ac.kr; s=google; t=1712634699; x=1713239499; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=O58wUtxGh4NGHQWQ0EAHELetLY3dLS2Bi4fslGeprZk=; b=gW9OV+RPIbi7fl/p6PGo9wc7iUD9K9OYEdlJbOhx4L/uio98qIMKMYwLd1ziZygxtC XW/2neVbjsnU04yEuJS21+Px0SLGh8CDhBqWpIsEwfaHBstGJ+WC/qxvXF3UsQF8KQ4K jI/jIwiBnQuwd1alvxsGfOXxAPbb2A2zr+9hs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712634699; x=1713239499; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O58wUtxGh4NGHQWQ0EAHELetLY3dLS2Bi4fslGeprZk=; b=RNP4+EEAXJR7F1Z8HB6NseNm994n8DyB74UjnH9ZBiRd0e7zUXbcjtwGD2OghMZJVu CrJu+LlQcxhAbelzSQBDu0JgNlBwssbHHyhJ+KfhprDIKVaEEXMwfxaLkxSjp2+PQsI4 8kFfMPKtziW93ZmYyl2PjPUmAvXlJer6+JoFSWhbTQIcAlwXxCCdZ895Ga0W84s/4LXX kmuRPGQM1oruSiKGcpYBe8LegcSTh48rbh9lEsDZEu8MPFqjU5s7QTxOlgn5LG5Q03jI vswUz/0tTAyO8HCiQ/oQI0zLpW0LHk4NF+qnR3Ye15LlupK5PSP4hP4sDLQwr0zuBn7x AIUQ== X-Forwarded-Encrypted: i=1; AJvYcCUJrCU7inR5AMoZz0eAAeOcQXSuuuUoJ8HrHZf7spXZqRUALZ9Vbab8R1e2Rr5R6kmLMgJ4lRWiYpBih/1PE/4bsrk= X-Gm-Message-State: AOJu0YxzQBmDlj5ppaq5uCOYMBHaLw2spk5abDfGVe+RXMjDzTSDQ6a9 AiurHaL0NXo+2ePZRSgeesGHx22WsF2iQBNSfJuqhEk6B0f3HgjTCean/mtZ8YsujfLBkNlXw7z 2uOTIGJjPtmO1O+0Unv7oY4zvhhmSwmCFNAYkKA== X-Google-Smtp-Source: AGHT+IH0TjSukl6rUAy0nsce7wXwfZlJRtXQiwKgPJ9uLm+KbDi4ooA9RXnBbLaQFQVJsvL5zpAsnrkm0Dr4JEv02PM= X-Received: by 2002:a05:651c:1046:b0:2d8:3a46:8ab6 with SMTP id x6-20020a05651c104600b002d83a468ab6mr6203440ljm.17.1712634699234; Mon, 08 Apr 2024 20:51:39 -0700 (PDT) MIME-Version: 1.0 References: <20240406074449.563704-1-sangyun.kim@snu.ac.kr> <5bfe9c1c-7620-b7fd-b5fb-c481e7dfa5e7@google.com> <0ea2b92e-7152-ebf4-e1cf-ddb28b536c17@linux.com> In-Reply-To: <0ea2b92e-7152-ebf4-e1cf-ddb28b536c17@linux.com> From: =?UTF-8?B?6rmA7IOB7Jyk?= Date: Tue, 9 Apr 2024 12:51:28 +0900 Message-ID: Subject: Re: [PATCH] mm/slub: remove duplicate initialization for early_kmem_cache_node_alloc() To: "Christoph Lameter (Ampere)" Cc: David Rientjes , linux-mm@kvack.org, Pekka Enberg , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Hyunmin Lee , Jeungwoo Yoo , Gwan-gyeong Mun Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 6DB364000E X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 7cjsm8515pm9q6437k6ewgnyi8nncj9n X-HE-Tag: 1712634701-947624 X-HE-Meta: U2FsdGVkX18t+7st7/8kl9HEXwI3MSBCALxTB1L1G46FTf4tzlcJ8Jz1JNf3yMiBGkdEkZXAAoO6FLrd32D/3jfK9tzymaTlswpgkbvXrGIi5LqEEPsYq9d7JBFLyopEzIrR8rbthwUTq2rbC9MNTAERkRsWYWP57fbdYeb96/9oBYhtxZW/stnE+8j3Qknb0+fJfTBWQmy1ofIZUvYxvTUqNs2HQzzAwYr7NniGP8+NOy7Ihv291db3BZTjL/PTAg0m5P7K5B+PcmHL412sSg3yJc5cwPwK3/t/FKWRD+ayijRg74wffZ8eTCIZF96IkfVjPX2T7ZdwTL+N8xDXMapup/O+GHAwXxRH3SgvbvIaWHPgM5asm3XsWRy6+I1ZykqISB2QOSMqR3P3Q836xn0LaTtAOPMDq0Gn7tglZQ4NlED9C+K9Qh26c8vZE0pfM4DeQvLDzpgOQbgmGlqZUV/+sf0MHDh06DMFdN5URrvIdfpnpnQGbqqSCmmHCijFKmEgFdjAAKmex723xuGp23nDAVdvePos8yXJOvSNKBCoUmncF9Tc+Sk10xSrIePzSEj0u2VN2iWNeHKTU6SmJQLJCkbnXDcaKo4q2pc+SxPZw7/DH9QVQOV8cTm5MyTnnrzhj98mDZKwYwgBpYh4yN+77H8Wkcb1X8HBIDb5fpLLkSF1CgsQuCcnOQcFgbL1d/N1y23H2+6Sn0JBOEp5KiZ9igaMHYBonCslp3ZXxSA8neN1b3KWV40RhJgoJhV0sLc2cPOIofAXqxJ+S+r67GmV5rGH2uEVOhD6HbOUHx5xA2i/u934VgA1fS4SE/HrPePQoScmcO01s260gpEryekLoaP6+xSYBP7+AvnwVWYWTun5QnEKO/yebSNhrTP/j4Rxqu6kcOGPeZ06aAUWuL2u6F55wDXajXyjJ1FRiIge0KNpEXBMVAwJKSiKESPOybVTdT/plrGXdWAVZkH 1RW9QI/n ugMpRkSBS7/nxfc4q8aA2Hzw0v5v25SwEniirGK4ML32Oa8ykbHdgCKKhhPvKGGSg8v7JVHAEvjpiTIiz2jmMkkCoy0P0mXYX5gpa37L+yaHeaTu76AvH9RA4gwKbGPMWFAz35c5j6RmxEYIL035Wjhp+g7w2nvRjHejqUPFVoxcs/zzX40ZzG7GH+U7otPT0IVu6qbuywBg6rlE/piM8zE0OV54NdY/lZlA7yxGjMm4IY9aTUxS06SerL6t47bMUFnKUgLkj9kX48yLJKtFC6XUbtE2rJzBPskDMQh6j3lKhJvnrN4yGKHtinOj40Pwka92CGxFGqfOtvbt9L/zXUiURN4Tg5dsI72v4ghSUa5OHC3SvF72D2f2qF6h+cmC4icy7Q1wJ9hzDBsqRx3vhT+62vXkDmrCkMTcnrvttCRaYSVbrV37TACo74XoJvDOHOdZl X-Bogosity: Ham, tests=bogofilter, spamicity=0.007947, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 9, 2024 at 2:23=E2=80=AFAM Christoph Lameter (Ampere) wrote: > > On Sun, 7 Apr 2024, David Rientjes wrote: > > > What user observable effect does this have given it would only make a > > difference when slab_state =3D=3D DOWN? > > It reduces the kernel text size and removes a line from source code. > > > Yes, it only affects when slab_state =3D=3D DOWN. early_kmem_cache_node_alloc() is called exclusively when the slab_state =3D=3D DOWN, by init_kmem_cache_nodes().