From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99D36E77173 for ; Fri, 6 Dec 2024 11:16:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 295366B024D; Fri, 6 Dec 2024 06:16:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 244A46B024E; Fri, 6 Dec 2024 06:16:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10CEF6B024F; Fri, 6 Dec 2024 06:16:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E82E46B024D for ; Fri, 6 Dec 2024 06:16:24 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6AAFE42FC6 for ; Fri, 6 Dec 2024 11:16:24 +0000 (UTC) X-FDA: 82864279890.19.E0D2367 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by imf18.hostedemail.com (Postfix) with ESMTP id 0C10E1C0012 for ; Fri, 6 Dec 2024 11:16:14 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DlQQehkI; spf=pass (imf18.hostedemail.com: domain of refault0@gmail.com designates 209.85.219.46 as permitted sender) smtp.mailfrom=refault0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733483774; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XvyPZyZiKHfml9ebU5hvb2t0OAsao3tiC9iqjsvXzGc=; b=PeaARplACTLtFmPkh24Hmm9fE6LUPasMoLIMp1unzHPeWhqQGyN6+rNdEl9VY5CT3fj3rv oDRYIjVJdVRmus9UJUQSHoqpEF8X+HOOVPiPmCtsxYDOHIlQW/qOcbAGuEVCSHwecgmLQh +KLouCkZsxT46LV5wX6bNgaahbQwWjg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733483774; a=rsa-sha256; cv=none; b=DuxmMHBCrT3U5UMreFiI+lBZTZP4A7DtBCINYxDVMdJL5ngxoB569D8pUx/JSQtsNSSA+c 2qTYnKjcsqmDgr5ZdomMLRlgzfPDXwcjOmSq8yR+nqy8pukQ0GMBAH3I0EaaHmsjn+VjO9 0IpA8T4SBjZM/JEie5mOZT3NAodwnHw= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DlQQehkI; spf=pass (imf18.hostedemail.com: domain of refault0@gmail.com designates 209.85.219.46 as permitted sender) smtp.mailfrom=refault0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-6d87a55bc50so11381986d6.3 for ; Fri, 06 Dec 2024 03:16:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733483782; x=1734088582; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XvyPZyZiKHfml9ebU5hvb2t0OAsao3tiC9iqjsvXzGc=; b=DlQQehkInlxREt0uNU6wqnlBSE85vmsagWjdqVyB+ry/94KajETImGm5tv1mgVisrq jl9aAi+QMfg4ZSWjf5hbZ3zWxnm+nM6Omee5MAIoYwllqjuo4OFlAk5qA4TKdG2fhnq8 SxFToQ5Nk4jmRcPugQtVRCy+HwS5kG7HYN83qT9UXzIbDgaBYTQ1rriIYzf2QqnndRgd WYEmUXgZaprWNhUv2ngRzTxJFMH05z/bKbRMyQ5mYRaSvkct7ipoKP2ibXyckGz494XY O+Kpvgif5HjZolsv2smDX0Qcg5ghiDJEIwAZSpI0Ih3mQzM+5bFxlS1ji33S2oaFATms zC8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733483782; x=1734088582; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XvyPZyZiKHfml9ebU5hvb2t0OAsao3tiC9iqjsvXzGc=; b=a93XojG85wZzvazzhE2k2nGQG9LqXaMLGS1VS12qxjd3E6LmGrCFsJII8uPhLXmlV/ 89uw9I824DBYTXcvLw8F7FvWZejemHy32UJAW/o/nhBpYN4MktoR1gi+xg4JB4Z1xBK6 9npQPbwDYJnvBO63PLnCwI5IHpACuBqDMChtfJfezrMk8bBZSlE4izo9bDiJG79G2uR7 ZhgwneA4p+Ef5YAhrI9HsRNb1ihtpi1LNuZ94TSdC6s8bbj82LmGhh6xUU3CB4qNhy8U UT4pcPLwbi69W7IwFlKFNroMGKiegoKcqtSHxNlqCeLkhmLRCv7OzUvIsoVKkOh4snLX IycA== X-Forwarded-Encrypted: i=1; AJvYcCXyjDNlyUgTuu8OFPlcL6+sNH46P5V8UWTRf7CQpphDaSrrX+V03+pSZhIsJlMble1fnf0uzwqRQQ==@kvack.org X-Gm-Message-State: AOJu0YxN4ZqZ7BF9IGtJ/c2V3my6fms7JblOR34cMEH9tn9FhEx5n+k8 IuyiltADqM50kaXTVxvAC/bb9WQFnaAbRcQ7A3VmicXZXWAPQYH1/CctGoIspK9oUKmZEW/IWrW 2O6f0fi2wG2/ZZ/Ix8utXd89W5Zw= X-Gm-Gg: ASbGncv/bealC9QuQ/eD4P+xeue/35J/JVIkcLl4l7S4om66wh9qcmEEIGJhkPmZBLu R8zPhISzNuljPQv/cpPGZLFUvAUYKNMcCaw== X-Google-Smtp-Source: AGHT+IGsXVbNpFZBkJf2UfAWclnLN+x7aGDS6QbjUzZ5a5PpSl3Ynr76UxRsxeHnS0Ewh0aDWgn/CumvPOK9iWA45VE= X-Received: by 2002:a05:6214:2484:b0:6d8:ab3c:5c8 with SMTP id 6a1803df08f44-6d8e741e87fmr28324596d6.49.1733483781653; Fri, 06 Dec 2024 03:16:21 -0800 (PST) MIME-Version: 1.0 References: <20241203134949.2588947-1-haowenchao22@gmail.com> <926c6f86-82c6-41bb-a24d-5418163d5c5e@redhat.com> In-Reply-To: <926c6f86-82c6-41bb-a24d-5418163d5c5e@redhat.com> From: Lance Yang Date: Fri, 6 Dec 2024 19:16:10 +0800 Message-ID: Subject: Re: [PATCH] smaps: count large pages smaller than PMD size to anonymous_thp To: David Hildenbrand Cc: Wenchao Hao , Andrew Morton , Matthew Wilcox , Oscar Salvador , Muhammad Usama Anjum , Andrii Nakryiko , Ryan Roberts , Peter Xu , Barry Song <21cnbao@gmail.com>, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0C10E1C0012 X-Stat-Signature: cq4byjugxqk97htybj8ecskm5ndgtmhf X-Rspam-User: X-HE-Tag: 1733483774-905050 X-HE-Meta: U2FsdGVkX1/0FKKi+5ojyCMFrbn2qRLAGstX1nrez4YmLZi8muO1LNSyMGeeYVULmadl36piUxPyNnPx1M679IY7NksbaNXy/y1YtMUE5cQl1ciukFjOKwnF7TAtSVfNFqIAcvrCyUFKYr8YItQr8PeMN7KWiFCGEH+JqpKZubt213R31yPxwaMq6aXrtluZdyTsIl1S9+bwQS2j0kz66th3oGtOx7231+aAP5spZDuAqXVG5KUN1scyUE6QXi98mqVCkSK3fMBo71oIhLKN3DSkGtJI9NS1EgIYg1rBgEVS+boVxsEoEIf3maDHyzVZhyEXA+moRVjRDSsZ/VLe2Q1j6HGkTlcSH+nx1/WE+lqsGuRcHJauUzN27RW4clbbjhXmooUe8iC0NRDVxV9XKxDQRTH/eVbw3PAQVZu69dFIkiBo9OTXpnDnUouyekCAP3z1y6Z4S98TtcsIjEQ3xPXGZIWI90ZNqt6alW4uhCFimGn53iv1BMql6c6Pu+DniHiJMD2riHE9qENkSqeoxv01pwytlZhny1J9xj7MnyQ1pYbRw7z67zyBjnLvsY0/Rj4TM4sqIBmXHiefOEEOpYZsZROQnE/rIi9rkEwWel4iSItR3OTiROkboh7eNRpRkxOgtlNv3QjkOyt7qbGJ8lJn+TlSSQdFvzAvK6VzLCtShRO7LKsTUIJFtXLkWsy+NThJFoE4vcJ3k9n6OmkKXZvqLjSrfFMwz1NnTisYtIQ0zZGQxdvHZsIs1RJWhp7WVzY/xXvon+6DO7B35OduKUnX+F08T9FlV/rFf+aM+hCYMFJHMW6yJJsUygrWQgGkRz47YTGCRPYGCRCTuMuDW6SabrKc7uI6adEjMhDUtAg3Chyh7LpCvguOkUqN9uW30/nDoIxfAIQNaLIViFuecrgdenjuR0Vst58ciZBzTndm6u3cDR0ftVWLXCIvQFWJ7cU+pkTHC+y84piQ/Y0 1rYWmc9G 2u6iyqh8jX1PHyrj5u/Z0wp9ff2lyJewRW2Pvc8P2WUz5lZlMtz/EoquaoqzX5MHmTpqG2PhJCN5ixLSlWqdXOuQmEQ2lebUB0mvg9/Dscbk63JJyQFwRrbHuHRsgczsew4kat5dlL4ZrRw0Xxqjct0QmokQo0b0cjhBVNfNWwLkvPwZJMXsszidvFdLlQ/382XjO61B2z3k/JqaMVB0VDkcXI98G+wSXCf2rtSqBUqfjViPfUCU2CGMhXi1WioFBl5ZS2xgz/7GSwDbRFUUVFiX6IKLi6Q0p/Pdmc3tTN6IZxZMYwFID8eFt+6Wv3l+YKqu61Za2dMogaWdQ/kMr9iWIWjNZVbDEJapvxRuna6MMLFcN8ievUC1QKUOgRZvyoPzQdODT/E9sAD+RiM+lRcfCzwIUyyzbyqNQyYuyojkW0CLmNSHBaBZcYlem9dNTLIRTUR/GObtZDPZjVHOLPhGMX3lkYUxYrHhA54MXvl8Et9e0PTFG1v2J1O00vG1nbZHMYkvw4AlGmqHdYyjiOp823Np1xV623deImjrqMAdz3UA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 3, 2024 at 10:17=E2=80=AFPM David Hildenbrand wrote: > > On 03.12.24 14:49, Wenchao Hao wrote: > > Currently, /proc/xxx/smaps reports the size of anonymous huge pages for > > each VMA, but it does not include large pages smaller than PMD size. > > > > This patch adds the statistics of anonymous huge pages allocated by > > mTHP which is smaller than PMD size to AnonHugePages field in smaps. > > > > Signed-off-by: Wenchao Hao > > --- > > fs/proc/task_mmu.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > > index 38a5a3e9cba2..b655011627d8 100644 > > --- a/fs/proc/task_mmu.c > > +++ b/fs/proc/task_mmu.c > > @@ -717,6 +717,12 @@ static void smaps_account(struct mem_size_stats *m= ss, struct page *page, > > if (!folio_test_swapbacked(folio) && !dirty && > > !folio_test_dirty(folio)) > > mss->lazyfree +=3D size; > > + > > + /* > > + * Count large pages smaller than PMD size to anonymous_t= hp > > + */ > > + if (!compound && PageHead(page) && folio_order(folio)) > > + mss->anonymous_thp +=3D folio_size(folio); > > } > > > > if (folio_test_ksm(folio)) > > > I think we decided to leave this (and /proc/meminfo) be one of the last > interfaces where this is only concerned with PMD-sized ones: > > Documentation/admin-guide/mm/transhuge.rst: > > The number of PMD-sized anonymous transparent huge pages currently used b= y the > system is available by reading the AnonHugePages field in ``/proc/meminfo= ``. > To identify what applications are using PMD-sized anonymous transparent h= uge > pages, it is necessary to read ``/proc/PID/smaps`` and count the AnonHuge= Pages > fields for each mapping. (Note that AnonHugePages only applies to traditi= onal > PMD-sized THP for historical reasons and should have been called > AnonHugePmdMapped). Yeah, I think we need to keep AnonHugePages unchanged within these interfac= es due to historical reasons ;) Perhaps, there might be another way to count all THP allocated for each pro= cess. Thanks, Lance > > > > -- > Cheers, > > David / dhildenb > >