From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0881C27C53 for ; Fri, 7 Jun 2024 13:36:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E7806B0093; Fri, 7 Jun 2024 09:36:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 570516B0095; Fri, 7 Jun 2024 09:36:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E9C16B0096; Fri, 7 Jun 2024 09:36:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1DC436B0093 for ; Fri, 7 Jun 2024 09:36:57 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B8AEC1C243C for ; Fri, 7 Jun 2024 13:36:56 +0000 (UTC) X-FDA: 82204193232.06.F075587 Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) by imf25.hostedemail.com (Postfix) with ESMTP id DD9C9A000E for ; Fri, 7 Jun 2024 13:36:54 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BW91PhLz; spf=pass (imf25.hostedemail.com: domain of refault0@gmail.com designates 209.85.167.174 as permitted sender) smtp.mailfrom=refault0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717767414; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OsnPTo/8GBKfAm5hQE1/ElT4VESU6abIi/S302Yoa/A=; b=Cw9nKFCcPFh5nv68p4E+YaVCOaw9VqxPQwXnTdkrcPIvI3+JUG/eyCd8gwaEF1fy8BYtbT 4g4YClupy6BDF/4k1RgcYQZhn7FttMukIqllsOpG4xGxEeMCdBVqKtVLdGibQoGwAJkrkb UnQShj8c3VrQCL2HuEPIw466xzreOvs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717767414; a=rsa-sha256; cv=none; b=xm2Gp88kPPUJ6QBGwCiH8N1eSZ6N5UnNIwbi8e4fMEhIr2YXotggjlkTakjF5LH3yfN/nk NLQQOsnv5Dohs8aCQkXw/tr1IHliEAR4gqcQ5YhGT/ZbV2EVfhhM1+CiNbs77UPcZ4hv7U RGfg2DkKqiXuuS2xEkQJykvz5gZPWTk= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BW91PhLz; spf=pass (imf25.hostedemail.com: domain of refault0@gmail.com designates 209.85.167.174 as permitted sender) smtp.mailfrom=refault0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-oi1-f174.google.com with SMTP id 5614622812f47-3d1ffa16080so317168b6e.2 for ; Fri, 07 Jun 2024 06:36:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717767414; x=1718372214; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OsnPTo/8GBKfAm5hQE1/ElT4VESU6abIi/S302Yoa/A=; b=BW91PhLz9nSP+kTlJ491p7Bmt3441vMFOZeIoHXP82eL2VowPywfCwZTcuETc82koX MqlYiJLzvaDEy6it41HgB4AIAKFmP9zIadZzp2OvkofiNLHGWxkZiGliEgR6WDcB1HBG 9lgtArV2J7tDA2Ke/bC7bmW7ukL1sqZIAzcwA5M6XjHo3UlSieTDiWQNggwlLHt5FlL8 jB57sV9ySFtLe/FLaGW/TxlrQeayqMlRESl/1fSnWvRGHxXVVcCrXfnHr1v1ZYUUK50V BJukPoWxnb9TeWUtPrw+IWARdIFxEYoVrtV5OGJpQfEpy6NeLJ3OJnBy11qlHo5y0FS6 FSsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717767414; x=1718372214; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OsnPTo/8GBKfAm5hQE1/ElT4VESU6abIi/S302Yoa/A=; b=Xikif0plo5SU1r2u4cJTuOuRupOSQKLDqCfPOBtg3Na5xTgaBPn3TiDpu9E61upxLy lp9H5kjU+Fomb6QcwCybdw8GNP41hwGW/KPj6u8ZdzjCxgyeAR4prl1zeh3fw6Tg52gh 9fektEbdwnf/4Dwacm29LDC9LidJNyUA1HPUblVuGR2rgrlj7xDWKyDdGLL8aDkLXtbQ 8PLxMrm1gpMuYjdrtdpFtwgaovCL1GZGHlK8xh7W3SiFI6RxFfI9VSzaxP5XazZfZkpT UNmMxV3WqQsHDnFtPhkTXEbUj+FsMOMhCgtJbVyquTLcZaVHOmYFDq90QTcLrAGUnRBP IgWw== X-Forwarded-Encrypted: i=1; AJvYcCWONAjKQ0JkEETWdNM7D3g5uhNOIH96ftQMF0MtcfnDGHaCn3lgC6DraRcK1AwJZhSBI4SgFCFJNAzrtZTL5ZBntk0= X-Gm-Message-State: AOJu0YwvdjreP53jBaQdafHEDCzmZJuZ5kMKSpSWw/MX1f6MfHd6kzLU dXPi1OvOVkW0/kuoHUJAhcPyb7BOueD+eSeNgiEWOkoBbEyFi5dFOM3hz8JInkv7QBAChjJUUnv eoFKKxeRIdKe8DrM+RrdVocxrEA8= X-Google-Smtp-Source: AGHT+IEojVhe1VE2I9tkYeYFprnJEtgfGkdfoWwK5O0NK2oo8xUNetmXenf1UiYpFdw8PyEET/QaYELWmnmu1A9VAqA= X-Received: by 2002:a05:6808:21a0:b0:3c8:64b7:7814 with SMTP id 5614622812f47-3d210f98377mr2592800b6e.5.1717767413813; Fri, 07 Jun 2024 06:36:53 -0700 (PDT) MIME-Version: 1.0 References: <20240607122357.115423-1-david@redhat.com> <20240607122357.115423-2-david@redhat.com> In-Reply-To: <20240607122357.115423-2-david@redhat.com> From: Lance Yang Date: Fri, 7 Jun 2024 21:36:42 +0800 Message-ID: Subject: Re: [PATCH v1 1/6] fs/proc/task_mmu: indicate PM_FILE for PMD-mapped file THP To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , "Kirill A . Shutemov" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DD9C9A000E X-Rspam-User: X-Stat-Signature: faihk9m93i3ne8z8oj9peoxfm3iwm4ed X-HE-Tag: 1717767414-475577 X-HE-Meta: U2FsdGVkX19D18FDoR2coSFEe75OSULxoQqfJmH2LzRsyBUpAJc92VbQoQ1HwkWKHAO5/79MH4pQSVmfUnDVHPTSaEjB86vAMFN3lXGkRup66MyT3W8+e/c//uybNF+nioIH4eNZvHdh9saw6iHz3uUfBuBwXkS/DYEVXfZcwc9Rff0hLGFsUp3BZ/1G3bC9Gii3xySEAevQHwV4MjxjSQYshjh8G7BeujCB832AvGszbhifQl2MAJixmcy+yij6Fbiix5QElt50T7HverkbgMf4w7FDT8kmvzGPIwIwsONjHfpEg2ejCJfvc1mrGkkuQ23zABLUJGt6zayKZON+lrmhVspUFboGER/alosJYpztOf6L0arw12uZJW5sgs388U+9PObYaeI7Cl991N9edNqAmmVpsAIdlVvtVshu2ALqzD5Ynl05Nvwv5qavtPL1Y5fgAKoFgY+P3Sqd/Y2/0wbSsk4S0njK88rYCBWx4o3SuDrw9kcCJ+NTpLt7CEYCBDMW67UmpLsq6rNl+iP3T2abpXz24yZRAg3GhhkMX3LidJy02fVll1jbQtRYITg/APQ1XMpCzT26gq0K070FRizhGL6+3XZvauWMZsg+nf6tCcuOCxQjL8pybOHmFq1aBgx9jaPkAMbqruqvEo36UD7PPrL132UYqGfJ/Em6nHtVp33TJZFB58ns2Bxu5uSw1VkF3Ni22Oe+EMKEJX7UEmlo7XF42VchqUTZDpPbEAmQbLQPUbI4J2tldJuZjPv2uSSG4+mqPLyILSFA6O/MLrHmH1lVqM71y2l8Lj7OTKol8+OVTZI+LHvgg3WR3+mjT8H/a7jNqhhQlQ5SIY51Z+aaa19vM2sX7O7KOb+jnMgzTKUPoYl/v9pjenIeeJtdQkRef0+Qucv7DPqybA7V3wkI7egGm4TgzGTG8wuyXSlXlffIWyzErCd89sZg3bwZV8gDrEq0ssoC7i8NT2L FhzwV6r+ +nDbzQDKN7nxjX+BxyyldotWa2l/lX0PStwicGHgTUpEgxPDcpuDN1wCkGrgtjctSEV7uL92zAJvbp6qF9uze99JzNxGxmXomPvFYUOHq9yCHhAETytlTwxZn8psNASDL6H1alYNf4jYAo67lnRSKalbabekBdBDWNshObOEtCvYfH2I1drhq9RRSfeDEXUjzBzv97GR+W8JU3P4R82J0lDAci9cRB+o9n+K5gH3KRhtyz5SlW3y/a0fOgqsY0pmmOGfIqpwjYviLs45N1QvIgWuRXaB5bHi7G9MXnjn/VIdyE1xM247HqmObiIvQBAvnLp6QX4NIMV6acds/9MFo68OTGj00MTCYiK+PDwG9HCu6kQAX3++WTD+EMjR3jjhTL2nE1/pYpFWqGS12tMKbcr0ruu+ESvWc2QmR8E2RjBhGhYIRRyZxTy7/mghROeC4MbKGRZ1axFELe5MzACYMRfMvfc6QtC5lVtcB4bw3C2OOq8zqqlCE9R5S341qDJiPuFwGSM6fxsAkMPwbJZKi2ayxczVVyT/CWt8MOqPB+0yoVqq7uJnlckBtA5x6DbRaZMsOutMeeZss1VQCeZ9kskqK5APe8eJ+b4uv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 7, 2024 at 8:24=E2=80=AFPM David Hildenbrand = wrote: > > Looks like we never taught pagemap_pmd_range() about the existence of > PMD-mapped file THPs. Seems to date back to the times when we first added > support for non-anon THPs in the form of shmem THP. > > Fixes: 800d8c63b2e9 ("shmem: add huge pages support") > Cc: Kirill A. Shutemov > Signed-off-by: David Hildenbrand LGTM. Feel free to add: Reviewed-by: Lance Yang Thanks, Lance > --- > fs/proc/task_mmu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 5aceb3db7565e..08465b904ced5 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -1522,6 +1522,8 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned = long addr, unsigned long end, > } > #endif > > + if (page && !PageAnon(page)) > + flags |=3D PM_FILE; > if (page && !migration && page_mapcount(page) =3D=3D 1) > flags |=3D PM_MMAP_EXCLUSIVE; > > -- > 2.45.2 > >