From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 826BAD11194 for ; Sun, 3 Nov 2024 22:53:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15F896B0083; Sun, 3 Nov 2024 17:53:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 10FD56B0088; Sun, 3 Nov 2024 17:53:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F19266B0089; Sun, 3 Nov 2024 17:53:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D38906B0083 for ; Sun, 3 Nov 2024 17:53:14 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7C6231205E1 for ; Sun, 3 Nov 2024 22:53:14 +0000 (UTC) X-FDA: 82746286014.14.3BF19F6 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf07.hostedemail.com (Postfix) with ESMTP id 03B5140013 for ; Sun, 3 Nov 2024 22:52:28 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=netflix.com header.s=google header.b=oLV34mfh; spf=pass (imf07.hostedemail.com: domain of tandersen@netflix.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=tandersen@netflix.com; dmarc=pass (policy=reject) header.from=netflix.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730674345; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H/o07MZV6TjINQ+zDnpBISVrIcwIjg5m7Y/v0tWWBlU=; b=ksvWMsy+jAOT+Y6tLmSbVPvd1IWz2B0ICVwxa2c1SbOcYCHMjtyP9zzgrbPoole/qhnvUN PHO27F7tH2WwC7F2+jhrleUdU1kViBfjgU7jMoPOOT3iVP9agFvum3sE4bhC2+jNJGlVvc rRUpJcpYBqHpf1yCl5OAVgLwN3PTPDI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730674345; a=rsa-sha256; cv=none; b=zd4FEW9CeAGyI9hP+zzAfsVw+Jg41Q8tkCie65uWRiY0KxwOt9ormd3uIfPq0zESoWkFmR CnG1aNhIyQWz9aqp0GyUpQDeBl4R6jebZLqqvqL6sLo8TlppymGtej1aMeLoCU0iIzGhcL RpK2QdlyHaMt1i8qyRehPZyxbB9QfjI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=netflix.com header.s=google header.b=oLV34mfh; spf=pass (imf07.hostedemail.com: domain of tandersen@netflix.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=tandersen@netflix.com; dmarc=pass (policy=reject) header.from=netflix.com Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a99ebb390a5so851871766b.1 for ; Sun, 03 Nov 2024 14:53:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; t=1730674391; x=1731279191; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=H/o07MZV6TjINQ+zDnpBISVrIcwIjg5m7Y/v0tWWBlU=; b=oLV34mfhVGSx4o4zz9Cy6aPRbIvTMkLyB8LYz8f7b8H6spk7Wj5RswCSc2fCoIQRk+ 8VvKqt/+ScGmyA15obQyFQoC9GHCn3uVMYxOvc+dkh7FNIzeaEE+U8XTQcshilmo6EkN 1FoUk99xuUUvtwGU3fCKRbq0nChRBVHamyIKA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730674391; x=1731279191; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H/o07MZV6TjINQ+zDnpBISVrIcwIjg5m7Y/v0tWWBlU=; b=MPuKvWQP9dMrHiSWX7USfBoGqDqxaeK0LqX8vOhQlaZrHmpM/IQarCq0w8naIWEJkX jhAxbSok/QSC3FB1z3mDcUYG05WJRTcFDpHIwgjFjeJ6vsttThyAmSLAwzZRDz/ZcR5O jdnFEzKyiiCzbO2DtfQqbebKNwF/VnGCvM4VjcsRWkglL6fBAlE7/Z03+83obqLJQEug Yl5zPJrAjAdkxryCNwjaiDInQ/2Q4s9c3rCHYe/7aekSrNM+Enrg2xec1//PSXURNOM0 MTPKjnmq+IcXu6d1cJUt7GcrfNxDuVarfJe1ghNPgr6CxzxYahmmAZvpfyrRh0asRtDJ C9Kw== X-Forwarded-Encrypted: i=1; AJvYcCXm6wKOVTdjbMy9CRFAKu4ui6yklo5gc+3y6xvamKn3rvNCZ1hQJgdURJU0L8nNkgFzTkzKG/QrKw==@kvack.org X-Gm-Message-State: AOJu0YzJMpca2EczSptLRo0CK3cv4hHhNOK96t12bJyMdI0osZiCORZy bvE4KZJs4C2e/l58fTiF/BN2ncG+JKcZqqiqUGk1Kyz0aX9ucW/tYglZ+mZ0E+YAPwH8M36kX4N o5ttIAVkO3tk3UkAT/O5FR2PF3zQQH6xYjC3T+w== X-Google-Smtp-Source: AGHT+IFy4o46TYKoQTbVYKAMB2on6bfie/1kLl5cIFqDUnN/9UDRY5lszF0hFgsjo2kqN5eCFId2gUMEqsXUF4IgBZM= X-Received: by 2002:a17:907:3e9f:b0:a9d:e1db:de8b with SMTP id a640c23a62f3a-a9e55a80e56mr1303129166b.16.1730674391087; Sun, 03 Nov 2024 14:53:11 -0800 (PST) MIME-Version: 1.0 References: <18f60cb9-f0f7-484c-8828-77bd5e6aac59@stanley.mountain> In-Reply-To: <18f60cb9-f0f7-484c-8828-77bd5e6aac59@stanley.mountain> From: Tycho Andersen Date: Sun, 3 Nov 2024 15:52:59 -0700 Message-ID: Subject: Re: [PATCH next] exec: Fix a NULL vs IS_ERR() test in bprm_add_fixup_comm() To: Dan Carpenter Cc: Kees Cook , Eric Biederman , Alexander Viro , Christian Brauner , Jan Kara , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 9dg3ckok86zjhe7ctctwamtehk6g1fmh X-Rspam-User: X-Rspamd-Queue-Id: 03B5140013 X-Rspamd-Server: rspam02 X-HE-Tag: 1730674348-254209 X-HE-Meta: U2FsdGVkX18QaoQl26CMDWSz3fXl3PzwwtvgBisicfOKoBPSGeMIeVIZh6pQF7dA2tQleqz252dVjbbEU0ggGXkT9KiG1YI5D/CSsRkMBQTH89SQW20L7ZPoQ98PeDlkNzjC93S/SwPTHRkCzqxO6ZG39OT28dBfsmB/UGO0sedlg9uZknObiX/TKjiwD6gtNUJXw9ivyaEaxgCfw9CGMnxNLwex/B3EC4l6G4s+ZxLg6BRnsYSb24Bc7OL+ADdgnJXMDANigMXwofst6ML3MKxqzjg0XvaaTEkTsaRbKG4n+8TCPMmrOD6IZ1G9Thk+0G/yeQSwmIWxA8TdQllm97+fOEFywV9gcdOtpg3IatY9bFmBR6byFOB0SmBLsEz8h97HRI0hpxR9/tjl6BdawtooC6gTH0c3Tgf1DIrFHMwPHR0TtBmzlI68bZZMaa3b4sgaqr+DIFwJ6GIGmkFzXQf7+E6gb7PiZ7DBrryaN5zT3yTtqBHHWulTk2bC762vB6ajGkZHqGX8H38tyx0ZQEqgT8N16FlXA5IZsL0C+Elu61AO3rfgDoqetAAnWwN7rVv9KVqGAOG92IDlJYyU/HSan+bxdfI+PTn0Uh9/EWbbjYKYCH5UVzRbtIoPs8LUaTn0IExcBC1WD+80ps9wk3PhndnCyACu0QppK/pl/10Coj8gMR9I4nHn/wQJ0DESpWIymnerM2xL8etQAjB7zr/TCdYIVGo22yhWCe/eadEl/+WdSo4XFEN6BjYU+u1+XGBZ30IKbEOkHtMGJ47jvyz5v3/1LNqklkfu+r+qtxH9HHwmKYUUFVOAW+SFtmo51E8BYUo0A6DHTqPBA+Wr++VNDO6R6R2pKgWvZ9ioDdubAlnDSi5Du1WRoyslAepcPlKsUp8iXtc6Sc052QLdVJBwLEUZ8G3VJZXnQDpg4N40b2eYQ5Ds+aQTL4CG0dPa312use3vdrJJvVSRJVT zcl60r+p nTD8Goekd3KWjpS408VDMkORg385GxkaR0RjGktRp3b2W04ugji1FBizSYqb1yUXN9n7nXNwjwxE5FeAJhQJINw6rVHw06eK8e1v3TVawA/OCpKyUnSaVdy0y9Djs43GUhXBdJOj6Q67Ydg6ZQnvb6rYNOmteMzmdIwUY5LVa3A2+emD8xZOxCzQaAiCCZ257EReGHYH8K98Hq42tO0/r0JJACA6mRAi2wvWPFEROFkSChYsW8xUD7aJZLBFzjLL/isJUVrip/C/7OZErVdtH/PWthdU+hp+D+FhGx8GzvnsvNVoMap/3G72fgQlKJ0O+wp2e X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Nov 2, 2024 at 3:31=E2=80=AFAM Dan Carpenter wrote: > > The strndup_user() function doesn't return NULL, it returns error > pointers. Fix the check to match. > > Fixes: 7bdc6fc85c9a ("exec: fix up /proc/pid/comm in the execveat(AT_EMPT= Y_PATH) case") > Signed-off-by: Dan Carpenter Oof, thanks. Reviewed-by: Tycho Andersen