From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 471EFC282EC for ; Tue, 11 Mar 2025 22:13:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE72B280002; Tue, 11 Mar 2025 18:13:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9727280001; Tue, 11 Mar 2025 18:13:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5FA6280002; Tue, 11 Mar 2025 18:13:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8BB3E280001 for ; Tue, 11 Mar 2025 18:13:09 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 26AAE4A42F for ; Tue, 11 Mar 2025 22:13:10 +0000 (UTC) X-FDA: 83210671740.22.7E84291 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) by imf07.hostedemail.com (Postfix) with ESMTP id 36FFD4000A for ; Tue, 11 Mar 2025 22:13:08 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=UB+tTWgd; spf=pass (imf07.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.210.47 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741731188; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9gx/uI7Jj+LFnh/Y9Cm66/wk2fyG/s7LdrL3JXmhnGY=; b=hocLpXpRXFOtLoZmSB1Abt45Xw161x6K/xXaRhviB4u7IJM3wkqsFmP+nxYWpAe2sVEgja ctcmkz8tLieYrsO8srdvLCWzka7TKbQREZIbH8YAA+/wUi18GQLCW5K8pzQrWLBjU1xndX jCzAGksmOcNFDH/WZbF/fIFT3MLCKwQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=UB+tTWgd; spf=pass (imf07.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.210.47 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741731188; a=rsa-sha256; cv=none; b=aGzv1XFugM+z3XorefeU36q3kK50zCrLhK97b4f/g39H5pgPW4RAIzP90cJNj1DC5u/dGd wkLgvUy8okwSTmkg8Mprchs63n6tR5Hx5zXmjChlKeN3cQv06sjo0znq2vaQjAmEpF6wvN 9lx+EV0s4TDeDc6HzUC4NbPcUyP5AEQ= Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-72b938f6014so287550a34.3 for ; Tue, 11 Mar 2025 15:13:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1741731187; x=1742335987; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9gx/uI7Jj+LFnh/Y9Cm66/wk2fyG/s7LdrL3JXmhnGY=; b=UB+tTWgdYDISPt4FNbQatRTQkBKGU/Yb4+uR1FiEybNed5amoAo+Za8PFkCrxVzBFA IpWhqRFWt+zIBDyVNFB35wO64sDEC4W4cwQqe5q5YKzSjVuFg/Oj1QmD1DBQNrswX6Zu Y/ZFtEXKDGEJTjfrPwPjHIycmLEtvjj0Y0I3U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741731187; x=1742335987; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9gx/uI7Jj+LFnh/Y9Cm66/wk2fyG/s7LdrL3JXmhnGY=; b=Snaqr10mzvmXS0cRSB1QG5QCywcjORKNuw9voEWqAiZy7V4DNtkdZ0d2WUdFfG5IHy 7L6GlSFW++Iz6oT4TxH6HulEPeKCIh+eIUMN3C2P/++ZhjbIKfKviHOI1vNeOKr3C2ob KxMFHODpuYy4QTwx3tLPQ4vYFloHPq0t7Xfn+a9NwbcMUg3zfM8uEwzINSVQdfx/iTjY X2XHKwhXtoRDaO1/FuCNczgR5MrHR0yW2b0/sB4NfMRnmje4L5tBjkoAoEKzhZhyimTy wf+PxztiOD8S36wL689ffWW7tHjsYmiv3Rz8x1bF9G6VL47avMChnw5QAxv7ip8R9L3w 3H4A== X-Forwarded-Encrypted: i=1; AJvYcCVtEYUrsSyrAmsYswe2iVxKPU/tphXl6DYhcQjdLSvhbMa6yRdHWGys6mGac6H0Mj1AudsePuBaWQ==@kvack.org X-Gm-Message-State: AOJu0YyMWd4DYNPr0rSu39cPLO0SIY4MOcHVQzb+cOecXVJ7t9rikNxy iwiPsNlozQBr8MaiuaqYHhCfkRtashiEpwUjbVJm/3Zg62/PJKiouEPRBnlEWTRHZCKshCGchLy RgwHf+/vEb6YRFwDvm2WNSKQKVY6OKLnFIceu X-Gm-Gg: ASbGncuFNGG5TZzNn3OOM4hCRE5MB06OOa7AFkv1moWIbEi2wpNLwSGRKLCwgV63HjJ RMVGQI8toGLdvh8Tf1FNAe9CBRBK1m+i9btvx3hb5NfZzumRM4Uv57c0cBk+61bCMH98bpgUwsp ADOQ/8vKPnhIjJVcoYb3tyF8So X-Google-Smtp-Source: AGHT+IF6cHOCc1/WT6rYQME8ZwTzRijq4TF0n6zKoV4EldL5MeMYHAbxupldljEVnQ7QDui54Qopy4486X05dA/Olqo= X-Received: by 2002:a05:6830:3808:b0:727:32f5:df87 with SMTP id 46e09a7af769-72b9b51ba95mr1072927a34.4.1741731187229; Tue, 11 Mar 2025 15:13:07 -0700 (PDT) MIME-Version: 1.0 References: <20250311123326.2686682-1-hca@linux.ibm.com> <20250311123326.2686682-3-hca@linux.ibm.com> In-Reply-To: From: Jeff Xu Date: Tue, 11 Mar 2025 15:12:55 -0700 X-Gm-Features: AQ5f1Jp67jwM-684SO1tDeImf4lP5e9Q1ZLCVvcfHKRXZQkMxKgJL8mewS-yfP0 Message-ID: Subject: Re: [PATCH mm-unstable 2/2] mseal sysmap: enable s390 To: Heiko Carstens Cc: Andrew Morton , Lorenzo Stoakes , "Liam R . Howlett" , Kees Cook , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Alexander Gordeev , Sven Schnelle , Vasily Gorbik , Christian Borntraeger , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: cu4ceqd3tk7e1u36wxi8z83txx6qeq6k X-Rspamd-Queue-Id: 36FFD4000A X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1741731188-113296 X-HE-Meta: U2FsdGVkX19tBystMZtBM9rdPzlksQQIw0fLtv1l3+HtCb2IGYVI3sJDJhO0d0tqR9UZ3Bh7/9mK0DWAE8dLxFPM/1ZucCw/X6Ei3hF6NCZ1nVBryPrNXQgIXGDtdtktZPfKsD0qb+i5mwUpp5cq2QhoXTZdfIHuedE0eWJllcR4tN4Qc4KDxcFBza1M0/ep9L8KscYLxRLLph6uvjnsGv9mc+akUSnK3d/ZTWKhDd+n5ulY2T6rENAkV0wwtHobfJ0WksFNd8dPbG2ipS5flUx5VZaw/mqKNwhoqO0nY3Bbrqk2V9KjKoMlesPQiUEe+anZA//nLsr1sFEjSuL3PLJdVbweT6z7ZNOhU715AQ9rciqHj5aMhoMG8UQGKAnlNrqJZ+HwSXLrEgBawdpkL+FFX+4nfvl4PxuRcwf3Yoz0Jbv1yTQ1BCVAXDYNtM5xQSjXqo5d6zu2AJQtSo1Tv3BcDbF6oZ+vQyDCYv6OZw8Ujfmf+lLrawLNwd5bwDyp8YiTVAJcdS76aoK00Of6Tp/zqPmH6CaeRoHeU/mPGdEoQxBp1vojm8QFuhj4ZsYWQEbcJEq7DW9MKJM8IvzLSUUmsFd4FpVVHEnU1yLU6Txoaj+xVT40v9l/T/eR4mRNpmzLOVxiw3Iv/Yu/oI4bEsMbw1V9Kxax4Nho/UyR0/h2g002FMZrP+Vrj0LzLCWMhhk2E/a01Fv7CXv7AO8cRiEhOCZrJIne50HX7dIksbVaYF1XoJLiUChm5NcMiUnZrqh4u+CafFHcV169HCRLEuJsR/yiMoALmgPM+pR9iaFSTcdgtHaBQw6Tmilx8ivEuCeuVAagHYtndIikps02mhTuGKzidwE+/5QZzDvlmqAc/5HuoPZtihLNRcmihipSJLj/q8hK8qd3kCXerBCMEFsRW8IEpLhJCMO2T3vmnUNsM7VekxZusjKzCMhmCGLbBhO8Hil3jRvI7m2HK3r DqIHv5ts dsvYKbylOKoLJ2iipj9UzZrJ/kXf90cdpfiOUlkVEXEIvAXgQQgG0UZzaQpOlfyANmMyuINmt5SwAL+5awwNz1167fLAqQwCmaDR3+5mYAljnK3renmiEK+RL1tHofSVUX695sWdefcXSwrnVMsXhTRJjK4+Tc/jGJfayMPR3gLb+yzOjH4iXVMg/+JJm7KrfJ4z+CETjsVxMTjI4DVC+NS+8OT9t81kvhTVQdgtVQbQMLMMu8yWt02j+Yw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.043937, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: One more thing: do you want to update mseal.rst to add s390 as supported architecture? Currently in the mseal.rst: "The following architectures currently support this feature: x86-64 and ar= m64." Thanks -Jeff On Tue, Mar 11, 2025 at 2:55=E2=80=AFPM Jeff Xu wrote= : > > On Tue, Mar 11, 2025 at 5:33=E2=80=AFAM Heiko Carstens wrote: > > > > Provide support for CONFIG_MSEAL_SYSTEM_MAPPINGS on s390, covering the > > vdso. > > > > Signed-off-by: Heiko Carstens > > --- > > arch/s390/Kconfig | 1 + > > arch/s390/kernel/vdso.c | 2 +- > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig > > index 608a965e2344..93b880992596 100644 > > --- a/arch/s390/Kconfig > > +++ b/arch/s390/Kconfig > > @@ -141,6 +141,7 @@ config S390 > > select ARCH_SUPPORTS_DEBUG_PAGEALLOC > > select ARCH_SUPPORTS_HUGETLBFS > > select ARCH_SUPPORTS_INT128 if CC_HAS_INT128 && CC_IS_CLANG > > + select ARCH_SUPPORTS_MSEAL_SYSTEM_MAPPINGS > > select ARCH_SUPPORTS_NUMA_BALANCING > > select ARCH_SUPPORTS_PER_VMA_LOCK > > select ARCH_USE_BUILTIN_BSWAP > > diff --git a/arch/s390/kernel/vdso.c b/arch/s390/kernel/vdso.c > > index 70c8f9ad13cd..430feb1a5013 100644 > > --- a/arch/s390/kernel/vdso.c > > +++ b/arch/s390/kernel/vdso.c > > @@ -80,7 +80,7 @@ static int map_vdso(unsigned long addr, unsigned long= vdso_mapping_len) > > vdso_text_start =3D vvar_start + VDSO_NR_PAGES * PAGE_SIZE; > > /* VM_MAYWRITE for COW so gdb can set breakpoints */ > > vma =3D _install_special_mapping(mm, vdso_text_start, vdso_text= _len, > > - VM_READ|VM_EXEC| > > + VM_READ|VM_EXEC|VM_SEALED_SYSMAP= | > > VM_MAYREAD|VM_MAYWRITE|VM_MAYEXE= C, > > vdso_mapping); > > if (IS_ERR(vma)) { > > -- > > 2.45.2 > > > Great ! one more architecture uses this feature. > > Reviewed-by: Jeff Xu