From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBBA3C83F2D for ; Thu, 29 Aug 2024 14:33:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A82C6B0093; Thu, 29 Aug 2024 10:33:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 857DF6B0095; Thu, 29 Aug 2024 10:33:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71F586B0096; Thu, 29 Aug 2024 10:33:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4EAF26B0093 for ; Thu, 29 Aug 2024 10:33:15 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B5737AAB61 for ; Thu, 29 Aug 2024 14:33:14 +0000 (UTC) X-FDA: 82505525508.13.57D0946 Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) by imf16.hostedemail.com (Postfix) with ESMTP id D8DF6180027 for ; Thu, 29 Aug 2024 14:33:12 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=GnU3miHW; spf=pass (imf16.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.47 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724941874; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lbjfLJ2fqDDhqtUpB4c2guraSJR6Tgu7wwzcqEJUoY0=; b=sMJy7VbvZnG9AYHWAyOVd/8o0U/Tp7xGIlg491aJKJbOci1dysdhCG1PhBy18ga67+eBMJ TzJTgoblyvUb4m0VN5t8QGUFKYKU7apBZWy0DT0BXvaF534yKLPRz6op1KaqVqSEq7Tfyi WLPk1IsbOyQ2NpgBh+n9smVDyEEzFi8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=GnU3miHW; spf=pass (imf16.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.47 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724941874; a=rsa-sha256; cv=none; b=yb/Ck8ACLz3Ukwuz3uq4xajTvvOPWg4GmYi8di3luUKX1y29xG0SI8kND4AD/SAUfvqFvz TdMLvf4Rj0UMTKfopNJUat5lhTGM890pNuluZBT2wghyRRI8QaUCTtcpmsHAankQ2k/hTM gsAaF5C0K+lcswftFVclq3+hK7C/JE0= Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-2777cbbcedeso92461fac.3 for ; Thu, 29 Aug 2024 07:33:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1724941991; x=1725546791; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lbjfLJ2fqDDhqtUpB4c2guraSJR6Tgu7wwzcqEJUoY0=; b=GnU3miHWCZx71/0ob5VIrrilHHZ1G4rlRy+KnrXedGhar4HZcp1cElYPJkLZW9HZ9w 7iaQICjVSWrook+PS4IJVmDsjQTpeUiDBPLAp4oxDQzE6GqWeo6wfnUtSR8dJEcNWs+m DgsPv+yAuzT3a+CV0o8oRnX9ZWjfHsPaa+ZOA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724941991; x=1725546791; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lbjfLJ2fqDDhqtUpB4c2guraSJR6Tgu7wwzcqEJUoY0=; b=NB2L6SpN/rTBoqjmgF7sEGUXBNZlPNz0GxRUQhtuOOMuRvrvS8de9SBauBzre9ULJZ rv9Sju1Ho1J9AbmVDAny9WF2xJx1XyMOntCSGEtS9ytWxAru23gTxl394/dk6boQeyCL wWg6Ulp63kWp30z5BDtvLv1KHTIkcssrPS1zcU4oKnyQj090pRXMnGOEcOP9TedbIrle gXHK5gftQKG5RML+xXv+LJP+lHnHFsozM+OOjn5K/mq4JhHN/rILKsLNZeSQs2I3bBj4 xNyjCaZRfHOEUjKVIVxgYefgpFo0wkUl0ziY1Ag526xkcu9jBJBtm4uQKoliMnM8fzM4 +00w== X-Forwarded-Encrypted: i=1; AJvYcCUB3aeonpxc5kj8l6q6qG6IT8sltDGjAo9KzrIFhKyg/Ww2XWA+hk/l27WhTAMFV7dmZRm9M9Pbug==@kvack.org X-Gm-Message-State: AOJu0YyelBV1TOTlOSrRQaxQQ61JYiBiYJG16dP8P63OTSs6OvKYL4ca PTtU44ezwaeAKlEkmRPuU0AoXwLgWO7hMnH5y325Wz/VZxj9vya1srF/+UW6Cmpq7UU4M5rPBC6 BNwG7EOFUmVbQBOLYX15Cjy0e6csk/g8IdqyU X-Google-Smtp-Source: AGHT+IF7hEs4r13r9Gs1wT8QNsV78DzGrCss8ANs+XXz5eK3kud3soytApHKrEVu7yGI7fuxaztQAt7RmbjOdNAlsjA= X-Received: by 2002:a05:6870:a70b:b0:260:23bb:1087 with SMTP id 586e51a60fabf-2778fd5b726mr1752368fac.0.1724941991020; Thu, 29 Aug 2024 07:33:11 -0700 (PDT) MIME-Version: 1.0 References: <20240828225522.684774-1-jeffxu@chromium.org> In-Reply-To: From: Jeff Xu Date: Thu, 29 Aug 2024 07:32:58 -0700 Message-ID: Subject: Re: [PATCH v1 1/2] mseal: fix mmap(FIXED) error code. To: Pedro Falcato Cc: akpm@linux-foundation.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, rientjes@google.com, keescook@chromium.org, Liam.Howlett@oracle.com, vbabka@suse.cz, lorenzo.stoakes@oracle.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D8DF6180027 X-Stat-Signature: cip6je14ui4ym5k1554akhn7qo9caxhm X-Rspam-User: X-HE-Tag: 1724941992-605814 X-HE-Meta: U2FsdGVkX1+n8bcwpLJthy7475kwfKK+EMcYiVF0PAET7dZaWrcvWXBTbLewzb7RTaimmp7Tot+2UZQe2DZWuZEYFMkCvlLkNyt4fKpePAo48m++RcVNGWNohlpxydzdj3d6namTU/T7eWH251I+tXI1Vq11I4I7ksTds1+eqe9mmOoO+eAGsD3TQ9pBHnrZUmofd298uyiKd3SfvLha/SamPz7CPAcvQQgIEKh+hTQMBPgSvsu2xmAf26JPfUBv7u+vy9Os+QR0MtqLn1zrpmsv1li+bUoehaWBPMI8YjMkZ/ZkaV7iVCFTUVh9ZyN1ahh3MI9qQXbBKuCbCjxbr22J5eFzFm74fjpDiB/FoWTF5u79nj1gid1qsa45O9Lhvqp/HovcM4YPUBAzQ9SQTxpYdMQPxnJJnou7f5aP1pNixLEGO3clh/N7shA9kiP4F54rFHOhQdXVNgneV/sY+Xo92pDFagmoXlmtUD3G7IfThC83ByV8fI1KB8iRx7uUQQQG8OgtnPTimYz0i0VgN/oLKqIkNv48LkYyB3ONrWgfc8jCIGWdCAeSz0KA4gGTOduJQ0D1l/brYnGo1MC6I5nKZtkI2TmdRv/671Or38l3VQUSeqLB7BQPV4NcJLgRqxjcw30GxK/lynyDrMsIXWRZ3IpC45hHuUwlsl2ny5qSaNyWdPJJwOxavL8BPR45v7BlkbTuq2Ovj+qXFW/rcgc9fZmjx5Ukz1ivYUYsWLLExWZ9puomoT5r6/N8Hze6SeY83ufEmQzhzFkkNOg5HBLRef6DyXDe7JAyTjABVSyFo5Ew5Q8CNys2iZynnLAaacZ44sXdt/CsMRBGkgitXF9rKD/PQd94S2RFgXVVN9KhFPZljvZKO+bSNoQXXRvsu2SkEyGxAN8C/VSKcroLDeQDA9aa9JYdxJj6HgHDHq5KOCR8jpuGBAE09s6dnrdn+pGtWAWcHCx8M92pX1/ sSgtYOtd uf87HIJZg4out9OMukgm5yc+870BRb0i24Jl5Agrm5hJkVOirIHtVRcUDJ/Be5c+Yr+01GKlr9wYBvlFJzyTAnFPo9Vz7L7YCqNKILd0L576bgaMtHM0BwTMkhVSJW/g+iopR0I0O0u5fxteowqpqpjaz5NP63/NmM4lBZSJAPGAdAG4/KPnIOcuwc6wDBuNIPNKC0C4Mb1fZG0oTvXsayPW9AvM4UM03o9lFKXEJsHKXsN63NTWzwJSRcgLUZNUIyxN7gcemB1o3J5OkQptlTN/Ng135EcpeykcnxmG2FhidvISikydk6cFFoNV9xrYeRfMrl30NisGPfPVPUgrNEUgULaYhfc4C6dKW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 28, 2024 at 4:38=E2=80=AFPM Pedro Falcato wrote: > > +CC vma reviewers > On Wed, Aug 28, 2024 at 10:55:21PM GMT, jeffxu@chromium.org wrote: > > From: Jeff Xu > > > > mmap(MAP_FIXED) should return EPERM when memory is sealed. > > > > Fixes: 4205a39e06da ("mm/munmap: replace can_modify_mm with can_modify_= vma") > > Thank you for the patch! > This Fixes: is wrong, the bug was added during Liam's rebasing of his mun= map patch > set on mine. > ok. > > Signed-off-by: Jeff Xu > > --- > > mm/mmap.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/mm/mmap.c b/mm/mmap.c > > index 80d70ed099cf..0cd0c0ef03c7 100644 > > --- a/mm/mmap.c > > +++ b/mm/mmap.c > > @@ -1386,7 +1386,10 @@ unsigned long mmap_region(struct file *file, uns= igned long addr, > > mt_on_stack(mt_detach); > > mas_init(&mas_detach, &mt_detach, /* addr =3D */ 0); > > /* Prepare to unmap any existing mapping in the area */ > > - if (vms_gather_munmap_vmas(&vms, &mas_detach)) > > + error =3D vms_gather_munmap_vmas(&vms, &mas_detach); > > + if (error =3D=3D -EPERM) > > + return -EPERM; > > Not sure if it makes sense to special case this. We should probably deal = with this inside > vms_gather_munmap_vmas and just pass through the error we get. > > Otherwise LGTM. Liam? > > (we should also squash this into the offending commit) > > -- > Pedro