From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9742C3DA6E for ; Mon, 8 Jan 2024 16:00:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 196EE6B0078; Mon, 8 Jan 2024 11:00:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 148296B007B; Mon, 8 Jan 2024 11:00:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00ECF6B007D; Mon, 8 Jan 2024 11:00:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E382D6B0078 for ; Mon, 8 Jan 2024 11:00:39 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A072040856 for ; Mon, 8 Jan 2024 16:00:39 +0000 (UTC) X-FDA: 81656606598.18.D8D5D3C Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) by imf12.hostedemail.com (Postfix) with ESMTP id 9889040036 for ; Mon, 8 Jan 2024 16:00:36 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=nljWODD0; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf12.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.45 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704729636; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LhaTWMM1J7fnFC4m0/Is2MdvAgnd3Gn355pGFsoQhag=; b=ZrTkmkPWWHTHDIuvSngymsQ7LNQsJanLfE4LHzBuTJ9/J9TaGe6r0RkfUWEt36qPhdxkz8 6byn2Qo3UfFEU/8HZcqO1oAzgJQir9AA2FBxcymu++XJpKhtA7IYHKl/qfLqfR9Zs85vGQ U5Tke6q2/lVzh4WJN+spDli4gm2VlCc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=nljWODD0; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf12.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.45 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704729636; a=rsa-sha256; cv=none; b=SZx53b8mZbe5qHm5sVJG2MU5teEc1+POStwxxtrAK4KWzFFAQe2aMRNshRmUatW5yt7CFn njs7gV+zi23sosrHUK9NUCEYgMUn/sPkkZOZob+JiV+fquV4hLbs8H8JSVcx5XlKRsydkh b8cwnJNYB2w3dU/ahuAf8d1gutt8ISA= Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-204dfd7a89aso957322fac.1 for ; Mon, 08 Jan 2024 08:00:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1704729635; x=1705334435; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LhaTWMM1J7fnFC4m0/Is2MdvAgnd3Gn355pGFsoQhag=; b=nljWODD0/PaO+nNk2ElNtHmX2+ua4dICD0wAm0kkzqoEcBlVEgcg5vLIiKsVHEvmBV SZ6iPvwAZm86GwZgY32koHdct+IKcUtCbo6vnkes4zAsrkIVwJOUrzXkmdA99JrM1kCu y7ztTR7S8kOrLduBe6g/CuxO9YmxUD+GFvfAQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704729635; x=1705334435; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LhaTWMM1J7fnFC4m0/Is2MdvAgnd3Gn355pGFsoQhag=; b=ttg4hh7Xjqas5zxRu3PzrIBGhvJvyWwl5t49d1Qy3/SrtXzdJwVp4GFDxK++/QSBnl L+xSOzkcQiYgzxEJ+YXBD4206go/txiRkiMVv9d38XbURHWmihD5Wacf+irIxSX537g9 xAL+7saavfBctVu2hxzLjedjetGxQXssIRInCndJrwkSnEuJCeUhQ/zp/7JtVXRFkz/u q6taUR4jLh0UZbrnGJG82w2ENMwgEkRZ/QbcahShPTO97K2ikUFfTQqnmePs2I2GA2Z2 gOb/pPY1eQEz1AYWJd0TfPwvAO2rQab+IalYAJGTxq7i9KAEv0rhcXGRg9gL8ftPUDe5 yhCA== X-Gm-Message-State: AOJu0YzT9Qg/TA8BIfUOw6oS92tsGFHoTqKjIjLwRtHI+lNA07qaPheG 4v2Vb3P6FJnNKb/YHziFR2i7X8nnw7b9ATUwYvPEBTKqGeBL X-Google-Smtp-Source: AGHT+IFsyr9PipomN50qTzZSjGmht0Y6LotO8i5wTx1ikP902yVEMEd9iRDf0Klegy5vhidUtbKEgst4FKgIVlgOddc= X-Received: by 2002:a05:6870:1587:b0:206:3c53:65b9 with SMTP id j7-20020a056870158700b002063c5365b9mr487892oab.52.1704729635730; Mon, 08 Jan 2024 08:00:35 -0800 (PST) MIME-Version: 1.0 References: <20240104185138.169307-1-jeffxu@chromium.org> <20240104185138.169307-3-jeffxu@chromium.org> In-Reply-To: From: Jeff Xu Date: Mon, 8 Jan 2024 08:00:00 -0800 Message-ID: Subject: Re: [RFC PATCH v4 2/4] mseal: add mseal syscall To: Linus Torvalds Cc: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, sroettger@google.com, willy@infradead.org, gregkh@linuxfoundation.org, usama.anjum@collabora.com, jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com, linux-hardening@vger.kernel.org, deraadt@openbsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 9889040036 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: basfez1b65mjsqao1emju8te9moq9t8k X-HE-Tag: 1704729636-470528 X-HE-Meta: U2FsdGVkX19F32ZtlHJ2lrO5VbgFPw4+cZUyeZsgwYByQ/kL5/TKDmDf9i88XzZSrL4O3WBFnJm9YuywUq5Ifgr8J2gYV3ly6F2n932JDPSzVhKjDLAGqSgWdGeN6bTZ6ApiVmQsoTNmy1MorVNTb1dShDNA/8QKFjJR/b67VhH93qFSn2aUD2AWbth4BIsxIJhMomIF11oek9bq1KWNQoSEv/l1TiX8qTBR2F59A7spKaCCoCsZ1yA8mRaJnrkQ9EmMBeB1FGkQYIarT8iBn/+ocibrrTB4tM7QIiPhWuNK935zfnmqAnvYyXe2ZJHxiimW0PC8ou2CUqKDkpXeJnJX1bbapocew3/G9hz0pAvOE59UtHatTPoqk6mPSjGZXilH/wV6bHoTCC2SW0Asyc1xa9imGybac/VdLbBqwDiU2W+4rs8jXcKSRCKPtWqjkgdb3/GdyNp1YuW8lS3rH5zC8gpk5+4BHT2qK/MfNcRF5DCt+FdSJ5h4dVpQ3SInM2KzJ8hn1NlAioXh3JGrB+Vh1whlQSDY06WOlyuB+OByEhmk/ISpI8Rf36WXz6wvoHtqZysPKFKo/7apgiaqso8x1R55c6BWW3T2HHO1wBivN80mcBu+V0jHHtKMXQxv5QLFsrRUox5DLQZtjzfu2H/lW0ZDYT38kQSlwzENJ0gcmeaS/gwT5Dp9PmyhiH+ddx9+7lzRfLNYphwSmi0FgGZKNDbBnTRDAC0eEZPa+geaeIk1dzbktTLxlx1Z+NO27LAVIBySS4o+HcC2DUIWB7x9IFW20cmUi/2Ity1pp+lK0S6S9v2NU+am/z+uSuz7rrb72D0zTH/qITcM1OD85kXcUfWQLcn175Eo54PjRVzfww8YWcHnxEN+VWO2uIwublpPgsdEmmN55eSUh4Ns8xa6zmKKobogYBQF8pLY2JSPUj3zH4zX62OLLO8x+JPBOkyA68emAe2hcmxJ7Mm kGmA5L2x D4Zbc72S2C4Fbh/MFYUSyHA9ycBYbYM/9bUsyXoo/iGVnYCl56D0D5sUkYhN1fXKMQpjs7nvLRo6vz3h+Q8BQMXYnU/VNd5xaNiv70JEJWrBFdm5ACV8HHCPtvhuYGZczasvz4z5ycisSq3wODAo4RGtBF/ozLjf7s7CC+X4b3hfwuLLv7dPc6CWVJy/uY8/ZDBJsZE+6Hmy8ntS3k6SN6W0ShEU7elJ6o8mmtwizXlRxyNT7u6XNXp3ktoKrCtaIJhvMD1VpLYv139t3oJoqkboOLWUP8rJaC7jF3xr6UV7vZ5yAqHgbZr9JvR99SjCCrBg3UjwZwl+fC66lKEQmXO+Grn3rg8KJ3nWMSpcKSzkyM3bv8QicmtMlvtIR46u/dr3lYJidQt6eJW0/xrUUX668ZWn3rcWpVWxe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jan 7, 2024 at 10:42=E2=80=AFAM Linus Torvalds wrote: > > One comment: > > On Thu, 4 Jan 2024 at 10:51, wrote: > > > > diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c > > index 9a846439b36a..02280199069b 100644 > > --- a/kernel/sys_ni.c > > +++ b/kernel/sys_ni.c > > @@ -193,6 +193,7 @@ COND_SYSCALL(migrate_pages); > > COND_SYSCALL(move_pages); > > COND_SYSCALL(set_mempolicy_home_node); > > COND_SYSCALL(cachestat); > > +COND_SYSCALL(mseal); > > > > COND_SYSCALL(perf_event_open); > > COND_SYSCALL(accept4); > > Move this part to PATCH 1/1, so that it all builds cleanly. > Sure, thanks! -Jeff > Other than that, this seems all reasonable to me now. > > Linus