From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48F7BEB64D7 for ; Tue, 13 Jun 2023 15:26:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE5588E0002; Tue, 13 Jun 2023 11:26:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A95906B0074; Tue, 13 Jun 2023 11:26:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9845D8E0002; Tue, 13 Jun 2023 11:26:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8C9D16B0071 for ; Tue, 13 Jun 2023 11:26:42 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 65726C0577 for ; Tue, 13 Jun 2023 15:26:42 +0000 (UTC) X-FDA: 80898101844.11.BF2233D Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) by imf08.hostedemail.com (Postfix) with ESMTP id 2563C160016 for ; Tue, 13 Jun 2023 15:26:38 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=l33Kcibk; spf=pass (imf08.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.51 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686669999; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sP5idTvIDCNhphFxgMYPrqA/v5X6PDGt+hLyjhHCuqc=; b=3ALoUu6ch8TjbeTjLChS4nxG0Yp6pFMUIXB6BBCv2fnxruaJBlPlKm1TmEegMDvIE3eDBK zemaQqTHCHFgUwjun7Yr/jtSLJ+JdqxKhCHConpRNoq9D0Lgy+bNeYy2jzAdj90ezl4yFH kQI+WJ8sJGelV/6Ba7Sux+uH3Rc9heQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686669999; a=rsa-sha256; cv=none; b=ReCMy7UAEDsucKQgrlxXxlr9ZRFYoUJEYB4+FLAWShmEWVLEL+2B2X2LMNe/0kiaYKiBl3 WSlqb1j6AQPl6pvNzsweGqzaUaZ8CY0tmxs/mQkvy5CyEIkpq/12gqLGT5eECu/uCjGCFz IL89PVjfTqr5bBbNuU5mCYP35t6gQ8g= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=l33Kcibk; spf=pass (imf08.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.51 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-19674cab442so4000733fac.3 for ; Tue, 13 Jun 2023 08:26:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1686669997; x=1689261997; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sP5idTvIDCNhphFxgMYPrqA/v5X6PDGt+hLyjhHCuqc=; b=l33Kcibkx3maWuZGuU6K37uh3DEojYwaVDf/g/Fb7RX90PfwCiHwEjBIqfI9qzRFxF wx8oO4o7PNhBPw3C7eia6LgEALKqi7chYkMHYHQOl8RWFhvdK9hyUdvGFpRjPJSY56H/ L6zSuEgRgahgnb3Q0BJEP/I7jlOE/wIDajstk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686669997; x=1689261997; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sP5idTvIDCNhphFxgMYPrqA/v5X6PDGt+hLyjhHCuqc=; b=jWYrkAA7NV1Lgcfl+UQJJAgxVzyniVs4SKwRRMo0q7DejXeNNTYFm4kLFA04OhBSuO mLr2//H0iLn3PtV2C9JVvRTCxGqAgDn0mTnngcPR6R87cR285d6onseARDJ1AuDR4iez tp98HN1zdryBNIoK7NS9HMLdE8k1CYYQ3oYt8XjfKh8i9FXGmtbo84Qg7f4n742UN0V7 yYm8fckN4AYHVhpe+gqenuOkitB+7pekd6tHQ6m6HgxFAqR3UUPBohsAT6tKAKEHRNSi +D08rmexZvXsgKZuu0KToFPCkTTu3ZxsttDlLEQLajA9FpIYMN6KURDphPjcxxkqPStZ 53Gg== X-Gm-Message-State: AC+VfDz2CLlAhNeCxJQweQZ4qp7nXaDz9o10OocLHR4/kHknlDaJ2Zku F4ZQ0xEs0f95kkGB6Kih1f64AO1BcS25Yzsbq2bmnZinffxXCIQ6 X-Google-Smtp-Source: ACHHUZ6fWfqaRgyeuAlfhObZcz+fl/jaJIo8cHxCVuOOLS2LfFbaG61hvKxfM+YFR8TTX3pD36RCVkmrqUha7HxHk/g= X-Received: by 2002:a05:6870:e905:b0:19a:2178:ee94 with SMTP id l5-20020a056870e90500b0019a2178ee94mr9499419oan.26.1686669997691; Tue, 13 Jun 2023 08:26:37 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jeff Xu Date: Tue, 13 Jun 2023 08:26:26 -0700 Message-ID: Subject: Re: inconsistence in mprotect_fixup mlock_fixup madvise_update_vma To: linux-mm@kvack.org, linux-hardening@vger.kernel.org, Liam.Howlett@oracle.com, peterx@redhat.com, zhangpeng.00@bytedance.com, akpm@linux-foundation.org, koct9i@gmail.com, david@redhat.com, ak@linux.intel.com, hughd@google.com, emunson@akamai.com, rppt@linux.ibm.com, aarcange@redhat.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2563C160016 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: mgdywbxjn3sgojx4xgydifyapbghhbth X-HE-Tag: 1686669998-591504 X-HE-Meta: U2FsdGVkX1/KXq5FP9ew909Q223Cd488MDhHUu0llAjkxQfW2v6/H0gzVdd3uPP57rFYQN4svGbBRbXBxOTxnI9I6TwqWvwBddeQpDmYyml5NbkKk11x27EWv0t/+7GCg4d2Nm92tiCn8rJe503Rl/gcyAL0/igN8GYON2c2todvZA6/lBfCF7C6VK4sQxA4w5yx6UNvyLXGQytwKcxec0xMo3kvF6hyjRvrjtzGUjnvGO0Elo3wcbZYrMLrXMR+MAkpxsRMJdYvQGkdA81cjIyEPwmHu6DTzacqz6fkGNQ4z4lecXBwldzqOx9c3iblpuE1ALN6P+LcO6sLN7fHq2XzDcYc3rMsNM5zH6BElRTQopLToKrIbS7mvSMerl9PLmKrHMQaY75BsxacPiQJ9QQ6SJHEATagdkZaDASbWHGtcsyRmX2ujWzYrpgJHaYaEHYRU97D+K+CVVyeI5rDLZrfgUvb7lKOXgTMeg7JEL+Io1YIVTUuUozPEuyJ0CROwO286bWJGfwVRJ02drHfSTekhrcJfN5UNyk4VCgwvIBfXcNTu/VSA+qphrBwxjtdvYYT/U6YChVozkS35xbbFBVkZUqcHI2sbxfQJdiAlum6pHTfCliC6wtFJAoQAkQNREKLj14D2cB5TG9/toOXPEqWTH/3Xv09QS5d4zafbZFBQapuXVvrLlnX+ifezDc4V0tjA1cBYNZ74DsnsmEi7sT8Mq6ZAirpaiiYkVyGp2XkFy/KlsD3Db6q8T80FghC2HjlFTfO+FMYEQ/CAPHSKMkPk4vY3c46TVm4Owf42e7Etuq42AMq9ydpthzlH1a4NeRrAVe/thewiCMUp5n9iL23dhVZYFiil7o1baUGGRMJlLkXhiT+lC7cy11YM1Dbz6aUSRF7XNy7sVD7e410PjDpjC6qv5fgcT0DFHTp7E+PfUIvPXpsFTeF6rGyzw0hjFRZQtelhYZnRCjTrmN ueiVQDG1 gxCI+XoZB9PNv86kA3PuYmx3mx8Oj7FmaEV6R56Icrh1v0VWEOfN5ouHcvJp1JD0jgptV6ew8+dn5rZjJlqVSU5+KClK6PHkwojnRlzzrj6Krwf3YX+UKf06IlawKwX7HkfFnpoDJp5VnC2ZYA5glM86sw4Bhd/89NThDNeiIsTTdVEh0ZIq6uvlegbfQA35debb/rI29Caa6BJ9C+W8i6tsPV6HDQ9w7ySCx+ousTQGmKg0HzD5u6/FrBCpqH3ZGwzArl1ByZH80wZET5y1qCSnwpC0hnUHLqfjot97XZPqfmlA6wUWAq+pgrQJV/LZ36D26QRaXYs84mBVlMbOEO8Rhnw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: + more ppl to the list. On Mon, Jun 12, 2023 at 6:04=E2=80=AFPM Jeff Xu wrote= : > > Hello, > > There seems to be inconsistency in different VMA fixup > implementations, for example: > mlock_fixup will skip VMA that is hugettlb, etc, but those checks do > not exist in mprotect_fixup and madvise_update_vma. Wouldn't this be a > problem? the merge/split skipped by mlock_fixup, might get acted on in > the madvice/mprotect case. > > mlock_fixup currently check for > if (newflags =3D=3D oldflags || (oldflags & VM_SPECIAL) || > is_vm_hugetlb_page(vma) || vma =3D=3D get_gate_vma(current->mm) || > vma_is_dax(vma) || vma_is_secretmem(vma)) > > Should there be a common function to handle VMA merge/split ? > > Best > -Jeff