From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A34FC4706C for ; Sun, 14 Jan 2024 03:49:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8064C6B0082; Sat, 13 Jan 2024 22:49:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B3606B0083; Sat, 13 Jan 2024 22:49:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6529A6B0085; Sat, 13 Jan 2024 22:49:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5341C6B0082 for ; Sat, 13 Jan 2024 22:49:02 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1907B1402E3 for ; Sun, 14 Jan 2024 03:49:02 +0000 (UTC) X-FDA: 81676535724.23.7B579AF Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) by imf12.hostedemail.com (Postfix) with ESMTP id 5185D40003 for ; Sun, 14 Jan 2024 03:48:59 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="Oyv9dH/Q"; spf=pass (imf12.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.47 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705204139; a=rsa-sha256; cv=none; b=gDmFbsGirl0yaS+ANVh7KoKzsPb/MmMSzylAWf/g0y0HjjmfZARWzJH5SVM+mUYeXMe0RI I0u++F6g4wxL7lGRun3IucMbppi8hEP2PuO0kzLxyeoAIMe3ojHguJT3wyZLHanydmisDO vWyqwvRN7sxvwcHN/kTWveATUFlqL4E= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="Oyv9dH/Q"; spf=pass (imf12.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.47 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705204139; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Fi83qxC7DN9Mrs6Lcn/FzkFtPxyAqAamlzctaT7s4iw=; b=XMmT3aEhp2PH8/ZXuwzp1HzodIwHXpnw4rXFmqIwUry7Pe1hZkw+Ef/3etEkwr4tp7xUs+ TJ1xP8uubTSd3i9NY08fsjfap3JiD51QpA/J1LFC+IcuSR0LQZvuPV0gGk2zjeC/pkYgRG G+OghdTjrCQWMJzG3563aICmlYb1XdY= Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-204f50f305cso5009815fac.3 for ; Sat, 13 Jan 2024 19:48:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1705204138; x=1705808938; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Fi83qxC7DN9Mrs6Lcn/FzkFtPxyAqAamlzctaT7s4iw=; b=Oyv9dH/QL2Hbu+G2P0XxMnHHpuRlvzZ0RspsD8+O9eLeenW8wRx61I9FcJPi803g61 DgiuMpk+B7NsMBi18R6r8xqOnKHRjuh0eNdLlaNcHpk6dcM+88OCqeCnhSjcecwlqNhw X8vWADJWdswPgb4HZE7MczJ5ypJ8/r8L4MPok= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705204138; x=1705808938; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fi83qxC7DN9Mrs6Lcn/FzkFtPxyAqAamlzctaT7s4iw=; b=EaBFx+08BrDojFzuiwJUzCfhzhjYnjhZzeTmtwkF4nzPDGGTtFSuZlE85svbWzq0nR VwWcYYnQ9XduXd7Ccgs/UBZ2Jg/aK56Dc7niX7T13Q/a5OLgvJ5Gj84hZhwSP4fmSKtd KDWg+lkzMm7JOHLWf3lGU1silWVvkp/vLUMGDFTLabcSfssx/o02QN54TtHK1QZSPeH4 u5zpQN1nb/Cv/ZhQDK/Wbtv9F1QRh3Yp7FwezwZUeDFxLdp1ODwOrGBvzRoJImMBPKdJ fq4UD3pImvs9DY9Kj9Sg3lmWh6lTY9gGGPpyfQ/zWfakFqGQAVh00awUyUBG6K+I2OD3 8FSg== X-Gm-Message-State: AOJu0Yz6x1DhfvDwY/JQgTRd2rUJIDHW7la9d8lERin6kvvzPKxi+USj b2ZsmuKPzwP8K/b7GYMZFJO8QnL5N2hEJFY+53YLA/ZRV6ob X-Google-Smtp-Source: AGHT+IGxcLy79rvnuOyBki0wllFskUd2ajI6nO0d3k/tEM6ToEF/16NmjnxfE/jV0LwfK2aFzd7ESKdMigeTSVY4LKk= X-Received: by 2002:a05:6870:5cca:b0:202:ffc8:c6bb with SMTP id et10-20020a0568705cca00b00202ffc8c6bbmr5841416oab.4.1705204138403; Sat, 13 Jan 2024 19:48:58 -0800 (PST) MIME-Version: 1.0 References: <20240111234142.2944934-1-jeffxu@chromium.org> <20240111234142.2944934-3-jeffxu@chromium.org> <202401131146.F017DB5870@keescook> In-Reply-To: <202401131146.F017DB5870@keescook> From: Jeff Xu Date: Sat, 13 Jan 2024 19:48:46 -0800 Message-ID: Subject: Re: [PATCH v6 2/4] mseal: add mseal syscall To: Kees Cook Cc: rdunlap@infradead.org, akpm@linux-foundation.org, jannh@google.com, sroettger@google.com, willy@infradead.org, gregkh@linuxfoundation.org, torvalds@linux-foundation.org, usama.anjum@collabora.com, jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com, linux-hardening@vger.kernel.org, deraadt@openbsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5185D40003 X-Stat-Signature: dipf67o4dbd4b51ry8kjdyxgazazmwxb X-Rspam-User: X-HE-Tag: 1705204139-643206 X-HE-Meta: U2FsdGVkX1/KGVoUGvgSxU1eI/VP5r8AlKSa3++uSlbGsyrDwDCGM2v/qwWewWn+0Io1ORjxya5zFYZozR+ZmvI/q7MPR6RBpSBpvide9EGbvQD8+YWWEEh9g+b36EcMzL7u/mufKPEkAOM4FbDUDSav4pUPU5idQoxxJo+kJd/OUoDPWmcK0sBfpMB33n8bjcfsJMLs3mk8RbgWXjMAO1QfkASUxmpaOWAMHUjvsIu0PQtXczQSYrnVaR17jXIkUY83ycpKxqEj53CZ5tYtIDIisJnERBC5c2fuSIoDu0tvjs46Wi8un+yfeJIfnyVFYk84imnKSN1kjgH2ky7JBcU5CnIbIIgr6RSf9MxpkJISM45xlKiAbCtvohTXu9kdn/VAhxzGOA63IPV2emFdmHwjfcnZxAekFRcvwMdwG2fzrAVpUJmUhjqROJQ+mkti6A2xzaAKrPR5tyz5WRis1DIKvWbiWT4TfJvubkNVCPc51nGF8KGQaiVQN5zkO3neSf6WBbHDyV0R+i76kwZxthzhYOFp335FMUnC0AvM2pdh2jL1JI4YVwUPMgFASOMVTwQTb7zn2Hipbxx62Ppp7IaAPhmH6vZmiMhWvA3taAK1XsW4agDF6zVsM361L/GmP7xjkrLfP6bZQiQ0dckKHLQ0PZyj6xFcTALMgLzwKYc9JoKKVRgh70s40aQNEls9RLseHdBEKuObEmJqbB9HY9v4Xv2KUvOKvTXkzXlH5u79C4JIiLn9vgCmXzYLhVVyCVpwdmK/487kaZfTX4noKJr6ZUwQBffAedjmmwbGKurGxaVcpUr+cB/ADN2BlJIdLMIiZxvIBByrGD+BLFXsahOoghMfpPu3OpkyyHZpRk7JW149n/Q6L3YwiWP0lownIRDrjaNwX7hB/M72ZESyaCnvCwr9sS1sTDwCa1IeaZfQW3VezSmFzWtPIHgibahKUR8VydU084fo4TopmoY VPIJQ5h5 37b90KASYmS5Ag4DWjU0gSu6pq+9s0dN/VABAH5OTW3P1qJQRspFKFuvWXkrF1t613DMlkr+smxAkutOAnT26YKJEJZt+puZrHv5e0XSNZOK3iYG2I+6AwD1vCkdGw3YZd/DYgxTgkyj8n23/hRigdg3ITH0A1zb1XcPymuOpAupOLKCZxXpPNEWhMhKM+50L9MUdCZRImW7VdZIlNylu5e8X2Z3I/Pln47ZfGAFaSs7x3BaY+a9uW3dA45+D87yIp8Xnzkx75znc67ZF0RhSW8/FJI3xNnlgWBf8iUX+t+W8/dXVUCnqJhOiE+UVs+1UnqUi0ZVe6BGnFzXMowsbGCFCCCcRc8IPj6laTWEmrOc6ry5mQeo4e8wbSf0WuRxd+5AIJBz1eTfaXmI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jan 13, 2024 at 11:48=E2=80=AFAM Kees Cook = wrote: > > On Thu, Jan 11, 2024 at 11:41:39PM +0000, jeffxu@chromium.org wrote: > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index f5a97dec5169..345667583b03 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -30,6 +30,7 @@ > > #include > > #include > > #include > > +#include > > I think the arm64 build failure is from this include -- it's happening > too early and some of the arm defines aren't available yet? > good point, I will try fixing it. Thanks! -Jeff > -Kees > > -- > Kees Cook