Re: [PATCH v1 1/1] /proc/pid/smaps: add mseal info for vma

[Jeff Xu <jeffxu@chromium.org>]

On Fri, Jun 14, 2024 at 11:43 AM Jann Horn <jannh@google.com> wrote:
>
> Hi!
>
> On Fri, Jun 14, 2024 at 8:24 PM <jeffxu@chromium.org> wrote:
> > Add sp in /proc/pid/smaps to indicate vma is sealed
> >
> > Signed-off-by: Jeff Xu <jeffxu@chromium.org>
> > ---
> >  Documentation/filesystems/proc.rst | 1 +
> >  fs/proc/task_mmu.c                 | 3 +++
> >  include/linux/mm.h                 | 5 +++++
> >  mm/internal.h                      | 5 -----
> >  4 files changed, 9 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
> > index 7c3a565ffbef..400217a1589c 100644
> > --- a/Documentation/filesystems/proc.rst
> > +++ b/Documentation/filesystems/proc.rst
> > @@ -571,6 +571,7 @@ encoded manner. The codes are the following:
> >      um    userfaultfd missing tracking
> >      uw    userfaultfd wr-protect tracking
> >      ss    shadow stack page
> > +    sp    sealed page
>
> Nit: Why "page"? The sealing is a property of the VMA, not of the
> pages mapped into it. Maybe "sealed area" and an abbreviation like
> "sl" would make sense?
>
ok. Maybe just sealed for short:

sl  "sealed"

Thanks
-Jeff