From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21633C4345F for ; Thu, 2 May 2024 22:39:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 307E26B007B; Thu, 2 May 2024 18:39:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B4B26B0082; Thu, 2 May 2024 18:39:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 109C86B0083; Thu, 2 May 2024 18:39:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CD4E16B007B for ; Thu, 2 May 2024 18:39:30 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3108E1C1628 for ; Thu, 2 May 2024 22:39:30 +0000 (UTC) X-FDA: 82074923700.12.236055F Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) by imf01.hostedemail.com (Postfix) with ESMTP id 5C1FE40005 for ; Thu, 2 May 2024 22:39:28 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Xxrs2emy; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf01.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.210.41 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714689568; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qfrJLkNktZfuMB+SoJQ7DumtzHrpuMfMLiSMpOw3O3Y=; b=BMbZ1y9silxoPerFJLBtpmHbW5LEj4xsjBNIfwnq036nXBjyNZlpTpF43ku2fr28WKyS1V kZm3Bmm6+QlzPSxXsFwxiu6lcxUJhHNo9hg0TPT4nJJmm6MAJSvk+PDDayBPloGQstmQAJ Wi77NvoI0Bhh3/o9G8jG4x1+RusfM20= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714689568; a=rsa-sha256; cv=none; b=2vB3DxHYZFLbDkEkwwCIkZajFr3xsTFvhCI25yJY2zAzkISY+x7ZtMAp8lDPZf390uBl9K JZ73hGr8J6IRBzluwbBq4LgoNOpDrprOtbsYBELOYeEecr13lP0xRNywAU5Cu2AvZEmEYH 7fxCeq77vfELGbIemwj1a0SAjbAKt78= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Xxrs2emy; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf01.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.210.41 as permitted sender) smtp.mailfrom=jeffxu@chromium.org Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-6ef88ce8701so1755736a34.2 for ; Thu, 02 May 2024 15:39:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714689567; x=1715294367; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qfrJLkNktZfuMB+SoJQ7DumtzHrpuMfMLiSMpOw3O3Y=; b=Xxrs2emyoT7TvjzICCbirF+gbueD8qk4minhNDaVFFTBmIETCBRN/8O72dHLEc9AAp oE/NmV8CkIm73Xka/BgWl4g5Z/gsJVg2Q5OEryTWDyCvKHlPBwoiMvniIUvNod8HX9LQ vHXChehig3kIzghXFqE36I+gPSBMxUpHoqPj0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714689567; x=1715294367; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qfrJLkNktZfuMB+SoJQ7DumtzHrpuMfMLiSMpOw3O3Y=; b=GnTBumUnLf+TuhjPuaSM9oSvqnXhnzfOWcL3HJDtazaQlVjL7pwYJLfWBuX2sS2Atb lFzy05yoWkk+5d3zt0MVD9b4xveVETtffmTsLcMYw1Xozi8URl24/62XCtJotymQbOXo vnbCDhDNdyWw7UEsgGKEZ84Ll73pTlMuhMMd2EHpxHXAf2xjeXExicLBfuqWfj0uIwLe wJsZaKErqc+N3S51E+ky6wj4qXkwKe8wPKPTnFw2s+AjqseHm37VEuyxOdjgmbLLnND1 2Wr5+L1kb21rK3K/Hs3bt8Bxc875E9hIncP/RXxqvM0bOLvek3k0ESeUpNOY2AbDEdP1 +BIA== X-Forwarded-Encrypted: i=1; AJvYcCWzBF6awBoI3TZCwnCcoQl9uZ9EpKCXYXAI9jbGUD9GlQb94w2fzsCke0X5L31fyN+97h6iAnNCvwBVnMED4Dcy5zE= X-Gm-Message-State: AOJu0Yy95XkvQOC/y+KSGBCWgGJYMFER0ld0V6tewR/4iei6uRaVAbA5 glXfmisCG4IYU1+MA60f19ktsDq8DwVJq4rUXFTDFV6nqP5XhnQK1AvhJjIT2UlvUrIrsS3DF+S CNKvBziizGMZGf2pt2pZgg2K1xfqLGayRrICE X-Google-Smtp-Source: AGHT+IHVn2dULm2YcxryFkg3yP+dujD1r9smiX0/7F5nF1Oe1nfBMPF+wKK2fs/ZwboCl3pUBrUnaTcaSpGYjnGam7o= X-Received: by 2002:a05:6870:911e:b0:23c:a6f8:9362 with SMTP id o30-20020a056870911e00b0023ca6f89362mr1552432oae.13.1714689567324; Thu, 02 May 2024 15:39:27 -0700 (PDT) MIME-Version: 1.0 References: <20240415163527.626541-1-jeffxu@chromium.org> <20240415163527.626541-4-jeffxu@chromium.org> In-Reply-To: From: Jeff Xu Date: Thu, 2 May 2024 15:39:15 -0700 Message-ID: Subject: Re: [PATCH v10 3/5] selftest mm/mseal memory sealing To: Ryan Roberts Cc: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, sroettger@google.com, willy@infradead.org, gregkh@linuxfoundation.org, torvalds@linux-foundation.org, usama.anjum@collabora.com, corbet@lwn.net, Liam.Howlett@oracle.com, surenb@google.com, merimus@google.com, rdunlap@infradead.org, jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com, linux-hardening@vger.kernel.org, deraadt@openbsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5C1FE40005 X-Stat-Signature: uw1sscdbr8mp7hmuxixmao8n9csy48mt X-Rspam-User: X-HE-Tag: 1714689568-443823 X-HE-Meta: U2FsdGVkX1/05jMjydtbyNmDjx2sidcqgFv4OtZp/AZPP97RSvJMTCvlOvHwalxATN0zAFWZzwRtSA6Lq83RqlHgAZ+ETcmNawisJLULKX4+QYOu4GglhvvmE82kIs1x7iskPdJNV0loI/Q6oOauOGJ59/XqgnWW2A4u37LTyNLoZM/27cvJBJevMx/P0KvN+vkBLbOzQjcjbqhRm4sDzAVmOycgCaAi/+/vbxm0Ea3HnM0V61kwDWM2a4WF/ripVgiFAPuMah6Z0p3n8iF9jNtxXw1/cUisfXm1+iUTzv+2whxL9o8UPJ1YTZ7amo5cmNCRqNLoZRA5/ITgK5mjztCPlfVCdbImX34KSdxQytlGWmTC6Ss/lwaVp1wX19kXLVhXUYHOjVLlBu3Aq+X59IWwoXpn8TlDzdKg4mZpO+p4x+aqAQV13wo1bi3lS8pM3uZ74/l02/IwDTYzsEJlMkz+2qooA/vIMNHUpnDozSKsg1jie4F4jkaGFUkxOtqJ2UrZlE7x49yzJva1yQcgGgXOnHbE0+pj6xwr5gm00Z5wA5XxTxMAS/mcgYJYz0J1hhfX74fVrPuyJGnMzSWavIjpXC+5+Ex0JXqDlqUu8AHaP+dvXFQNO3t2Eo0eywREGmGNANmhAL+54bcjBDdM2d5q3MprF90mnyMRu0alQeLoFb2Su7xc2iHhaccu/byhs6aQg1WDUDU5/KdenXCN22NZm+wnJPRi0v0bjcpBEwy+9R7zyHd9eTJ57kRW/dP1paJTecPuF72d7hOePDRMJZ8IHiRHNiyzSNBdQO3I1+SZOO2DXu5Xiuh5gBSqzCvgyO/91bQhAEXVOoMMDaLAtFDEeMO16zANfsM9Kb5MnTECkeWyq4DwtIOMxuOKjXCDPoWZOQi+j68Kt57JquKflVEIlhNYpp4bJbZwQCkNszJyuy8sFdXOwKq1uxbjE/hz0KWjMHBt7mrZVQ+wu5n g0aZ9Sun u/B81QM0aTTRIRR9cC0oRflA1R/3wtggCpxzI3khSjREbkhKw4Wp+nRWq8uZwQh8LtWSPmE/sl2pvI2TyL0HI97AVarvhSqnemW4RyhWMLoFKMlifF4Eg3mhdPHJFGSm0b3AmCI+MUBhVMI7qhyalbyguXo5OtI6FS66stRjIyluM94/voV3Knj4vUWFyOBc8yas0xzLYieHvTgSPqINck+kBRIWuOPUDtklotkT3GUwILYoR8801Ifumrg6rFwSh4LBNQC6S5zmv4tlhcCHZOKphTYJ45k8nrZq+3ljFLVDSLBElGOhb4UgMlgx22a+7xg3N94x3/DOQNA/APX3Ja4cEfP2PRy2oQfEL0md62JRXDu0KQ0l9lzSWPlEJtZjFKwpA+T8tiXvAZBhx2/2du32a7R3qNr4vDtD9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 2, 2024 at 4:24=E2=80=AFAM Ryan Roberts = wrote: > > On 15/04/2024 17:35, jeffxu@chromium.org wrote: > > From: Jeff Xu > > > > selftest for memory sealing change in mmap() and mseal(). > > > > Signed-off-by: Jeff Xu > > --- > > tools/testing/selftests/mm/.gitignore | 1 + > > tools/testing/selftests/mm/Makefile | 1 + > > tools/testing/selftests/mm/mseal_test.c | 1836 +++++++++++++++++++++++ > > 3 files changed, 1838 insertions(+) > > create mode 100644 tools/testing/selftests/mm/mseal_test.c > > > > diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/self= tests/mm/.gitignore > > index d26e962f2ac4..98eaa4590f11 100644 > > --- a/tools/testing/selftests/mm/.gitignore > > +++ b/tools/testing/selftests/mm/.gitignore > > @@ -47,3 +47,4 @@ mkdirty > > va_high_addr_switch > > hugetlb_fault_after_madv > > hugetlb_madv_vs_map > > +mseal_test > > diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selfte= sts/mm/Makefile > > index eb5f39a2668b..95d10fe1b3c1 100644 > > --- a/tools/testing/selftests/mm/Makefile > > +++ b/tools/testing/selftests/mm/Makefile > > @@ -59,6 +59,7 @@ TEST_GEN_FILES +=3D mlock2-tests > > TEST_GEN_FILES +=3D mrelease_test > > TEST_GEN_FILES +=3D mremap_dontunmap > > TEST_GEN_FILES +=3D mremap_test > > +TEST_GEN_FILES +=3D mseal_test > > TEST_GEN_FILES +=3D on-fault-limit > > TEST_GEN_FILES +=3D pagemap_ioctl > > TEST_GEN_FILES +=3D thuge-gen > > diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/se= lftests/mm/mseal_test.c > > new file mode 100644 > > index 000000000000..06c780d1d8e5 > > --- /dev/null > > +++ b/tools/testing/selftests/mm/mseal_test.c > > @@ -0,0 +1,1836 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +#define _GNU_SOURCE > > +#include > > I'm afraid this is causing a build error on our CI, and as a result we ar= e not > running any mm selftests currently. > > The error is here: > > CC mseal_test > mseal_test.c: In function =E2=80=98test_seal_mremap_move_dontunmap=E2=80= =99: > mseal_test.c:1469:50: error: =E2=80=98MREMAP_DONTUNMAP=E2=80=99 undeclare= d (first use in this > function) > 1469 | ret2 =3D mremap(ptr, size, size, MREMAP_MAYMOVE | MREMAP_DONTUNM= AP, 0); > | ^~~~~~~~~~~~~~~~ > mseal_test.c:1469:50: note: each undeclared identifier is reported only o= nce for > each function it appears in > mseal_test.c: In function =E2=80=98test_seal_mremap_move_dontunmap_anyadd= r=E2=80=99: > mseal_test.c:1501:50: error: =E2=80=98MREMAP_DONTUNMAP=E2=80=99 undeclare= d (first use in this > function) > 1501 | ret2 =3D mremap(ptr, size, size, MREMAP_MAYMOVE | MREMAP_DONTUNM= AP, > | ^~~~~~~~~~~~~~~~ > > > And I think the reason is due to our CI's toolchain's sys/mman.h not incl= uding > linux/mman.h where MREMAP_DONTUNMAP is defined. > > I think the fix is to explicitly #include , as a number of = other > mm selftests do. > When I tried to build with aarch64-linux-gnu-gcc, this passed. aarch64-linux-gnu-gcc -I ../../../../usr/include -DDEBUG -O3 -DDEBUG -O3 mseal_test.c -o mseal_test -lm -Wall I don't have the exact environment to repro the issue and verify the fix. I will send a patch with the linux/mman.h. I will probably need some help to verify the fix on arm build, Ryan, could you help with this ? Thanks -Jeff