From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0976EE7717F for ; Fri, 13 Dec 2024 15:05:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 683036B0083; Fri, 13 Dec 2024 10:05:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 633086B0085; Fri, 13 Dec 2024 10:05:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D33A6B0088; Fri, 13 Dec 2024 10:05:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 29E9A6B0083 for ; Fri, 13 Dec 2024 10:05:22 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A988C809B5 for ; Fri, 13 Dec 2024 15:05:21 +0000 (UTC) X-FDA: 82890258738.11.BCFB1A4 Received: from mail-oo1-f45.google.com (mail-oo1-f45.google.com [209.85.161.45]) by imf11.hostedemail.com (Postfix) with ESMTP id 1BE254002C for ; Fri, 13 Dec 2024 15:04:55 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=TW+VUWVF; spf=pass (imf11.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.161.45 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734102292; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UK1Wn/2TaTQiTjolBHB4TPR3OYstJinGPMBetUH/Dj4=; b=hAFqnfRUVxJsx4WYrwxCjHx5pVgR6L6D8/MDmT1D3RPp1iYpEalKEsfqxV6aEb1DEHgJmX BL7SlwfBecLNNvwC8B0svEyDwJ7qvQA3DKGOmir7bQHYmqDlKszUiZ59Ar0u8y0SNMtG1n E2jOCLomGYf53pWrUGiYvM+oAntMHis= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=TW+VUWVF; spf=pass (imf11.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.161.45 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734102292; a=rsa-sha256; cv=none; b=zQarHhWA+nzPaObu2ZIqFn+8TgGZALPGPlIYknOVcPNV+TVrXuA2irb3QvD/5vZv3s8v2K W9g4GYpA/lYxyrMQRFDfm9Q7ZD1DdxvV5rOEyI+YkTGR1txXyYOOznNiZi2/ZmgLPuRftz bVXwfb+SJ3DqY5ryRgGMhAQScvCY2Bk= Received: by mail-oo1-f45.google.com with SMTP id 006d021491bc7-5f2d8e590e2so78262eaf.3 for ; Fri, 13 Dec 2024 07:05:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1734102318; x=1734707118; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UK1Wn/2TaTQiTjolBHB4TPR3OYstJinGPMBetUH/Dj4=; b=TW+VUWVFdbCGqgxEAs/a82LEDaJQ17ujjXb8g4U4EKanTPYXSQWIhFgATTd1tEYZa7 D0gNXkpUzgZZJl3SRm8jqfPBy5j5R2IRgMqIYNCOKNrrL2IhC9Hb1tOTYXfOZdgTmIKq COLWJg1LgW6rtZx+YD0k+hF0fKg8s6/HQhbL0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734102318; x=1734707118; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UK1Wn/2TaTQiTjolBHB4TPR3OYstJinGPMBetUH/Dj4=; b=phu/FOEIIVlq72zDNA31qMjxOkm7Xm0s545qTzDQMAGMm3nKbT2cNg9csTPDflIbA1 cQVvB5e2d3PnanbjtVm+yR9mwvf696UWIVEan8bRjGQGb0Km0VM0h/CHmyVeDoD0CVzX gYrRlmtFzbuAT5LJey2Jfo+LuoBE2WbtT8lTQys9Y+EQbpmalWUGc9RcG0gNAYL2kFLf 7uB1JeR5nRYLwFttbyCakTk/ZLgAECxiKZmdtMOo85OFYcB/oLZPWUUNrTdXmycXhXQm CnEwUK9JvV5OMdOgJRukLtj+ASaICWBMlxxP5ARQdVXPc9P44xOXEpqd+7+zFunpNOHH +2NQ== X-Forwarded-Encrypted: i=1; AJvYcCWrsCs9RGrdr5Qg0bl1wu509UCZ8uoam35l8QNwNkCQl585apbB/tkdLCABPQUcjkB+dPmX0ofjdg==@kvack.org X-Gm-Message-State: AOJu0Yys468l+makBGon1PY8HPxYvEvWTczkof5GRqGtAUnxvMawx8Cw dMdBMUkk3OtSJ3KMDnqqmVjP2Z8oQHSz/u/sdPKrG+gEhWZniQhYSR6GvezGHuyJvZQq81+Bjm0 BkKzuVvBUk8bDb+jQcoEPGDteY+i+s1/ooOjB X-Gm-Gg: ASbGncsceIMAW5e7foCXt9AvpaqAjNDpVl+oooaLgws4GldjSjR8rVyFfgkE143mBgR 5Zvkh/omJG3rEM5lt5tNl0qTfA8Rksru/8ZH52zA55zfaCcS0VD2sAeT1Taij34pRP6h+75A= X-Google-Smtp-Source: AGHT+IEVaDSbGLsumhW9zXC/ZGG4dC4b8hhxKUeGWallISgNNzKOFa2dE5kEKicyUo55GFO/OF4gSokCqcgH4hZRJVc= X-Received: by 2002:a05:6871:5209:b0:29e:5525:f4fd with SMTP id 586e51a60fabf-2a3ac9824c5mr578830fac.14.1734102318525; Fri, 13 Dec 2024 07:05:18 -0800 (PST) MIME-Version: 1.0 References: <20241211105315.21756-1-lorenzo.stoakes@oracle.com> In-Reply-To: From: Jeff Xu Date: Fri, 13 Dec 2024 07:05:06 -0800 Message-ID: Subject: Re: [PATCH] MAINTAINERS: update MEMORY MAPPING section To: Lorenzo Stoakes Cc: Yu Zhao , Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1BE254002C X-Rspam-User: X-Stat-Signature: mf4a46ibkh4mxfwp1ourhw3hwmnmejh6 X-HE-Tag: 1734102295-457609 X-HE-Meta: U2FsdGVkX1+R+KLsmF2LEUPd1nFH1joEkIZ60Ps8fQ9yGVG+gkyNuiLho0x3JBePTuiWRFEPy0lm6B0u5VxQesRDJ/XqAob5J87lDgmTWBJb5bocB6DOl5iotnBEFuM7ycApqkvUgFcHpDnvzDhowimkQ+NKEQHRgcUeFdN9ITu9D2EzlDO901/VWRYij9Nt7iTFfpoDb4Zwh999pXiyTQQEDB2puBT8m6wft2wyhQg+hVk6Oi85lwh3U5Of18888r4V93kbhLNjfiuGHfIaH87wk+sIYDHqNf4qDqVPqHcWu2U5YWAoLJMttsmPagoHcKFFpblkyIGsVaxEYQfdQv/e/7v3YW8R44xN9u2WRNbGDd4JO3uBZ3KJkxdDgDoigCnBcWtq1kQRcvqHOb0Ml8dTR8rpR0sLD3sTijiRFv8G9XSozA1YipmiYHKd4FlJoUp8gsnZaiFYJehr3DjZmicY28Dja0jRAaCYAahA5hamYGMqm5l44V5YazMH56KGzDs9GHfmwD/8/gJuiyKm7eDIHXZboYN0X3EcHxGJQJEcNxggchm24KPecTS+TXUsL91N+dnysl1gzKes3A5FcV6EVfGv3htGrz7PirUF4B877MLithaNYyLBP/hbib4eR7SudZJJ/DuBl9NM8BS5HQ+R+Nd2DlAGAcdz+PID4XVMtASm/jj3hH8yscyIpA5OLkzvU+h+d0lCLPMefQG6exo6qTAGzYmhCfc3tSP6s6T7KGgES3AcsOCArn/1/Z9bGebfWZ6mPZA5ThGH8cK25h7L+QtGyyKdSbi4ukrym8SQHkhnGtL65xMuRSD4Z36YVC3ISy+hHT/XJ4AE8zvl9PTU3T4Twq2t1vjqic7zYs4TkJLhWg8ofsJueTjmsXsh/ABZjCBqz0prkNxk/H9NLbmTav7KXCO0R41RRXS/dyB36EPnldUE8apky4EbHrMi/z27wDpDSvvzhdnn30e li4E0Dup 5jZb3C/wor3b+St/x4BZp+EvUWDH4QPnwc494ho+NlKEKWCKqap0mZ8ugfgg2ryKsX7nWSktBmJe6pknM6AJ7A633k/s4dfXIYstCe56qQkH/t6KtCunr/qcgNI9Cgl63KS/mfeboHvx/NIqs7IRs9wNVa1l3GB+mcjZ2dkJqHqR+ckrtzlhMvQ2lOvBcMg4HZAgQR/g3ahM5gLRBTr4ALgkxcLCssfQQW0xXsfh8AWHf9931a1TDk54Kzc74EHT3qslxP9Gz4lN3Ox9RXw/WMUJo+jGPulcG4pRVkjNZQ3TK6DquLz1QhgDY6rKswB4+Vzt90YdCn8JyNH5uFkiksq9QJlHH+jUxWX+f946QjJ3V6nztXkwUYc9rwx8SQGx90H2j X-Bogosity: Ham, tests=bogofilter, spamicity=0.011661, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Lorenzo On Fri, Dec 13, 2024 at 1:18=E2=80=AFAM Lorenzo Stoakes wrote: > > On Thu, Dec 12, 2024 at 10:50:19PM -0700, Yu Zhao wrote: > > On Wed, Dec 11, 2024 at 11:57=E2=80=AFAM Lorenzo Stoakes > > wrote: > > > > > > On Wed, Dec 11, 2024 at 10:36:42AM -0800, Jeff Xu wrote: > > > > On Wed, Dec 11, 2024 at 2:53=E2=80=AFAM Lorenzo Stoakes > > > > wrote: > > > > > > > > > > Update the MEMORY MAPPING section to contain VMA logic as it make= s no > > > > > sense to have these two sections separate. > > > > > > > > > > Additionally, add files which permit changes to the attributes an= d/or > > > > > ranges spanned by memory mappings, in essence anything which migh= t alter > > > > > the output of /proc/$pid/[s]maps. > > > > > > > > > > This is necessarily fuzzy, as there is not quite as good separati= on of > > > > > concerns as we would ideally like in the kernel. However each of = these > > > > > files interacts with the VMA and memory mapping logic in such a w= ay as to > > > > > be inseparatable from it, and it is important that they are maint= ained in > > > > > conjunction with it. > > > > > > > > > > Signed-off-by: Lorenzo Stoakes > > > > > --- > > > > > MAINTAINERS | 23 ++++++++--------------- > > > > > 1 file changed, 8 insertions(+), 15 deletions(-) > > > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > > index 68d825a4c69c..fb91389addd7 100644 > > > > > --- a/MAINTAINERS > > > > > +++ b/MAINTAINERS > > > > > @@ -15071,7 +15071,15 @@ L: linux-mm@kvack.org > > > > > S: Maintained > > > > > W: http://www.linux-mm.org > > > > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm > > > > > +F: mm/mlock.c > > > > > F: mm/mmap.c > > > > > +F: mm/mprotect.c > > > > > +F: mm/mremap.c > > > > > +F: mm/mseal.c > > > > > +F: mm/vma.c > > > > > +F: mm/vma.h > > > > > +F: mm/vma_internal.h > > > > > +F: tools/testing/vma/ > > > > > > > > > Will madvise be here too ? > > > > > > No. We had a long discussion about this on another version of this pa= tch :) > > > it's blurry lines but it, in the end, is too much related to things o= ther > > > than VMA logic. > > > > > > We probably need better separation of stuff, but that's another thing= ... > > > > > > > I'd like to be added as a reviewer on mm/mseal.c. Is there any way= to > > > > indicate this from this file ? > > > > > > This is something we can consider in the future, sure. > > > > What'd be the downsides of having an additional reviewer? Especially > > the one who wrote the code... > > > > > However at this time you have had really significant issues in engagi= ng > > > with the community on a regular basis > > > > I'm not aware that this can disqualify anyone from being a reviewer of > > a specific file. > > > > > so I think the community is unlikely > > > to be open to this until you have improved in this area. > > > > I do not know Jeff personally, but I think the community should make > > anyone who wants to contribute feel welcome. > > This is very unfair. > > I have personally spent several hours doing my best to try to provide > advice and review strictly to help Jeff get series into the kernel, perha= ps > more than anybody else. > Thanks for your help (and others ) on reviewing mseal_test.c. For the reference: I sent RFC [1] to follow up on refactor work of selftest. To save your review time, I made minimal changes using two test cases, and intended as a baseline/pattern for remaining refactoring work for mseal_test.c. If you have time to give your comments about the RFC before the holiday break, great! I can start refactoring the other mseal_test. Otherwise, the after-holiday will be fine too. [1] https://lore.kernel.org/all/20241211053311.245636-1-jeffxu@google.com/ Best regards, -Jeff