From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A60E7C021BB for ; Wed, 26 Feb 2025 00:12:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25586280003; Tue, 25 Feb 2025 19:12:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 20639280002; Tue, 25 Feb 2025 19:12:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CE87280003; Tue, 25 Feb 2025 19:12:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E1F87280002 for ; Tue, 25 Feb 2025 19:12:54 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9F2F21C7A85 for ; Wed, 26 Feb 2025 00:12:54 +0000 (UTC) X-FDA: 83160170268.07.7F9681B Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by imf04.hostedemail.com (Postfix) with ESMTP id BD61A4000A for ; Wed, 26 Feb 2025 00:12:52 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=DQ5eBliD; spf=pass (imf04.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.210.43 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740528772; a=rsa-sha256; cv=none; b=oxCdoN3VOJw8RL4ZeedA9+T/TwW5cdNOYIVtqO59RAe6JKa6jsjnBpAIyvfv/VZPOOwG5Z bFyJTDG6lhlbZNodmHrf1Q6LpB3srZtjtT5EGUTWmQBb90Lw6yWc7bV/Gb+eZ3RJfa8JC7 YnpTrbPQPm//EM9mlMYLSaSL+AwySE4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=DQ5eBliD; spf=pass (imf04.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.210.43 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740528772; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9JZComv1EUu/8PE1y3nNgwwcXn6vNcbsWZABFHGDthE=; b=e5Q3VgyPA8RYX0Nf4mVLvQoOXSK4lUWs2BQaLrfhWLzRQ1gxs3hr1LSSRTLAuashIZ1kFx LIilO1hMpNaPIQKTnI3A+29d80PpmJ+tP0tIpFhCPqTqDnk9VcIG6NsyF1Ty3sID4yMas2 X6oF1V5Y8xlK6d1H/j4IrxJmyh+WlME= Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-728a2736e7aso121951a34.1 for ; Tue, 25 Feb 2025 16:12:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1740528772; x=1741133572; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9JZComv1EUu/8PE1y3nNgwwcXn6vNcbsWZABFHGDthE=; b=DQ5eBliDGsN9T4icNVhPNCGMz4MgbyB98/ObQfuKXYlzLY5JkUgzrYHkajprEVe33b wjgixlJPWEkUOawXgbDQePLMRl1kWBq+ohvJiurWSmcVSSP6YKL8nym02+SonTnMTf+Y cONu2YVPN1AitshKq9by3AKBeTGvkt5SnGYkg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740528772; x=1741133572; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9JZComv1EUu/8PE1y3nNgwwcXn6vNcbsWZABFHGDthE=; b=ChMFD5MrNi54sRMGoHfZPp4vFTB0339FllI/0iNYokvcdqQ+hdyrIjn3MTLKQEwAov Gtxekx3xKzpqddk50WGmRAAVNH9JYxNaZn8Wsvmjkds/f2BsrBPWAo26dikqiFaGDznt CRw0LRi5loW4momUxH7CUWJyrvI8QEtJiOJnr5CvflyOlVWSU5SR0Ibm2PVKHheFS9p/ xzyr43tLJV9LTgJviHu+Di1doouoo+m0swaea1N3po3yootRxWdWx5LWETFKcv80MpB/ mdZchKPMVsIGogmyY75K5v9S6ypmpbbnS6ffp+lHKjQhQ8c73VNhsabPQHlGAmCkG7Bv RsMg== X-Forwarded-Encrypted: i=1; AJvYcCXDBx3uO0kJwFhXsu0RkW055LdJWifl+0eEmCeKzoJckTz2nVbifYkUZg7plPC4FCXeiGEAw+/fCg==@kvack.org X-Gm-Message-State: AOJu0YwmmOIYuG2eT/QJ0XLsdYYwDfIIrxDSHzw5rlg6MR7C/zCxHAep 2sRESzwvfQ0n/4Un6enuT9PaC+7Mp/w0E5ZYBCBzc3QuH+MLD2r6lCup8Ykatnkj4/1yWisqbmS 8+oV48grqiMb/Oz1xOE53m2vUwl0H6jqXUIuG X-Gm-Gg: ASbGncvLy4npYZISBLlqBaOEJeEHvpQjwWNJF15BQcxjkPq7Q9kRNRKwonjn5p0RGNk lLG7PxzNqN8Z0cwjJ40YiFnhI/23oHTGXmPvoopGNDHIOPhfeTFa4ssVdw8b/xa6qYDdlz5aC34 TRQ4yxUo8HFwJ87XPBo6/zK2U+Fz7KKHq6EoI= X-Google-Smtp-Source: AGHT+IF+DM7ULHyyCq+8FePx8Pwa6mTgdKJT6V5TiujxwSXVaSD2ZmXtPFIg/19c5S3mUSM/bsmFnV+3csWbBw+T4Kc= X-Received: by 2002:a05:6830:908:b0:727:3e60:b447 with SMTP id 46e09a7af769-7274c276e44mr5006873a34.6.1740528771830; Tue, 25 Feb 2025 16:12:51 -0800 (PST) MIME-Version: 1.0 References: <20250224225246.3712295-1-jeffxu@google.com> In-Reply-To: From: Jeff Xu Date: Tue, 25 Feb 2025 16:12:40 -0800 X-Gm-Features: AQ5f1Jo6a5YPljR9jcq3wgj2ygDTzULFozIVCwT6U2UOWgir5EVnc-62Nq5J5mE Message-ID: Subject: To: Lorenzo Stoakes Cc: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, torvalds@linux-foundation.org, vbabka@suse.cz, Liam.Howlett@oracle.com, adhemerval.zanella@linaro.org, oleg@redhat.com, avagin@gmail.com, benjamin@sipsolutions.net, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, sroettger@google.com, hch@lst.de, ojeda@kernel.org, thomas.weissschuh@linutronix.de, adobriyan@gmail.com, johannes@sipsolutions.net, pedro.falcato@gmail.com, hca@linux.ibm.com, willy@infradead.org, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, peterx@redhat.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, mpe@ellerman.id.au, aleksandr.mikhalitsyn@canonical.com, mike.rapoport@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: BD61A4000A X-Stat-Signature: co9hyq9udz7umuwr6kg7cdbgkppq5kg7 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740528772-142060 X-HE-Meta: U2FsdGVkX1+jM8/QRI2D1Eh18rEBZ6N997gT61wdbBFzHYN3Si2Jt42ISFFq3FVzhwjUjj7mFY7CO+PqJRDjAMRDgTyKIeTq6jKQLsGT+P1Uzjc6KaR/MfHkPjNDGWcMv3SsfjpMVy1FDMNQ2vyHNMFhxAi2b8ES3ZNd/bf3M1YNcfJplNYUvF7N+H7+H7zfYPZqL5j3EgEBOcr0oZ9NiH76GSd9Shk2LD2ImUFtu+s2oWvf4kiyQVKtWOpPq6orkmERtzPrcBTNT1G3PlgdA6t67Qy6yVY4XRm6JKCHSdfTmBinQHhrxx9FfLfKwMA6MbVI5AnZKY3wBJ/iw5F+Q22S+goyLooRNJWbNKwACWIpxpMsDvu118HgqGrmz2acRtT5015KI+h7juKqy+rqCfOFIvQ52sXDyJZKN03kQqw6A1TUxBEmm4+YT48yi7dlsxwktK+hfY4a8lavCaKcH0Qgju/8ra5Snxoud8hNxs4sRnDUGZpF5bVjvEt2mXb84jYRKxdwLQrZ2WCA6g+wY76uu8mu23dmyxSx/I75IytkINgrrHoCSwvpTikznz40npgZVUdSv2RjRRbd/OfyXTyV5n2uypVi8ceTEqqRiJo148/ZACuen7kUBloFAgu9qAuyjVIjO7XwSteBcj8uEDD2+0EWc/60gruZMCe8fSRqQJclSqnjwvWjDfS/9E7Q4d0Y/KUB2lcUuIqOAmQ3OUyiETjlO92GB55GgaebkSIeyM+hxrJ6m/n8WIactRrdV64FKsS/pMksz98m2Gai8y/kERLXMJYMoUi/qQbFp5kjcrUixxkSRNv1Svc9iYofbtTb/qOU+Qb0xLlxdD1SB5mB2AG4Wgq1KsaqVIaoZ8T171K9WXAn1C7Uf+HsPhZXJZx0o7945Wl22g16XEhXF8W4g2+S4RMXxrAZ9hVyqKaPLqJu1gtg9zvgbmARllJ6SEdsC2gJEyNLnqv51ZD bd8G62IL nQ6EP/dTP/RfRjnXHWEx03J97Dj63eejlGYAXywbqdwqUDe8A9RQGU9QwhT6ZkKMyMccKZ6Adazmwm3loZyAP2yHrCv7EXMRjPPODGPjf8+Un4UR/uBJvIMarn2PdSOsJRALB+QmnpSWD2TUGnoYtWqfpM1XZEh6iaylr2jK5PJm5u3/3uqilOuHDMYYL4kdw0XvtuahznJDtB432yJPb9KTlCen/KGjoIeIkB4xPgrOVK9sjjBFiJL48wrwLPEnduemkoe3cvfu0f77VzpuPNpukqEIhtq3snTl2b6FevIEwSZ798HrE9row4e+Aa7W33OE7Q9VFrmQdNdO+QbsNe6HwqlrQioWqZ/uyDTtDvUzt7zM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 25, 2025 at 7:18=E2=80=AFAM Lorenzo Stoakes wrote: > > Jeff - looking further in this series, I asked for a couple things for th= is > series which you've not provided: > > 1. Some assurance based on code that the kernel-side code doesn't rely on > VDSO/VVAR etc. mapping. I gave up waiting for this and went and checke= d > myself, it looks fine for arm64, x86-64. But it might have been nice h= ad > you done it :) Apologies if you had and I just missed it. > Thanks for checking this. Do ppc in kernel code unmap/remap vdso ? I am aware that userspace can remap/unmap special mappings, but I don't know if the kernel will remap/unmap a special mapping. Could you please point out the code ? > 2. Tests - could you please add some tests to assert that mremap() fails > for VDSO for instance? You've edited an existing test for VDSO in x86 = to > skip the test should this be enabled, but this is not the same as a se= lf > test. And obviously doesn't cover arm64. > > This should be relatively strightforward right? You already have code > for finding out whether VDSO is msealed, so just use that to see if yo= u > skip, then attempt mremap(), mmap() over etc. + assert it fails. > > Ideally these tests would cover all the cases you've changed. > It is not as easy. The config is disabled by default. And I don't know a way to detect KCONFIG from selftest itself. Without this, I can't reasonably determine the test result.