From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23A98C27C6E for ; Fri, 14 Jun 2024 14:58:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6AE16B00E7; Fri, 14 Jun 2024 10:57:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 835F58D0007; Fri, 14 Jun 2024 10:57:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F412F8D0006; Fri, 14 Jun 2024 10:57:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 202B48D0001 for ; Fri, 14 Jun 2024 10:57:14 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 87D9FA1F80 for ; Fri, 14 Jun 2024 14:57:13 +0000 (UTC) X-FDA: 82229797146.27.4C6B7BB Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) by imf05.hostedemail.com (Postfix) with ESMTP id AA8F8100018 for ; Fri, 14 Jun 2024 14:57:10 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=J8ZP4kAH; spf=pass (imf05.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.48 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718377028; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PDBN7CfZoySclWGICiQXNm0dLSN3WzDrHOHH5KLuTBY=; b=oVY20BkQK9JhN51nOuA3vsqWaHGQVfpNoXS8z2hLntcko1xmeJEQTJRa1Orhlp/EKHQI9r lFfYmcEIXsNzedu7/PGTJkUivghh2P8ov8aFGtGRr9Z4Uyou8vpLbWA6cxd2+y2kKhHTx2 KecMYZdJABcoYFo2cORtNgbCjBNlVRA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718377028; a=rsa-sha256; cv=none; b=lRs1Phdrhdh7DxmmhbNlzqZFoUwZIySVhSZUsulT+opJE87Sro+z/vfY64FGkHIM8H8sKJ OEghKw4//36U+XCT8WgZvK417axHXQJCAL1SkOKli7GINwdqpPl1GAnnP11tLAagvG1KZH SQEG1cxTMvRN0uOHQ7Z+PN/fFQ3GlTw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=J8ZP4kAH; spf=pass (imf05.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.48 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-254e42df409so1288735fac.0 for ; Fri, 14 Jun 2024 07:57:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1718377029; x=1718981829; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PDBN7CfZoySclWGICiQXNm0dLSN3WzDrHOHH5KLuTBY=; b=J8ZP4kAHt+B7m4Vf01g25TwdQ6tVVDSaueGBEu7IEVnLgclJehjKrmdTSDc6ZYxkQ6 v/X5jAngdAnLRmdPBuSFxjLQ1EWf1NSNgYkgG2mKwBOhI+Ph1Sluq1fmB4EgatUQozKy ubQ2i15jez2fnubWCIGrWNrQ5ldEGLN4Q0B5o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718377029; x=1718981829; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PDBN7CfZoySclWGICiQXNm0dLSN3WzDrHOHH5KLuTBY=; b=jcvOsmMf03sH1PA4ZjECiNi7aXGM7vwMHqqUUUtxduqD/5PGeURd6FbbIh2/XP36gO 5B4zBQeGsrS4s2ejl+S89b5aW3LBjD+hIFyIuvKy7lxxxubxV/RYD7ztLw4b17JUkdtG 3WpkP5LHB+v5k6890N+1WtyS2pjooJPiGAwsPwtKAfL5c8mDf5Cc7tttlbPRSOUJxoef AvKCCVafCVBeyXdjoYRwT2Qlr6T0sBcpZGACb34wjsYzAuHJPrQcXphkl+wFyW15hYlp WmL++PAS/zt0I0wiJgMAMWv056+34ioS4NS2gmEpJ+TfIvC1WWG5mR62C7li0zs2mm/p 3J7g== X-Forwarded-Encrypted: i=1; AJvYcCVCB2CConeE2BkSOk1m4aH8pVrs9+DwvmQIFB/Tnm3R0/SsMbeWrie2NPR/qcqdkHP21u225DMAZWQGHtvhwzl5c0M= X-Gm-Message-State: AOJu0YzHCS4k13KQ1lLMvEO5H09CtUMI22XxhzsJp4U7nDYDt9is5xXm rF5fjdIAHof77E+pTmVBUhNUPNkcnwwZuHkDAXOIiASuwybA5T3fktoyBPxgq2psqx+UwRRZn9a PU3prb4zLI978ug+i4fxzVxPgmKkoerZDYCey X-Google-Smtp-Source: AGHT+IEUcAWOw1CVNlN0YcNfMetLlCT81YqYJzny/v8B5VIR1b7mnqvJKLKUWEnEomwJ3Vd4mFsoMMwH5EJv6fYqHso= X-Received: by 2002:a05:6871:72c:b0:24f:c241:4d16 with SMTP id 586e51a60fabf-25842be40f2mr3448708fac.50.1718377029521; Fri, 14 Jun 2024 07:57:09 -0700 (PDT) MIME-Version: 1.0 References: <20240614023009.221547-1-jhubbard@nvidia.com> <20240614023009.221547-3-jhubbard@nvidia.com> <4c6ffb1e-0381-4d5e-afa2-f8809f0b445f@redhat.com> In-Reply-To: <4c6ffb1e-0381-4d5e-afa2-f8809f0b445f@redhat.com> From: Jeff Xu Date: Fri, 14 Jun 2024 07:56:57 -0700 Message-ID: Subject: Re: [PATCH v2 2/6] selftests/mm: mseal, self_elf: factor out test macros and other duplicated items To: David Hildenbrand Cc: John Hubbard , Andrew Morton , Shuah Khan , Andrei Vagin , Axel Rasmussen , Christian Brauner , Kees Cook , Kent Overstreet , "Liam R . Howlett" , Muhammad Usama Anjum , Peter Xu , Rich Felker , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: AA8F8100018 X-Stat-Signature: onah9qbf5uhoif4a4rtz7qwk4a79xyg3 X-HE-Tag: 1718377030-926009 X-HE-Meta: U2FsdGVkX1+gzfYuscnAQE0ZtGbidbmbJceTverWeNP8wbC1fz1r35UCNO1L2hIWSFXH5JJyhuNx4tb+2HuKHKO+S3THT5oCkNihICrsNgK7VQj2eNabWlh9l9TZL4aVfkexb2MUjOYM3n6VXtIuFIHP3beamsDJz5wMp1O00XRiQ4G/WyC0vxzLwNiZke887gIs0gGdbxJ7zU7nn0tiXZZjKUuZcm0bPJreKw0Fddq/1uiv1bFhjQN/oPlAjSb0qFfMcHAhxWtX51/Z/P6NR39J2jnDyhF68EKqRnzEUL5NRRH+gFy03pQEh8JKzmoSU3rI6W10NZF7ggvspAogNXkHPVHI06e6sVb+eO0TQv8zeMhrB2i+VoOiwIp6eVwVLq08WB1Aj62TPqYbpKDQ/0Pu28AalJqzjdgVmZkGiwID0rkuZnRLI/2iBbnMqUODbMm+KOSB+O5Kqi9P7o6RkWikbNZFSYeIIL8PAETNHM7zOZxUHDkCCeK/94qTKMOPtQuIFHLmo7EVu6XowJDmz7cE2T3vo9wrjEvG0WA4amkvsP+8P6o9cwE24/HJQRQMUJQZOKV+x9pHwK4jBbrCbWrzHxKTmqnDYkoR8EoYd6Q56ApI26ji24ycbiRQ5LIuYWEtsDspC0LL0OgmuwwcAbqe+WkcZp5mj4t2zFKC8O75Noa2eT/G01Y4l/R0FY7lRwTbSuB5UGXUgYs9EyVmFnj66GeSaJZBO7yHHlMHCSGNxQC5cBRwmq5XBg6t2/rh9BG049wm2Xq7Fmmkf9EO0D42zF6EObSNwGbZaRcyRcTiT9FiKVtlRC4xepvLNpXwZJeOFitwSniNBmy63Fcw8kH7szz0rKlqSBQe6rYMgvzACuKbsEFVY9iokaCxRwApeS6PXnWWLIEHUANPaTYziqFM5cyLkxe9prPj6Pe19x24PrPnfmEAFoJyk34aaqLSW6aEbxsOt+aVnIHCguJ kFB9AuJM C+3aJHOPXqy386TtW/36ZHghlclQxw72WbHZl0bpvvqYVr1o7l7ItYlFr5eIS13PFnjZYXDTjFrxnuIe9z4P3TnFZC/rlX6hrgK8JtIyEi1F8I/Et+YnOJqdgBxUtvjj6P2OcckWN6EkUL2ze0/o/F8KKepb0vSvVyZjmWP9yd7oNUdo9HbkNNeAPiaAJ1v/9gZszzyG4NiSF2HjPZNd80VQzlo8K2qVv6Kh5jQP2dkWONJw9dHEqsC0qy3ov40PE1N9GiYzSVyVaEqdYfEhn6H6H6IL6MbmaFR6TNwVNT/pGtYf4mJmEDFgd4trk3V6xXV+nYZzqmL3umrtNfKHl9AiJrpCYRM7nHSl0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.011277, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 14, 2024 at 5:28=E2=80=AFAM David Hildenbrand wrote: > > On 14.06.24 04:30, John Hubbard wrote: > > Clean up and move some copy-pasted items into a new mseal_helpers.h. > > > > 1. The test macros can be made safer and simpler, by observing that the= y > > are invariably called when about to return. This means that the macros > > do not need an intrusive label to goto; they can simply return. > > > > 2. PKEY* items. We cannot, unfortunately use pkey-helpers.h. The best w= e > > can do is to factor out these few items into mseal_helpers.h. > > > > 3. These tests still need their own definition of u64, so also move tha= t > > to the header file. > > > > Cc: Jeff Xu > > Cc: David Hildenbrand > > Signed-off-by: John Hubbard > > --- > > Acked-by: David Hildenbrand Reviewed-by: Jeff Xu > > -- > Cheers, > > David / dhildenb >