From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BCB3C021A4 for ; Mon, 24 Feb 2025 19:34:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E92B328000A; Mon, 24 Feb 2025 14:34:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E1BFA280002; Mon, 24 Feb 2025 14:34:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6E5F28000A; Mon, 24 Feb 2025 14:34:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A5C95280002 for ; Mon, 24 Feb 2025 14:34:20 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5D222C1B5A for ; Mon, 24 Feb 2025 19:34:20 +0000 (UTC) X-FDA: 83155839480.03.52FE2B1 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) by imf20.hostedemail.com (Postfix) with ESMTP id 7CDBC1C001B for ; Mon, 24 Feb 2025 19:34:18 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=OglfEAFP; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf20.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.167.176 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740425658; a=rsa-sha256; cv=none; b=O4YCmtwKjvGi4thsi2yhbqGgl5WJzMOoEN1YvB+PqYKWGvlwP+lXig+a4k+VjZgeuHhjxG 8e6Xwf7DKGZvV6MLGjZrl8aVVBIQ1YS+j5/jFy1BA6IzerauT67NkNEC34vc/jPtt5YLTL MPkY2SQet70imjSxR6OmphkXplC9fKQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=OglfEAFP; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf20.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.167.176 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740425658; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oQY6dOosAcucIiRDQdMzsS+fL5tcNzoRGW55wAAQqwA=; b=FZnXA5QrQb4A1GT7K21dIvIMI1mLQxvQ4+n5PX+idHhjIMCTPuue3PGVZBLmPHgM88p1je HnH+7+rmhUB0OG+1flmEtoraOQscFS6+A8dI5VbxYZ0nLre6VpuJvaXhNUT1kJEus7JzWo KBQmQdAI5yxj3sr0UWlAb4+kEZA57WA= Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-3f409ca7c14so99086b6e.3 for ; Mon, 24 Feb 2025 11:34:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1740425657; x=1741030457; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oQY6dOosAcucIiRDQdMzsS+fL5tcNzoRGW55wAAQqwA=; b=OglfEAFPGbayIq/v4ku4Lcd0tOOmrDNkq+RM1dt7iS/ThmR0M/9UC4/ZGtR/1bDLr9 Tm/i+4TYrOlqaOllpgiM6AWW23bt9xdADZ6UuC8V9ToKUuoj55nJRXdOzSGhPUj5w7K/ dZSM2ABpoj9+xMSnlPWwTTxMUNRmiNR8Pn868= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740425657; x=1741030457; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oQY6dOosAcucIiRDQdMzsS+fL5tcNzoRGW55wAAQqwA=; b=QJOogoR72hR9A3C/b+ScbnL4yOKeOIw1lb5mc1zW6xLoQr+6D7wiMqlWS8ABfd3DPV fMUrjz9DadIUTu7h4eCJ3oUbkavc9ffeaL38sxRVJqk5eyf6fdpJVSzen9sJdDp+RaE3 SelSqdP0Sbs2QtQu2TmVx17q7YKyjIWQV2rMB7N2ORhGAB45fvnSq3FoLbq1sRy/GWSN fBbdUmQxAkjTIYsI8PPG1eSEn1Msrm5p9wIWtnnA+qXHalzQUJtAd8GSVKKNZXVBvU+v 8PgEWaHLb/bQiBV+lUQQ9PH6x5P0Wd04GXpDj/CyP7GfUSM/pgm/ivL1/CkLcC6wo8hF s0pQ== X-Forwarded-Encrypted: i=1; AJvYcCV4x4qspup1RwqdXwBnAfWIlH72isPipERYbFXW5JpOL3XxVhs16ULNaDn94wNZ2T/0vo4lAQ1fXw==@kvack.org X-Gm-Message-State: AOJu0YyCd+z5+qAf98HL/3746sGBmQgHZqKYql9QB7gHW33gKrmcocen Fl6gFT3GeSjXsahvyUkByjGeHvLiD87giF3kgjIWYH8fANrbSBOp7bz1I2ronJXjFsE6arzMvUj xj1PJauPeHXYPzxfWSRTYgJQr3aAuxfNacpot X-Gm-Gg: ASbGncu73YPgvlOh+q6Hc82hjO40E2IE+xXUrSeueW0ryTWqc1Gxi5w9uOqrp74rTqU xAd5cxFHdBDT03lHyXsUY+Fzbnv0zy6mbDF0UO3D3F5RVFHHPwM1oZV7jzou82QZ3WrDCq6BBvA Jk26xl72o3rvUNH2fZjEQmJeT1LPJM7Fa4vDuW X-Google-Smtp-Source: AGHT+IFsKQI/wA+4sHfEV/I1olQBkEfue3loUdNFzmEYTOMnz4MZXEFiZGBxlenlf0rK5hXvgVztHBZRVg4eMn9wabc= X-Received: by 2002:a05:6808:178a:b0:3f4:cf:5d7d with SMTP id 5614622812f47-3f4247c0d9emr4328678b6e.7.1740425655952; Mon, 24 Feb 2025 11:34:15 -0800 (PST) MIME-Version: 1.0 References: <20250224174513.3600914-1-jeffxu@google.com> <20250224174513.3600914-2-jeffxu@google.com> <443992d7-f694-4e46-b120-545350a5d598@intel.com> <385e1498-2444-4a7a-a1b0-0013b0b8fd68@intel.com> <202502241053.1FF33D5B0@keescook> <202502241125.75EF4FC783@keescook> In-Reply-To: <202502241125.75EF4FC783@keescook> From: Jeff Xu Date: Mon, 24 Feb 2025 11:34:05 -0800 X-Gm-Features: AWEUYZlICjQ_BKj7NOI18C7IZh1axQsiUlF463h-YGPwCWcvEopchlkyDHgqfEE Message-ID: Subject: Re: [PATCH v6 1/7] mseal, system mappings: kernel config and header change To: Kees Cook Cc: "Liam R. Howlett" , Dave Hansen , akpm@linux-foundation.org, jannh@google.com, torvalds@linux-foundation.org, vbabka@suse.cz, lorenzo.stoakes@oracle.com, adhemerval.zanella@linaro.org, oleg@redhat.com, avagin@gmail.com, benjamin@sipsolutions.net, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, sroettger@google.com, hch@lst.de, ojeda@kernel.org, thomas.weissschuh@linutronix.de, adobriyan@gmail.com, johannes@sipsolutions.net, pedro.falcato@gmail.com, hca@linux.ibm.com, willy@infradead.org, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, peterx@redhat.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, mpe@ellerman.id.au, aleksandr.mikhalitsyn@canonical.com, mike.rapoport@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 7CDBC1C001B X-Rspamd-Server: rspam12 X-Stat-Signature: uegz943x5ahou93o38rctuafteyx44gn X-HE-Tag: 1740425658-552605 X-HE-Meta: U2FsdGVkX1+VBZ7+fhkK7im39672OKk7I1GW6IVcH04UmcdjRXZeqTLjylcz98pLiOXA4PA3YxGVnPuhEuEKHUMvfEB2V709yALqkYYTbcxs42q1AvXEOxGyJV5tSj/IEv7JROXSS752E8pndK/wNky7n00y8uhpT6NAJ0yT7OPVZDCceFB+NXz/of3c6dYP5hMG2j+rzHNxi6MDi7vWB9Bi2DF2i3Y2VM6SapiU3fNep7oqCk5JC0vfaGvFWKUInziyahmLZIQafO7DQOuYPUFQp8RSzDEk1kZKxXknzSvBStpyiu3vGjrz/JGbO50P19ZYuARIvH1/Pv4TL0kSTroT9VM7ekO5+YxSQmd2jx5aBoGrq6niCf/BVB9zPXbrEVcM/wo7BsPYPPCMXUd7WNacyaeQ/BLdqCFKo/cd1crTGj+BX7rhVaQRaDmoCGNHE8+AmWGonyBGBd8cRqeUVgMUeBZFpS5WNpUjloekdBMuJYjgiOpcoqx9Kf1tij6DzW8+0EcYfhne2e20FCsF8CcVCsCaVMPBPYIo+xQdyVrXkUbJXLNotKqTdpUCIRcElGSqT31lxsVVr9o/ba+Cu3lM2JiPPNKiwFAWTJiOUzwnL5cz3PlXefqngvY5Q59ONk5AGHi9n1HtNF40u7fEKSJex5IMVh9WFnX/B/ydR0VlRonIs9jVaHNuBELLc5LytPcIbhSGPYwaz+euY50lZYPqkf4wuKQ3/1ccgnboZ3XtGLXJgNbbAPVhPbPMxNiqd+eUj4602AfrEI1uCpwE2qO2VGvD6tgsGOlV/54gjfIU7iwHrhGhpc+pDxnJmig8LNxpkTGckCtJHOUT18NmleII+yyeI1GQTOVRLh2gUaNc3xWzg+j0e6QTjdqlvHeK6BPCLS6ATM9rpRcgmAMtdPsgejvfg8xt3uzLE2RsRXKn20BolW3Ced7E1Z/eOsOAI4L29oiDJVansbKzax+ CxTWoJRJ FkYZqp5Qk4GMjE5YI2c1A3AO+lZWQp/O2BfEATRzbQOrZW0+978CDxXO5AZK0mEehioKb2rh55U9iUsVRgiisGLep6ZixfmKOfqTepXSNJNHX4peV0Kn7ok4h4jRgWYPyyEddXUs6ej70DZKjaIGmwi62tENLS4RGlnOxpEiiJRzHZQvpsmcOtxtk8gsfA0glIp2wegaqSVm8vsgBrSL2ikQo5LXtxGA5lV38bCBakwCJcPFofFBVvOxXxtcmfBd1mGvy/4HhN6OOGklqYSCkCVix+KanYZWjpqm4O5WiTsS2Y60= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 24, 2025 at 11:26=E2=80=AFAM Kees Cook wrote: > > On Mon, Feb 24, 2025 at 02:10:58PM -0500, Liam R. Howlett wrote: > > * Kees Cook [250224 13:55]: > > > On Mon, Feb 24, 2025 at 10:52:13AM -0800, Dave Hansen wrote: > > > > On 2/24/25 10:44, Jeff Xu wrote: > > > > > For example: > > > > > Consider the case below in src/third_party/kernel/v6.6/fs/proc/ta= sk_mmu.c, > > > > > > > > > > #ifdef CONFIG_64BIT > > > > > [ilog2(VM_SEALED)] =3D "sl", > > > > > #endif > > > > > > > > > > Redefining VM_SEALED to VM_NONE for 32 bit won't detect the prob= lem > > > > > in case that "#ifdef CONFIG_64BIT" line is missing. > > > > > > > > > > Please note, this has been like this since the first version of > > > > > mseal() RFC patch, and I prefer to keep it this way. > > > > > > > > That logic is reasonable. But it's different from the _vast_ majori= ty of > > > > other flags. > > > > > > > > So what justifies VM_SEALED being so different? It's leading to pre= tty > > > > objectively ugly code in this series. > > > > > > Note that VM_SEALED is the "is this VMA sealed?" bit itself. The defi= ne > > > for "should we perform system mapping sealing?" is intentionally sepa= rate > > > here, so that it can be Kconfig and per-arch toggled, etc. > > > > > > > Considering Dave is the second person that did not find the huge commit > > message helpful, can we please limit the commit message to be about the > > actual code and not the entire series? > > > > I thought we said that it was worth while making this change in v5? > > Right, please minimize patch #1's commit log to just what it is doing, > etc, and leave the rest of the rationale in the 0/N cover letter. > Sure. > -- > Kees Cook