From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70D6AC87FD5 for ; Thu, 29 Aug 2024 19:41:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 042276B009E; Thu, 29 Aug 2024 15:41:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F09AE6B009F; Thu, 29 Aug 2024 15:40:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D833E6B00A0; Thu, 29 Aug 2024 15:40:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B8EBD6B009E for ; Thu, 29 Aug 2024 15:40:59 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BCE71C112C for ; Thu, 29 Aug 2024 19:40:58 +0000 (UTC) X-FDA: 82506300996.26.E676937 Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) by imf08.hostedemail.com (Postfix) with ESMTP id D7F7416000E for ; Thu, 29 Aug 2024 19:40:56 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=KJFaDBar; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf08.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.48 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724960384; a=rsa-sha256; cv=none; b=yaJsOVcWsGbjCRyl26QaREYdHCKs7UPcdqBei7an4mNjfkUWSFHRvUF/reHTRHV6fyWO+q 0VJg9Zl/VUW2QjZ6q5QxvRx1mhDPwdzir7OPcDzlQvUZatNxp5+/MKChx/PKzztACrSwP+ Zd3rCd5TMYiSZooX9hOWlEfaxJxSZKI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=KJFaDBar; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf08.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.48 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724960384; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qeP7+7zu3T/79b4rxXTTPMEgHAIHkf2ZJ7OCPpbIZfY=; b=cc1WV+G53fGLS4uGpFdI/3R81ogaUT9Doq5a4lYmV9ZR7ftk3PKR3bCQmV0fsgU8dgjna3 QkDpSvCg135YN6iXuQlRGRPUOP5UB9XGBBbUNTqBjf0HLiGnh6/fvmTrqc1uCJIXWpqlfb AEs/uQiH50U3blEnGiuy3+7ETvoL+6M= Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-2610c095ea1so130555fac.3 for ; Thu, 29 Aug 2024 12:40:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1724960456; x=1725565256; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qeP7+7zu3T/79b4rxXTTPMEgHAIHkf2ZJ7OCPpbIZfY=; b=KJFaDBar+SU6QQQEWiKOROFpFe7yYAW0JDOeUQ2yFFvEXa6cvPQ6TZOBubgQ8QzrsA EH4H6OJU/F21R/DIS7cc++0NaIMbeU36hsWkJMZDi4X1vvDR7Ovy/zXdlfan5zi9VgDZ I4ontxWeYPT/cHtu65aeYLsktNAACyozaSjIo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724960456; x=1725565256; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qeP7+7zu3T/79b4rxXTTPMEgHAIHkf2ZJ7OCPpbIZfY=; b=mD4sw22wjhNOpl6z/oAH4mdcwSYD4l4Lt2jy1GftIyy7kesjWIU7JqtJR6h2t92f37 SoS2SdOpS70/4nwCz+t3ayRG1l7F3ih95q/Vyj8TOTD9Nr1WXTz1T25g5LIqi4Mg1ikA s+qXH2n+0CnJKDNXxLbeNMpTN0foDLuM86deiKhMK/mCWU2UN3ACO1/0nwfyOhwyq0jo NP50Ed8xXd19jND9M8XoywKQWwyq8F4fXxgSkFD+ZDUvctqemxV3YvFExvP+UXH7BtJx en0WToYq/FMWX3v0M3yMc9bts9Y1YSsnu14vltjmgprBDAAiqqz3rOFaS/A91cCYLSWu Pqgg== X-Forwarded-Encrypted: i=1; AJvYcCXJUszem9LbflbQisbYl+2CW2oPc77BeV8f2kv+5n6S+6UziEXyXz2sWVeSoEFzMBb0RVTZHxUT1A==@kvack.org X-Gm-Message-State: AOJu0Yx9NCUWVUkK4oIeWuaNpqHbSNjSiVZcr2cHm+1vz4UBt2QuEnHZ gyeaWD0scDxetDykB4h8llisYVymRzs9mveLN5bviwtrW1ntrzrt7rJUQHYd0+s3C5GTSlGlnTz BKdwI87vwC+7lMzMrFr2zWAZprSmZvMpbYrH/ X-Google-Smtp-Source: AGHT+IHrhliVtgaPcNwC1VORZquYe127iapzTLMkWCuU1MGSlwiVFEIhF+6O72+5oERawbaaGrKqSENthMbSR8WELjA= X-Received: by 2002:a05:6870:8a26:b0:26f:de62:7d8a with SMTP id 586e51a60fabf-277903bdf4cmr2113653fac.10.1724960455702; Thu, 29 Aug 2024 12:40:55 -0700 (PDT) MIME-Version: 1.0 References: <20240828225522.684774-1-jeffxu@chromium.org> <20240828225522.684774-2-jeffxu@chromium.org> <293ce8ff-10c3-46b8-a56b-a1bddc7aa37c@sirena.org.uk> In-Reply-To: <293ce8ff-10c3-46b8-a56b-a1bddc7aa37c@sirena.org.uk> From: Jeff Xu Date: Thu, 29 Aug 2024 12:40:44 -0700 Message-ID: Subject: Re: [PATCH v1 2/2] selftests/mm: mseal_test add more tests To: Mark Brown Cc: akpm@linux-foundation.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, pedro.falcato@gmail.com, rientjes@google.com, keescook@chromium.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D7F7416000E X-Stat-Signature: ga8a4ms9z79s1ukh5tjpo5qkahhkhczh X-Rspam-User: X-HE-Tag: 1724960456-735844 X-HE-Meta: U2FsdGVkX1/JFLUaDwt5Slmo+kup6Gbn3M06bHFDbYr0xs/Ix0w8jkDM5X/J0mvb0wZRXDhiN0jueQR/Jl3KTCkOPMKMaWz2txaODJtIqYW11RAu2/RI7VoHikwfdlfmiEYeJaaOPZ3g8CrzGYB3rh9ZF5z/cefpfzmxRB8T4vBKsxuCfsd1F+CsYSKjUnRYSx2Bqy/oPNHBNxQDa3+aVSNpc80Bt5tCXAoEvOK5fXbFnOY2Yy9d9kvonvGmEOuXolb1Tq7fHOJ0TYvfjn0SxbrxGLjK0r+yyOoSGxxQBvcwe+V4/782IP4TzZ6gj5QgIBk1mipatCS3JB+ngJMMtIGtbHmZeS53Lfcw4K4D0rjz7/ijEiuOXfOHq/Z6UxIwA883EyaaPWFIccdWDVxo/7Ne2nzoQjRheM1cK15QL4cRHGJTIAUjXcWxDqC4n0XkUrftKmtHZpulAvJYXj6j2f3F2VcXK/tKvylSIb0PE3CM1d3VvLQ3k1TL3W+j3lW1G0sPXt3Wq3Fo5ile/qpn6jIvov21CCUuBVojdIAaODCBXIUTlttoAwvTW2hIaEAhM1WE+axltTNBSdUjGO9tMyMAoautWjIbG6i3Eg0uEJBILgNZJXUVImro3z2Ost41VMYGF2q90d0M5M4xa78IB96jO/pwa3h1YCEPQyJ1Peg8BPrxwzcS0ar7/Lf6jEkM8CkH0gvzNxWl17PIvd/Hr65qEnq2pUb37NMFl8Bg7Bh3KJm48/jXF02xtJuifAWHyzzYwtZdgHDHpzXiD78q1xTsTwIIGqt6m1UpvXmNflbd5JZO6wwiykDH4SUePAnHZFhxC/aZcpVtvlthxQToi6nX72CToGfdxXCLxbKA/Ea/c8+nPChLOSTrnT3oESLbHJSuW+HRQS9g+Yi1etpAmly1rvGrs3aYZnYf/jlgvzqS4tTC6leaPjvc0HMC5wvdRDs5ad7224h3wBJ0jQT fMuaHF5+ BMKq2SJ5DdKmSaj7dainanM8aAz1eTerkeCdMVNDA19gRKWWw11r19dZ6XjHjC0/AWIsuHjqlo3hcdcfQnfrkFeQDe+K8+YeqLhmyDBmDHvdpvr2SwukllQmm0j5DGCR47uOKfwBoPx9sHQRVViJNTYn5rqqEL69SjQy/Tgb9j+xwZfJACCGIm5OdRtIkMnN4lKTwvrdj7igxqc3wCMOvr66hdNran64OB9IR7sOpX1vc2oiAAZ60cvRgJ15//HkC9FrCdDU/SeHaV+47LKEWVAkgIFlxxXVfDXegdP8JlBj/+eDBctdKy7DKOIS75GdflTq30cVAI9dcRTKMSc3hMM69u/549RRGdUY7Y8dtWmi2d7s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000220, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Mark On Thu, Aug 29, 2024 at 9:16=E2=80=AFAM Mark Brown wro= te: > > On Wed, Aug 28, 2024 at 10:55:22PM +0000, jeffxu@chromium.org wrote: > > > Add more testcases and increase test coverage, e.g. add > > get_vma_size to check VMA size and prot bits. > > I think this needs to be split into multiple patches, for example the > new test cases done separately to the additions to the existing ones, > possibly as multiple patches (eg, should the size changes be split from > the prot ones?). The size check should go with prot., because it is part of verifying the sealed VMAs. I will split the patch into updating existing tests and adding new tests. Thanks -Jeff