From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79BE3C87FD2 for ; Thu, 29 Aug 2024 19:54:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA1AD6B0093; Thu, 29 Aug 2024 15:54:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E294D6B0095; Thu, 29 Aug 2024 15:54:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCA366B0096; Thu, 29 Aug 2024 15:54:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A62E86B0093 for ; Thu, 29 Aug 2024 15:54:24 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2EDFDAA40A for ; Thu, 29 Aug 2024 19:54:24 +0000 (UTC) X-FDA: 82506334848.15.9036453 Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) by imf16.hostedemail.com (Postfix) with ESMTP id 5DB4A180007 for ; Thu, 29 Aug 2024 19:54:22 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ZW0LFNsC; spf=pass (imf16.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.47 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724961217; a=rsa-sha256; cv=none; b=OMkMCaW3EQ7t9DLuCnpQ2vwcr4kZ4gsX0zoByaf3kjGfFBKvDA6dqdvmI2yWmwIz6KQo/f vlZfAsAMcG1MwJaA36pzK10QSHn6bA9pJmngbYhltCiiahHmNTzPhtNrLIz4ctGFyDMsfU z74xOqC76XDl+ss+XI++qcMO7RBs8Og= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ZW0LFNsC; spf=pass (imf16.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.47 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724961217; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=guVxu9HxEDSLtaNB6zapABbY8BPidXJ8qvB9HSCs1b4=; b=JgwXnQN3vggFVWdVfYM2ulSt4+k+3v8rfM1COnciQNm31+QGgHR6Pt/Q9llXu8UnHeRPKI 9DvjfZ9CuOOp1TmW2nPRIYQYal6zABPpmivUhDx75ssrt0AYS+TOL4WFF91Siz9yEbl/oL ap0Ih8fLpWeaXU9P3zBYTtT7ijUTIAo= Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-2611dcc3941so56444fac.3 for ; Thu, 29 Aug 2024 12:54:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1724961261; x=1725566061; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=guVxu9HxEDSLtaNB6zapABbY8BPidXJ8qvB9HSCs1b4=; b=ZW0LFNsClKt4tXO7cHUFyp83x3fqp4LTnKFneKPEaP7PzykLyse7H/DYHaWmzVytz2 YWIpzCDHYMc66ue+mnZeUt4NxD1uqpeEiB3c39bbTrpn8lyiS3jsNpUe5HrllG5RvMBh iA0uuwK8QTBZihd3W0idrCecrtby/a/b+wc3c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724961261; x=1725566061; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=guVxu9HxEDSLtaNB6zapABbY8BPidXJ8qvB9HSCs1b4=; b=MM0z+FdhpLD8gQYxM2vxfN/gx+ZDi8SnCnkrgBsKA3YDiZXJQl/fykY7x0ZSfpGsFo nrizTI2qccJC4+u3IPDKXxE5UksteYXmxXKPwYOlvB+CsDoK9aQdTt3c91+E3q+Qxv03 iH7O351Xr6+qEH3n0mQMA7ROUOsq+qyU/jWxN3zApVb66D1B9dKLVD3qQCcIT6N4SG13 NC/VwmZaUE51AYpXiHLPc9JFTHyNCFEchsnH4pHRaM4VMZxCjz0N8qI6AV8mgLlsOhPE M0N82ED6Cg2NbMeIUDXAn25E4RPgfrCYLqb6p4TV6OSRJU63NHr6hzCOP4xqpJ9hx3/q 7kvA== X-Forwarded-Encrypted: i=1; AJvYcCWK+k22DUBMbA3uPTn/CnLVCURYNp3GBNqF2HWP0Na7b4reUcjKJEbcKT6/5H/mo29EPfy62Xy+CA==@kvack.org X-Gm-Message-State: AOJu0YzNE9Yhn1ohx7iAr4owgVZHMnb25kSQx9to5JsMeIY1Wgyx3cL8 O3Jz7AANMB/qJWfrpO2PyzDRaP4Rg15VckSIOSDdB092NvqrtmJaOu8LJjYr59gSzcIubtdi2Ph fIr+u+E2nuwmsJ4oT+QYpQwFd4wK/z7A586tC X-Google-Smtp-Source: AGHT+IHRaSJMxiiEHHnyyPMW+E6Zchvcl2ZBtiZzi3ND4sx5NZsr8zR9UFo54QC6zM0irr40VOAnC+AYh5/ejQvMlDw= X-Received: by 2002:a05:6870:fb89:b0:260:ccfd:1eff with SMTP id 586e51a60fabf-2779031ccd4mr2354479fac.7.1724961261302; Thu, 29 Aug 2024 12:54:21 -0700 (PDT) MIME-Version: 1.0 References: <20240828225522.684774-1-jeffxu@chromium.org> <20240828225522.684774-2-jeffxu@chromium.org> <097a3458-0126-48e3-ba0d-d7dc7b9069d2@lucifer.local> <5a312d38-4591-47b1-9a6c-4a7242dbe20d@lucifer.local> In-Reply-To: <5a312d38-4591-47b1-9a6c-4a7242dbe20d@lucifer.local> From: Jeff Xu Date: Thu, 29 Aug 2024 12:54:09 -0700 Message-ID: Subject: Re: [PATCH v1 2/2] selftests/mm: mseal_test add more tests To: Lorenzo Stoakes Cc: akpm@linux-foundation.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, pedro.falcato@gmail.com, rientjes@google.com, keescook@chromium.org, "Liam R. Howlett" , Vlastimil Babka Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: au7a7mef63sgyiycrgz74fr6d8f3eazp X-Rspamd-Queue-Id: 5DB4A180007 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1724961262-122870 X-HE-Meta: U2FsdGVkX1/OXetOFieKD1AoMFCuL1XDTomC3eiXrCMuIY39at/ZnN+kK654UWCHs6r+SC035rfhB5dGA19z3fQLW8QrOW6cqqo3pRtEFTBpcjagIbES2B2rVovIXlYfeZxyRRfoE+51LutYwKak98pJ4yBerAlnrPp03AvKair4brWjop7fvLkwbHKZVbw0NzOxGJfPQCiuWs7dnH43drLccHEX57I8BNBTuDPM7sJKnOxIJL7gEA4HzkXeRH795WK4tMeKBuab+Q3jlXueCcHlpXHSCnJWLyyOfgJoWjmsb7YFw5dNjJRLvx6q2GHkJwatgX0JkvV7X/zIo23IZho4D90xeaNRnvad6RiL45bcvK1ov7h1+RJaB/ZbeNL2+aWm+trzEADzAjiqDyoh6dJlCZ+vJwE62PRRyK5nSocUKrFDmG3+ix+urZt5EuGt0eefAy6Y6D5omv57tHwM1PeXTigj8cm2wEhd5/cH5PjssBg5Q09EbFAPwwWO2TUFCJaQe0MS9h7UjDCJyf0lGLiijT31nMO5dxZqDiwoTJL0QCJTsVuHDRbofDI12pC1Bgk2TAe6W0HNf2FTbUo7VuxmGHJqAX3sWluKMOITjrfggqiQ19vR09fMV6b+TI9YhdPKG4XBNj5hDV92wDD6I6IgSksztiD1A6tGRO6VPciqDUoodnKNy5RcEeLLtz4N0eYiQlEuaMW8HXz15knHCb0KDcq933QinKPV9PrYvBb5QzkhwXSu8R4AW69QdY0RSVsSzZOnILw+zc5H1sZactbrQw+Z/Gtw8KMeHUmYGzAi2CrL6oOduxBikjM0f4yhGMdoaS9aGU3aXD8tsuokPivR1cZvkAbEODzzv7LlFy/QTrhELNTCtEftoF6Ke0oh5sHA4/xM1kyxXkRBM0vyh5yiJ5SfygUTN+7CZ/Ohx78hUhSO6JwCDysjKHKcmwx7cAMxGVlfJeQ0jvv+DhH OK8dcwzB 637tEaMs9DYnE4sJzX6oK4bv3Hijsxt5RtWD1qjMbMj2MFzbYRtePo/1opDmrHzRfl+2CL2PNcwbZm1pNuQkTR434uyUDti1Zpjnf8My9lYvz12QCuvTy68SbNxNs+b7a6Rqa5RozADc54bTVt6Kd8Br63/7WiIYPISg7se2V+2P+BrBGcFDSRISNNQhRJK0oI/reDyFk0qvLRq7xvRt+G/U2nnuYkAjLuvX5ov6xtxYX2Wyt/8OVrinoOLqxh5B19UppkW3yY7TKHwXkvytG78QHu/7dIyBtchCpIBqQQmSYkxf74LaDGP4tcAlcETB+I8s0C0wVjslgv29V00HBYY5g1uPTdVW94yiVhU80qTVBkuk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Lorenzo On Thu, Aug 29, 2024 at 8:44=E2=80=AFAM Lorenzo Stoakes wrote: > > > > > > Also, this is a really unusual way to send a series - why is this a 2= /2 in > > > reply to the 1/2 and no cover letter? Why is this change totally unre= lated > > > to the other patch? > > > 1/2 has a fix that 2/2 is depending on. That is the reason they are togethe= r. > > > Can you send this as a separate patch, preferably as an RFC so we can > > > ensure that we all agree on how mseal() should behave? > > > It is not an RFC because it doesn't change any semanic to mseal. The updated test will pass on linux main as well as 6.10. The increased coverage will help to prevent future regression, i.e. during refactoring. I will add a cover letter, split the tests and add more comments to help the review. Thanks -Jeff