From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 311F1C27C77 for ; Fri, 14 Jun 2024 19:02:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6557F6B00D9; Fri, 14 Jun 2024 15:01:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 604A36B012F; Fri, 14 Jun 2024 15:01:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CBCD6B0130; Fri, 14 Jun 2024 15:01:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2F0E26B00D9 for ; Fri, 14 Jun 2024 15:01:05 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C6A93140905 for ; Fri, 14 Jun 2024 19:01:04 +0000 (UTC) X-FDA: 82230411648.23.EFF5341 Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) by imf14.hostedemail.com (Postfix) with ESMTP id D312E100006 for ; Fri, 14 Jun 2024 19:01:02 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="J2t/3RRS"; spf=pass (imf14.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.42 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718391661; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K1ZALSntPjOYxQT4K20rIUTbBjioOSB3dIGMzglARe4=; b=XNEY1Rvl8SUs5/oseNM63s38JPIelfxTzJZbKscssuGlsAnz7Oi6SUfxBk4tICyqgab7al lFdx/7RHaoX0gWBw3NxWTuZ+YsC8M3As72OBRrj5U0U38peayEXhSZUMPINr+1JheGWa4K tHiTHRIaF3tLJMoT/CNh4tEfQ+kfV50= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="J2t/3RRS"; spf=pass (imf14.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.42 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718391661; a=rsa-sha256; cv=none; b=r46uApwwJh+bNV9ywhyKrl3Bazqb0YhRRbm76YPxjI7mIwE0GD2kWDM2ZmLR5U/Gh1MgiG zIphauyOasUUWgYvB5D90nMpeNi2YOL9dR7QJYO8GQkjhHfy8BGV0GO7nHS6dzGZo96ET4 jc741uOyK+y/obIWj2wC4xQRaiXlmtI= Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-250671a1bc7so1151752fac.3 for ; Fri, 14 Jun 2024 12:01:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1718391662; x=1718996462; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=K1ZALSntPjOYxQT4K20rIUTbBjioOSB3dIGMzglARe4=; b=J2t/3RRSwb6dS+fTc47SSL0b4VQhtxURdMqszXPm590MiDQOzOZGkRK41bmCmcvHVD 6n1jalmDSoOuoiDO2/FuGOAKaO5nKr+9D7SywGKuDwCu+ognw2ow9XxC+RDT8u7khbsW wWU0D9MipN9TvB4cZ0FP0HZNU9FUyLteZlO0M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718391662; x=1718996462; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K1ZALSntPjOYxQT4K20rIUTbBjioOSB3dIGMzglARe4=; b=Z33sSgMHNP/BIrw282ONICKPc3Q2fSRWAYrWyEQkx1J5Nk9aD/uGCjq4TPm/2RJmgQ b/iMZf9pTLY15I6nwYGWzftyb0RsugRKz6bFG/Mm/Budy+wrlLPOdb8xC3Sg2JdyOcvO oZFXIfg5YWOsM5DbXwwlaD04e8IosG6zGZrmybnrTZm/8OuGyBaP/fDq2I6e2oSK+4lP sPdNnftxvLXdRPNC4mSwY6SgGagzMpU3Pzj0p2GElnRcfxyCj3/17j5xgREEGbYsZO8z 4LbsV5Mswb0HSkPjyHd8pc1nrnNX7ZnbGdX8xEjoMiSnnQ0z135BokD1mUrkUquep+fr 4Ytg== X-Forwarded-Encrypted: i=1; AJvYcCVpDeRcTDlXbh5xyQU7Bplop2nOWdFhgtjNGr+wmue8V9q/MQhtoWRLsWt8q6gX2BCRRS0DpPH1lIPxWRArRPxsYMg= X-Gm-Message-State: AOJu0Yyp6r04MrGr/HEOpfKbwckx0h3ceH0M7kPuMWYNrUT4NA9k/nU0 wI0c+dlOEYGPB1oSyY3uBFPSwQj5Gc1dPWUMY1LErY7m8L+wt3JEnoYZFTHHAuq6ICXg5Ocy8P7 GZ6k1PxrlciO81dtmrEDxN2LvMI2wn9aQyHtV X-Google-Smtp-Source: AGHT+IE5vSXJUDHmMRMjvi9lHMyHeYOC81ficWEmhdAwNyfxFAeAm8r2tME4kjQms/HqWO0W6fLsMjVrn5UOgIjFfoQ= X-Received: by 2002:a05:6870:41d4:b0:254:a09c:6ddf with SMTP id 586e51a60fabf-2584298e0ffmr4078582fac.24.1718391661719; Fri, 14 Jun 2024 12:01:01 -0700 (PDT) MIME-Version: 1.0 References: <20240614182327.752156-1-jeffxu@google.com> <20240614182327.752156-2-jeffxu@google.com> In-Reply-To: From: Jeff Xu Date: Fri, 14 Jun 2024 12:00:49 -0700 Message-ID: Subject: Re: [PATCH v1 1/1] /proc/pid/smaps: add mseal info for vma To: Jann Horn Cc: akpm@linux-foundation.org, sroettger@google.com, rdunlap@infradead.org, david@redhat.com, adhemerval.zanella@linaro.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, keescook@chromium.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: D312E100006 X-Stat-Signature: djoy7oe4i8srpk48oi9gu93mcxna811h X-HE-Tag: 1718391662-225422 X-HE-Meta: U2FsdGVkX1+6nVBUH6vjeIiGnabAQ/7/ljBwAtuyMwH63VKW/kI2afRldjDjP1WXS5aPNRF/Rzhg7QJzEY2lm9gAMcpdZTPrlRLv6RqSAAVgEbAhfF30q4bEDX97LGGuQPkpXuIHtwlTTKtH3tx2Gd7t0XRke33k2cEgL02TQjKsb3EzSBIVpx0J0bJFipOh3UPrfecto2OttpfgvXMhyZwwPEXdjaI6+8tljsiwBQtRMyUiqRVlYtRf4yK/povyVVgqG058gf71z93NpeqiNufwecoWGq+EggOamdJ/UXLQYqxd1GryshCE2KuzcNmBFy15R8euEHKtjc4KvYQ6Zqeg/dGcV8H9Q2OyTUe3f+APhceOgWMKc6GiehdNfEXenkWdMdXwgasPICWP3/czEu37aXQEABNGjxiLiq1qjIZmjd80ox/cyq6SDhC9A3HQlbQeb+E8TumlCeW6/12D4TRjseOQKiFLUlJYBLr8+2TixpYtO+bOnygpCN5j+q6I1gb5e6WExaDsipzFvjoFXOHeuT6ZPmbhjkJn9xFq8CbURyGjGACHixU+MYuKlkddkTHJAxkZ+Dpn5v1pudupjVC12Iz7SSu/AWJztUTIHJxpDNdiR+XTrAyeKTpj/Nx+hjmWnwempbgzc9cG4bBMO00+Z/G+CroBmjWWre6/UjYDx9ad+dRpAqNY2/WuIiZIug4pIrZsw3GiXrSHOaKrdatcK5tC8inGvw8o5feDrlGYOYXz1/qlx82V/hENj6FlfN/azlOSIlnLV9jDBbwyhIOjhkCh1kLXtWyhAKMcJJeHtitHrBBNPdbVtgDbqJlDBXy/rhWpOoCbXKxbmqVjuSjQycOsvnE9E7sqCMXzlwbpqjlfWb3teRbnyRdOcK/Y1mEbAWEDGVl8vtGZF8oiHaDcSkWAMrPEtWAuGXgwZY3KphWkWGcEcDTEsS3L8P5KJF7Vpw+c8lQfs/Bk2az 40sachnF MK5ang891V7U+Htrc3jPhTOkhVfJAo8L/OlV5P/kLgqmTtk4KFBXBrbucjptwXfKWJhcGRDJnKHJqQLUSQVbid6vNcChuwFkpe8NyVLfiGHISFN3PcdYMwpMniB5gvBAgzmO+w2a3dJOSqkj+2oPZX3k0WCsjifGMZOokZ8gC044UBC48Pyd3GozLSNB80fGH6TQq+FhP7MTpbiToY7jzJC5B1GxraLKZaa6crbIzjRPmvCXEtInpQL/2lqtNM5+aVfVk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 14, 2024 at 11:43=E2=80=AFAM Jann Horn wrote= : > > Hi! > > On Fri, Jun 14, 2024 at 8:24=E2=80=AFPM wrote: > > Add sp in /proc/pid/smaps to indicate vma is sealed > > > > Signed-off-by: Jeff Xu > > --- > > Documentation/filesystems/proc.rst | 1 + > > fs/proc/task_mmu.c | 3 +++ > > include/linux/mm.h | 5 +++++ > > mm/internal.h | 5 ----- > > 4 files changed, 9 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesys= tems/proc.rst > > index 7c3a565ffbef..400217a1589c 100644 > > --- a/Documentation/filesystems/proc.rst > > +++ b/Documentation/filesystems/proc.rst > > @@ -571,6 +571,7 @@ encoded manner. The codes are the following: > > um userfaultfd missing tracking > > uw userfaultfd wr-protect tracking > > ss shadow stack page > > + sp sealed page > > Nit: Why "page"? The sealing is a property of the VMA, not of the > pages mapped into it. Maybe "sealed area" and an abbreviation like > "sl" would make sense? > > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index 587d34879865..8600564898fa 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -314,6 +314,11 @@ extern unsigned int kobjsize(const void *objp); > > #define VM_NOHUGEPAGE 0x40000000 /* MADV_NOHUGEPAGE marked this = vma */ > > #define VM_MERGEABLE 0x80000000 /* KSM may merge identical page= s */ > > > > +#ifdef CONFIG_64BIT > > +/* VM is sealed, in vm_flags */ > > +#define VM_SEALED _BITUL(63) > > +#endif > > + > > #ifdef CONFIG_ARCH_USES_HIGH_VMA_FLAGS > > #define VM_HIGH_ARCH_BIT_0 32 /* bit only usable on 64-bit ar= chitectures */ > > #define VM_HIGH_ARCH_BIT_1 33 /* bit only usable on 64-bit ar= chitectures */ > > Other 64-bit flags are defined further down; maybe it would make sense > to move this definition below the definition of VM_ALLOW_ANY_UNCACHED, > so that the definitions are sorted by the number of the bit? Sure. I will update. Thanks! -Jeff