From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFD87C7EE2F for ; Tue, 13 Jun 2023 01:04:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 213878E0005; Mon, 12 Jun 2023 21:04:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C3B18E0003; Mon, 12 Jun 2023 21:04:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08C0D8E0005; Mon, 12 Jun 2023 21:04:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E97F78E0003 for ; Mon, 12 Jun 2023 21:04:52 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B66D4801F7 for ; Tue, 13 Jun 2023 01:04:52 +0000 (UTC) X-FDA: 80895930024.22.A823982 Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) by imf20.hostedemail.com (Postfix) with ESMTP id 17A521C0009 for ; Tue, 13 Jun 2023 01:04:50 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=UPMkiJ0u; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf20.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.51 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686618291; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=2KQwF+tqN3ar7O8HhmycujLeoInp3ui0gwcQNlvCNwM=; b=ElfV7h/nOkSZCeVpJ4liYesegKPEng9FKKFqtaKOgLHR9d1HIkL6HWVeMtURGtzWKKwL09 mhXD55Ym6s6djuce2aPEcvRb5Fej0ItVoHwu8JX9QKN35WkONbJ4aOp6e89qwHok0OFsw1 V681FiWPaatPwpO0fRElcGywrh/BBo0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=UPMkiJ0u; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf20.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.51 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686618291; a=rsa-sha256; cv=none; b=PMqfSq8HcwDAMOdafg8RuWOIYmi9JVfYhMpu9RSO0ITZVBuB5ddHcnqvq/0DMlaNhT463u TaTrzCQpHR7HcMkAredxnTcLkQekXMI2qRKXisV7oEkMRoS0sBbylkfkOUahc157kRYZkS KckFE1i80TKC7mnnvCjJwYxsxv0P3Vw= Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-1a6820804abso1548380fac.2 for ; Mon, 12 Jun 2023 18:04:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1686618290; x=1689210290; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=2KQwF+tqN3ar7O8HhmycujLeoInp3ui0gwcQNlvCNwM=; b=UPMkiJ0u/r52W3Kl+RYwCsXZJiuT3Mm+08kVKuKrUrkGCKvEq/5lSJwMi3tSatCWX5 fKZ5SCt7kCgChYFhrjVIJLYlDTWxPiQv1XaGfv/TToLwmRB7FjZR7sz5K7ZNfY9CO0cm JuotV47GNcz2c5fAGEv5zOj+PgmFiquq5jF2w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686618290; x=1689210290; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2KQwF+tqN3ar7O8HhmycujLeoInp3ui0gwcQNlvCNwM=; b=kbcY5/foDJm90Ib0Q4JAHyAOZsFLS0IWYclOweLnXqbD3wUKxdnjZjI0vL8fp3vSnG 6qIm6cu0bqcBAXoI1exMs/xn3uCCaGWeJbARX1ErprVQvKss4vV2kBZhNSsDbO04DKT4 ueL02sWhx/epxD3Le1rKhkVqKK0xlyynfs0i1thg6FjUZJEgNlUwG2pzY04uk73bPDUm Jy0zDpgL6KUhaOOjE/6wG9qJt5aXLyaIrWtXrsRLQIWOqnajDVcQW791vRj/Mv0OkHcV eY+TKYaAJgAqyG0wOZHbGYDDmABRFNRwUcuwUb77e29v+RMD/uGKuM+vSLxoCoLDG+i0 Q4sQ== X-Gm-Message-State: AC+VfDwaMkepX8TsMLabBthjbb3hvgwNYTv5MW1jaG/RJ3WvKRfULso2 ZnAzaI7I4vcDsPYdj39JvNc2mVp78sBmLXlY1AgF1TON2XkFawK3kZw= X-Google-Smtp-Source: ACHHUZ6WW8micmaTUxPeuzv4crbx39qJfVCyq0oa28mnsHvqs0eCSd9KdZz6Jyl3DWmK3367T4vJGTsLVQQNnxxgRTw= X-Received: by 2002:a05:6870:1727:b0:19a:24cf:1597 with SMTP id h39-20020a056870172700b0019a24cf1597mr8526640oae.27.1686618289967; Mon, 12 Jun 2023 18:04:49 -0700 (PDT) MIME-Version: 1.0 From: Jeff Xu Date: Mon, 12 Jun 2023 18:04:39 -0700 Message-ID: Subject: inconsistence in mprotect_fixup mlock_fixup madvise_update_vma To: linux-mm@kvack.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 17A521C0009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 6hhsn776m47xkscqi7knuidunjf39rqo X-HE-Tag: 1686618290-216111 X-HE-Meta: U2FsdGVkX1+Fyiff5RSSIAr07Ok3oKk5utAhtqRM4gwYFdCLl88K8ZysE1jrsYg9fXCB/65xNIVJE47NuGK+Kioyxl7aJw/WI6lKx/wpwIRvzOTmcmnpt8lbsPn5ylDt4Xzowkbm2vCezjwXd6lUobk8RohUEn8ba4IwqpQ64Y6B1Cht5UE3TzIjCEXK/+O2uHgMJA9zVMcdAaP3hmAZGw9rEx7b4oaWr61rmTuqipHzfL3DM2natyZwSvQT5nf7iKMYtg/s5iHN1lnxrqhQCq/4omA8BgoqeF/mM/KKXcKy0oiMroRK/c/+zB3Dh+h1MUs6eEk+gMlvDQmdk6u6ddz6SqNn5TJUukVYT2E88uFZhkedp/n5N9qQhB0tFA8Yhu+jWwCdzzqmzmJz/WIVmVoGHItI57GQAQlyjbFJTZJjD3sjPyBk3l8pmsTlajoX+JZ58T1UVg95kUGC5Ya5NCO95f9NEsOT2R6V6ae2zh5fiQQGzwuCKZ10mum9eoxCdlDxILryPSTZbAppeIBNZ97TDVoG66ITcKldkvP7EXPLpR+yVqxqRZD0E9WLkNsIu4Gh+3pXegmnsEF8vdUk5pA/+rywuGsRry/Tt48LnApw+TSWJseCa0GlZOWwXqS2s8bomnsD+O6wIbNOt4H93l5WPmNZS6XEfmmb1wzNvbBJP5nIhq0uxTHkmLK7Aeu9Rwp8p5deeG49jmXX3YRDGBvOD5LzJQ4sNhMz29msNIMmCMJ2NKIUX5OF4Ehm0lTOek3PvmWUyftl8BoFJQ0+PgKx8ReO5egThalLPKruBBfYNQ0DZDMsbjsrS6wHy2Nvn4P+qk1AeO8RKMzv0gdNFdgVRZBebJs/zdbahlmlRvRoMKwCtLJ8pMmsttc/vrSVVJ2ENyyfnmX324R9xpUP0BIXUaxPDsCG7P/HvwgOlfn15j87+SfBvdrbnGu3FY+z2yInGZKTA6cyuKELxjw i0dHyPJT 2iYX1MlwGcHOhFk4HKbKi+pNnGR1uRgSRIr4HUZgpFJqKQojrs+8XX/wuK9OOmu3ojADiHXR3iGKbyfqn2lWliIYdAHiWZEasltYHyzKHZ7WvkL4A2qZYxoJxolWKCXTptZaoW1BVuH60YG8UQa0rLSAmMQGTHkkSDTeq4pPkPHxSXzILv1swT/c14RObhPu3Ng8e8vy1kpAyBP3r4jyB+ymyh+j/T/YbGj+dY6K7IyLAk1MtPlW4xKzatmHPhwT/r6vc6YvDYi6n6YM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000676, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, There seems to be inconsistency in different VMA fixup implementations, for example: mlock_fixup will skip VMA that is hugettlb, etc, but those checks do not exist in mprotect_fixup and madvise_update_vma. Wouldn't this be a problem? the merge/split skipped by mlock_fixup, might get acted on in the madvice/mprotect case. mlock_fixup currently check for if (newflags == oldflags || (oldflags & VM_SPECIAL) || is_vm_hugetlb_page(vma) || vma == get_gate_vma(current->mm) || vma_is_dax(vma) || vma_is_secretmem(vma)) Should there be a common function to handle VMA merge/split ? Best -Jeff