From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FE3ECA1004 for ; Fri, 30 Aug 2024 15:38:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC2846B017A; Fri, 30 Aug 2024 11:38:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E724C6B017B; Fri, 30 Aug 2024 11:38:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D39C26B017C; Fri, 30 Aug 2024 11:38:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B47936B017A for ; Fri, 30 Aug 2024 11:38:51 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 60224A069B for ; Fri, 30 Aug 2024 15:38:51 +0000 (UTC) X-FDA: 82509319662.09.F2A1100 Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) by imf09.hostedemail.com (Postfix) with ESMTP id 8A2E0140007 for ; Fri, 30 Aug 2024 15:38:49 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=MhwfO0Vj; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf09.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.43 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725032256; a=rsa-sha256; cv=none; b=GRo7ODegms1u2pOdH1U3vKX77ds7U4Yg5z+ABsoEkTB4PKkU6S9V5VlTy9r/Ob1bEeMjQL eh9tIB80XdgL2h6InRJwWWCYmw2fmxt6+qvQenF5foAo2uuhpvKTj0OcluK3QxzSs7nGs2 qJ1oW1815enlKG2G97FO1dFuD3lGHs8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=MhwfO0Vj; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf09.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.43 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725032256; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i+4o4v4tcr8rbwr78IwtuGgqIqaHJtCiQhKM2B3jmuI=; b=yJ3DV3ffYXD9MU7DMcS3/ZvItKoqWpANHfO3wlri7zGdpHc//aI1vwiO6OCKSojfTO1MPf E2pVsPrfCnb0lQJuq8mvUu/Mf//HnUF7MWFk3m8y4/Dt3BjcSBnKhT4l5aCIHCwZYQnCk4 50pz2TpPSYPeu6oIJO1LDayv8AdISuU= Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-26456710cfdso131410fac.0 for ; Fri, 30 Aug 2024 08:38:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1725032328; x=1725637128; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=i+4o4v4tcr8rbwr78IwtuGgqIqaHJtCiQhKM2B3jmuI=; b=MhwfO0VjFcYMgBSSpf5TUcoVNFi2MQYL2/8pwCKYBwpsENPMLzfHa6um+NiDCfbpD5 uUmMG5+tyJjlPZtKy9vRmV99BAVH1YSKLTxg5sxpjmluY2LB/XCUUZaTdJIvaA/Dco72 MtjxX+15eqaWt7wIAPnddl126Ho5RfYiWqIFI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725032328; x=1725637128; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i+4o4v4tcr8rbwr78IwtuGgqIqaHJtCiQhKM2B3jmuI=; b=XlcGF4+3N/K3So9Dohlx4AQrvx9fpyJouF9j/DL79Vo2N9gdXEd+ATX/Vbs0OFmGUu RJG6gXgoOPvonByTMz97CmxG6eDpawjtLv7NOYYZjpyjlCzsToHw+NGZztydYix33H/o 7pMjcBcG3OsxN5kBS5oplofIwGDw9fpmlZ8YbqlUORjbEbsdMBpRakOnAJ+p5EyxGv/a Fmy3DkA9FW4xVNEwH9pc/fQTzcE+0Lrt2DBum+PZnHK7nMLGoy6diNMr1g+igdyNL1r8 mJZURtlHi5yya3m9djUl/6JekGRao/1PzxvXQlp6kCVjkwNS2U5s6JrRQ5meBRwDBzzE 1c9g== X-Forwarded-Encrypted: i=1; AJvYcCVMqYn/42kbfZmxC0jiEp7JlT5MyUZFhyPCnRK0Cr575Yr7OlPSP+0woHGwLTRJPmi6u/Xs6kzhdA==@kvack.org X-Gm-Message-State: AOJu0Yxle3GE46S5daJTEoxPaPpicUb914Kf19araEqbGPv4GOKO4/SA CB4w3VYjfFY2oKU4vOVvrlBViMZLW5R0E1cOJtP7KI9eULrXZLPjkmmcCZUqlidY371RxnAF+f3 6TF2Lyx1xhrmdkVr86N/PUbnt8UQwIy/3/kQO X-Google-Smtp-Source: AGHT+IEJiQTBdvk8h4QsAYlys8jQM2wMdP6B97VqSR8AYorWSjmSCBIEgEV5VPy0sNLSBaQCDqVav2FFWC5OzTvuD20= X-Received: by 2002:a05:6870:218c:b0:277:6b90:1915 with SMTP id 586e51a60fabf-277b0e4fcc6mr1280261fac.9.1725032328307; Fri, 30 Aug 2024 08:38:48 -0700 (PDT) MIME-Version: 1.0 References: <20240829214352.963001-1-jeffxu@chromium.org> In-Reply-To: From: Jeff Xu Date: Fri, 30 Aug 2024 08:38:36 -0700 Message-ID: Subject: Re: [PATCH v2 0/4] Increase mseal test coverage To: Pedro Falcato Cc: akpm@linux-foundation.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, willy@infradead.org, lorenzo.stoakes@oracle.com, broonie@kernel.org, vbabka@suse.cz, Liam.Howlett@oracle.com, rientjes@google.com, keescook@chromium.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8A2E0140007 X-Stat-Signature: 7r9wrocdtaf4e88fbnk58e4wodwad7mt X-Rspam-User: X-HE-Tag: 1725032329-412064 X-HE-Meta: U2FsdGVkX18836ilVADs7MprrFv/aNYH2czmpEYJwf8qNAsdjuiKshxaDmBCyMTlLGvqmL2xyfeWg51/rzPPD+VSkTzzrNc45d8fRieWRM/s/fwTHlWM4WzFHH9x05VPw0+tU71pDeGcIXFR0kKLDcSrTPpxXG1NeoEZcowAHOJMsSOY9WDTBR405yIDw79hEtHAb4fZFS16cJ9Phjeg0vhjsJ9gYomTrR53xqjmemmhK/J8CD0bhIRbVzQSGwVPTXeVG3G00EWMHdr+hvhbiiufxWjJyElfSaZSMm5CqmyfK8GE5svfIfiySekMPoCj1ZYZeOrN6kShiZLmBzvOLRgyXWC+bYW5T4g1QwCP/koGjMBY3OLMbFoLQwWMRWa59UBXQlUWLiWxBClgMTOI4ImEOkRbYcCt6oy40JyWUQg7E1JA+UhqXdaqQLYwlmG50oliAtk2j584hAfJesQh23rke/WGzd1JY3r4JPB6Kjwi6cithnwQzElBy1zFnirvC4ArtAwX+zTU7fH9cP7o3UHju2oHfZxnHH5ZZr+NbvpxbjAuRd19JWqX0IUQJO4RopBkdXtWBvnbr8i5zPHA/H0lcM3QrR7V6OuAvLRrZMLvub/7emswEebbV83ZUp7blf2NOa75K24mU6F8imypoBJdlgtPumyXc6vs4onXBP9Za+cIfCDkzdDJ46LyrLq0ILp4OMoNu6bIW41KjeNgVYGrCU68LZgmqgjm4u0ORSXO5AqS8dQh8wCeOfhi+ORd7zMP80liJdHXFyxGFCYeuELXT2/3edr42wwAwYmrNjSZRkm60B/7ioVpzGN8MN+1XZRHOujdvilXHDLX5ZkyXWZjN+XFDRks2OghheJjKM0K/H4W66Pv/2Kl6osdk0jMxDPAkA8gMsnxbmmrqw0zNMU+ncUNJapVDxjjegO330Ezzbx2EakuGbpguXKkFdF3H/yrVDZS1FR5IM3PH1s YhQXLjDq pzBDlwUtuGcGBjrIHyfP5IC60C5i9AzGNjdClo2mdrq2dLQSe/mfGhNI3n7c7NEeFP0Hn0QWxfS843d0UZ4fGkAV5ADvOIa+e81lvkX287/0BNxwO/51TqvXstVpoAYo+m6pSIXw2IBeCVI1qSPMJpX/EzpsJ9k8VszCf0KNGBhznzI7Vh/2FAmO1etDSHP8ucf8oNH2TAywzTpKTnUbp79sXHOKKnY++0Z16ZcweMXY4NWCSg4uRGFeQxLJxkLO25qQOqf4DfDw5IFnjzOlL87UcVrZenKGeS8Q/wvqM/fsATCrc3X+zi8LCuZq73GxLMSJL8rkJ/pSqKZxWuzGi+Ff8tg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Pedro On Fri, Aug 30, 2024 at 5:31=E2=80=AFAM Pedro Falcato wrote: > > On Thu, Aug 29, 2024 at 09:43:48PM GMT, jeffxu@chromium.org wrote: > > From: Jeff Xu > > > > This series increase the test coverage of mseal_test by: > > > > Add check for vma_size, prot, and error code for existing tests. > > Add more testcases for madvise, munmap, mmap and mremap to cover > > sealing in different scenarios. > > > > The increase test coverage hopefully help to prevent future regression. > > It doesn't change any existing mm api's semantics, i.e. it will pass on > > linux main and 6.10 branch. > > I do want to be clear that we shouldn't confuse "test coverage" with bein= g unequivocally good > if it has the possibility to paint ourselves into an API corner where det= ails that should be left > unspecified are instead set in stone (e.g do we want to test how mprotect= behaves if it finds an msealed > vma midway? no, apart from the property that really matters in this case = (that sealed vmas remain untouched)). > I do not disagree with this. Let's look through code and comment on the case directly if there is such a case. Thanks. -Jeff > > > > Note: in order to pass this test in mm-unstable, mm-unstable must have > > Liam's fix on mmap [1] > > > > [1] https://lore.kernel.org/linux-kselftest/vyllxuh5xbqmaoyl2mselebij5o= x7cseekjcvl5gmzoxxwd2he@hxi4mpjanxzt/#t > > > > History: > > V2: > > - remove the mmap fix (Liam R. Howlett will fix it separately) > > - Add cover letter (Lorenzo Stoakes) > > - split the testcase for ease of review (Mark Brown) > > > > V1: > > - https://lore.kernel.org/linux-kselftest/20240828225522.684774-1-jeffx= u@chromium.org/ > > > > Jeff Xu (4): > > selftests/mm: mseal_test, add vma size check > > selftests/mm: mseal_test add sealed madvise type > > selftests/mm: mseal_test add more tests for mmap > > selftests/mm: mseal_test add more tests for mremap > > > > nit: Please follow a more standard commit naming scheme like > selftests/mm: > or > selftests/mseal: > > -- > Pedro