* build error at mm_unstable shmem.c: undefined reference to `vma_thp_gfp_mask')
@ 2024-08-28 17:48 ` Jeff Xu
2024-08-28 18:54 ` Daniel Gomez
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Xu @ 2024-08-28 17:48 UTC (permalink / raw)
To: Andrew Morton, hughd, Baolin Wang, da.gomez, Ryan Roberts, linux-mm
Hi,
When I enlist to mm_unstable branch, there is a build error:
ld: vmlinux.o: in function `shmem_swapin_folio':
shmem.c:(.text+0x21b5d5): undefined reference to `vma_thp_gfp_mask'
make[2]: *** [scripts/Makefile.vmlinux:34: vmlinux] Error 1
make[1]: *** [/usr/local/google/home/jeffxu/mm/Makefile:1156: vmlinux] Error 2
make: *** [Makefile:224: __sub-make] Error 2
And it is fixed by adding CONFIG_TRANSPARENT_HUGEPAGE to .config
Is there a recent change in shmem.c and adding this dependency ?
Maybe updating Kconfig or adding an ifdef ?
Thanks
Best Regards
-Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: build error at mm_unstable shmem.c: undefined reference to `vma_thp_gfp_mask')
2024-08-28 17:48 ` build error at mm_unstable shmem.c: undefined reference to `vma_thp_gfp_mask') Jeff Xu
@ 2024-08-28 18:54 ` Daniel Gomez
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Gomez @ 2024-08-28 18:54 UTC (permalink / raw)
To: Jeff Xu; +Cc: Andrew Morton, hughd, Baolin Wang, Ryan Roberts, linux-mm
On Wed, Aug 28, 2024 at 10:48:01AM -0700, Jeff Xu wrote:
> Hi,
>
> When I enlist to mm_unstable branch, there is a build error:
>
> ld: vmlinux.o: in function `shmem_swapin_folio':
> shmem.c:(.text+0x21b5d5): undefined reference to `vma_thp_gfp_mask'
> make[2]: *** [scripts/Makefile.vmlinux:34: vmlinux] Error 1
> make[1]: *** [/usr/local/google/home/jeffxu/mm/Makefile:1156: vmlinux] Error 2
> make: *** [Makefile:224: __sub-make] Error 2
>
> And it is fixed by adding CONFIG_TRANSPARENT_HUGEPAGE to .config
>
> Is there a recent change in shmem.c and adding this dependency ?
> Maybe updating Kconfig or adding an ifdef ?
This was reported by SeongJae Park already. And Baolin provided a hunk [1].
[1]
https://lore.kernel.org/all/8c03467c-63b2-43b4-9851-222d4188725c@linux.alibaba.com/
Daniel
>
> Thanks
> Best Regards
> -Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-28 18:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20240828174816eucas1p219acb6d2665cc869ae403703e5aa9322@eucas1p2.samsung.com>
2024-08-28 17:48 ` build error at mm_unstable shmem.c: undefined reference to `vma_thp_gfp_mask') Jeff Xu
2024-08-28 18:54 ` Daniel Gomez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox