From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62B1BC83F2D for ; Thu, 29 Aug 2024 14:34:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F12596B008A; Thu, 29 Aug 2024 10:34:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC19A6B0092; Thu, 29 Aug 2024 10:34:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8AA06B0096; Thu, 29 Aug 2024 10:34:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B82B16B008A for ; Thu, 29 Aug 2024 10:34:48 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 725854065C for ; Thu, 29 Aug 2024 14:34:48 +0000 (UTC) X-FDA: 82505529456.28.3FD5FCB Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) by imf15.hostedemail.com (Postfix) with ESMTP id AB916A0038 for ; Thu, 29 Aug 2024 14:34:46 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="MHiBWS/8"; spf=pass (imf15.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.46 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724941998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yJvOS0jrrStCn1p3egyXOQWxbnH6JNr9A1VShqqaYTk=; b=MRdtUXJqng7rLAwEPz7s4CxNJhUsDMpiRtV12q4KxKqphypkU6M7YAbyRwIgB4D6hiANue 6xvXWp9XGVpz9aDqNwWhggjkFI79AUT/ZnGLsq5krKedjHazucPHpGrjOLblbwaNXxXqXW kmiaOKQ/VFIE6vDpFsa05ZEob8e4Qg8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724941998; a=rsa-sha256; cv=none; b=xja06bmJqMQUoENaodbEUz9afIPWBUVhX2jjSWFX44vYN7jBPP9bicDxqFwej9xfgXf92Y 8f4pz7lIPwn7d5XL5Uzg40eU7koJlZ5G0i7dbA7crVjZoEtkWBVBwF1sgppDVag6agp4U4 MlzcCibl9higTa3V03qY7F7/+eocvZA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="MHiBWS/8"; spf=pass (imf15.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.46 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-26ffc596adaso77212fac.1 for ; Thu, 29 Aug 2024 07:34:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1724942086; x=1725546886; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yJvOS0jrrStCn1p3egyXOQWxbnH6JNr9A1VShqqaYTk=; b=MHiBWS/8cAaOi/J0UpfSAlaEC7xEdZHGfyYtPjr4bFPyYTVWjElJkFD8QZ/37gvHdZ ap8enrZ37bjdYnmk8FGaACOc5mZTql805pvwGIxxMK+GRFtet8sSHkqBBNqGh0X+Pcft HLCZwM+GII3E/wxtqlkeGfhV0kZgR7MgypBnI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724942086; x=1725546886; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yJvOS0jrrStCn1p3egyXOQWxbnH6JNr9A1VShqqaYTk=; b=V3XC1UDx+MO65tdWckqw1HfjXZg4vn9UU6V7Vzt/yUeKsvrfeHaW+2oAnp22vvWJiF 4vL0z1Oow6po6zidaCYJ6VhaewtRPkhrG156LNJ7y82y2sQFa3UnaqMK3IerC1XCKo1c qhENIxlwhlF/PlNdGUQ8oWGrj4eLu2JHwC2pyXyPrYw7+XMk9O50sOZQ0AMAMHvFtDtv QmzNbCixnYKKn+tDqSeDvSFP/pgeYaFtkw+YiH8f2qR3CtRADF2l6+2KO0CAzONhFbqh Y5RRflDTuUImOX3x8/Fc5bVZwud7U0RYdfjnIFpOvWIBOWh3Y3qd8jS4xAb+GRtUeFrC RCzg== X-Forwarded-Encrypted: i=1; AJvYcCXUI7bgihlBjquSyOYZzp8YSNgUhrnPmyr692mqIqIbL/R4QGacKACcIotU9RnYu74L/t2xUMaXWg==@kvack.org X-Gm-Message-State: AOJu0YzxtHio/Doz4eGvGGFNyFPjrCv1D86Sz+J/Viy/rMPGs32T0WFe QCN78hqsh/GaghADD6+/HlpdY3BvYhSzSdvMyB8/XxhFcyG6+2XtSGioPN4qSi3BiquvM70jicf ill/pDwgxTGOSbgyzZTySYVJIRe0rlHWBZ8az X-Google-Smtp-Source: AGHT+IF9LGbiJFVqc1DMjTkah3A1+IPMe1eJBsBwTEaX1TwXJ7fiM5f3el5JFuGiTRRorOR2mHIY3H7LZkeJi5v8rJM= X-Received: by 2002:a05:6870:d623:b0:260:23eb:5669 with SMTP id 586e51a60fabf-2779007fb72mr1759062fac.2.1724942085649; Thu, 29 Aug 2024 07:34:45 -0700 (PDT) MIME-Version: 1.0 References: <20240828225522.684774-1-jeffxu@chromium.org> <58e47a2e-6556-4a41-9fe5-1378f5257534@lucifer.local> In-Reply-To: <58e47a2e-6556-4a41-9fe5-1378f5257534@lucifer.local> From: Jeff Xu Date: Thu, 29 Aug 2024 07:34:33 -0700 Message-ID: Subject: Re: [PATCH v1 1/2] mseal: fix mmap(FIXED) error code. To: Lorenzo Stoakes Cc: akpm@linux-foundation.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, pedro.falcato@gmail.com, rientjes@google.com, keescook@chromium.org, Liam Howlett , vbabka@suse.cz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: AB916A0038 X-Stat-Signature: 6hgoff1pc8zcd5bhfyi1u5gxdz8xxwod X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1724942086-721084 X-HE-Meta: U2FsdGVkX1+MI9iJkAHZTYxW09ufEqMh+4jvify3ZUjV1lXpJLKHmzpOd5cELczyUHTTt9IzM4qgu+oKVUJIMnuLn0MpDoinl39QXzIFkm0XOVTpPI8obHWWr+E6yVGhLtOvQkK7bf9fEyziZ5/EPVb5tRNqhY2pvJqx/qG/upukwtBaKweJUPEiTFup5bDOHYbSzr2aD0OVAoO+FucMkQsO+nhT0rI31J7fuo+5Ih0ApaMkA9M+5csKgv+9UQwsGyxryUDpOttiUnfy21p1ccc5+iXyRtYxmnfMh5CzyBeUpeQBQLlYHEAhwNA4be6ajKo9+d6eRxfVL1kv3gRq56MsGsiPCa+R0VnO3JtofEV4o7ecUHWJdzpoAcRtQragdD8SqX143CpmWV+QJYmxdgmXiKzaf5iqEvjTyAGtvQsJnRknuaDwVY/bwB/b8ifT4tSU/+LOFN+yEhJEO0B720aWpW9GVWJjKpgaVKycxt96g2TrziDtJByBr+PXc6UfY8DvkbRYj14HUDFvsQ7CIC9iqfx8oM83uO/bxKYYx1gsdQ0r+ERzSHVvn6EoPvDsjHI9LBhc8G7UlTqmOef5m9D00skFYW5ydKncIBJlibKFa5Tan+lU+usAEhzjPIbX2G8pS19rHMxds0o4aQCs7LcIcWVhDmNRwiWq+fRKcjWh0xTpFixTjw6Wcnm0x6LRve2xBxO42hMx6GveKOPMo6/RjK6+rrMu++STHHB/OMPJ6DWh1DasVHlMe0LQiYmmoU5qqqi4Vn1mmGgULSe9ZMwsysk8qfKS1i126F6Z3m7JAHeUrJC5qbc1WIfq+9Oh43+Jaa8s8LC7naVHtAh/ot2DI8UaLcr3SZkbU0mle8HKO6gLoZvQfyAEF96ENnXOz5j6NvM6vSCzi8bLCQe3UTrOzVufXegnPYrie15/c2yTzXo4wRVYYyploLu88dOf6bSonKItgQNpuzbUyBc gA/aBBdU ny8oguMRdZsAtYscId7y2n74Fxb3441sEdh6CMdAe5Zh+hBidPQSVuGLLauSirZXM6k/zzWLZNSU86Nbk0T94gisleN9WUcKCr/w2L1UlUdFiXouEfAgHEWQsV0Z7sKQJtoUGWs7KxtHRDEgmQTL+ZSCO6au8UqRm/RHpMgZpeFUW0HWgm+SgrCMRyfDWMVYmDweW7Jy7rVBX7vZUm5uX4+NaP01bYgsrXh53KPDFJdxKyWrDcLNFPwF9onB/IT+QR2Az1KGj7vNR7hVVA5+Dw2lW0r3jYJNBQ0Ym3QsLydPK7Ub2F30ErRz0oAfBO3SE+5AApNJ3n3S7wCxeQpMNnUW8Zml7p8a+b9mtZEvNN3PeWSR00qfrPK1JFdY5VP0HpUVbwdScBIBveAGzK3/Wotch/RuNLuBV5wPvwuZTL228bi11qw+0Qz5fn9/RyC6adYCUj7zSXVvoksPeGmSbkTGnGmAU3jqjkAu5m3dO1qvgDUecg//AKgpvHOrmyPMdHqep3m2LrynVFZmcNsUWn0Dlaj0PQY8A3SDyT6lxP/h3aBBQ0/IKfBDStA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 29, 2024 at 5:09=E2=80=AFAM Lorenzo Stoakes wrote: > > Jeff... come on now. > > Please cc- the reviewers of mm/mmap.c on these patches - that's me, > Vlastimil and Liam. Same for mm/vma.c, mm/vma.h, mm/vma_internal.h. > sure, that was a small fix and I thought introduced by Pedro's commit (which was wrong) > And it seems like it should be pretty obvious you should cc- Liam when it= 's > quite literally his code you're changing! > > Relevant section from MAINTAINERS: > > MEMORY MAPPING > M: Andrew Morton > R: Liam R. Howlett > R: Vlastimil Babka > R: Lorenzo Stoakes > L: linux-mm@kvack.org > S: Maintained > W: http://www.linux-mm.org > T: git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm > F: mm/mmap.c > > On Wed, Aug 28, 2024 at 10:55:21PM GMT, jeffxu@chromium.org wrote: > > From: Jeff Xu > > > > mmap(MAP_FIXED) should return EPERM when memory is sealed. > > > > Fixes: 4205a39e06da ("mm/munmap: replace can_modify_mm with can_modify_= vma") > > Signed-off-by: Jeff Xu > > --- > > mm/mmap.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/mm/mmap.c b/mm/mmap.c > > index 80d70ed099cf..0cd0c0ef03c7 100644 > > --- a/mm/mmap.c > > +++ b/mm/mmap.c > > @@ -1386,7 +1386,10 @@ unsigned long mmap_region(struct file *file, uns= igned long addr, > > mt_on_stack(mt_detach); > > mas_init(&mas_detach, &mt_detach, /* addr =3D */ 0); > > /* Prepare to unmap any existing mapping in the area */ > > - if (vms_gather_munmap_vmas(&vms, &mas_detach)) > > + error =3D vms_gather_munmap_vmas(&vms, &mas_detach); > > + if (error =3D=3D -EPERM) > > + return -EPERM; > > + if (error) > > return -ENOMEM; > > Can't we just return the error here? > > This is one for Liam, but I'm ostensibly in favour, this does seem valid! > > > > > vmg.next =3D vms.next; > > -- > > 2.46.0.295.g3b9ea8a38a-goog > >