From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 479CAE77173 for ; Fri, 6 Dec 2024 16:17:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C44CB6B0199; Fri, 6 Dec 2024 11:17:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BF3306B019E; Fri, 6 Dec 2024 11:17:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABB696B019F; Fri, 6 Dec 2024 11:17:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8DD996B0199 for ; Fri, 6 Dec 2024 11:17:55 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 38B73141802 for ; Fri, 6 Dec 2024 16:17:55 +0000 (UTC) X-FDA: 82865039922.21.935A3E9 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by imf20.hostedemail.com (Postfix) with ESMTP id F16411C0006 for ; Fri, 6 Dec 2024 16:17:34 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=bn23q6YI; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf20.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.210.43 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733501865; a=rsa-sha256; cv=none; b=sUGJDHwDlpYbIxqwO0vJyc4vVPyJLe5tHj6VaMK7D+89Iid9MVbxX0JemSQNZbd2ycoxIg AcU538Efi9jxj3VNfHpis8+5gbuHG0tl3guSNuderwD4fOTGCN+H7QDrDJk/QwaSafqqvL MNitSGibGSG61JfRZxMFfRP4eEN9hyc= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=bn23q6YI; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf20.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.210.43 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733501865; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FYNgFZy/4/b6RmhVrXOEIxOyzv8j9mBXffJS69QvJeY=; b=A/KZSdaiKU6tFcBEktQlRt6dPE1r4Lay43c3TJbn0XUrJNgSbvXRwIUyoRuK2BplTKq84B qO0432GPI6mgWAUKCy90YZ35MozjO115pYCvzqU5j05CFuMgv/ShaJKy+zohw1CYQ2Obk2 dR9gFxipYi5p9wT4c/tS6cwSMYdmxwA= Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-71d5235317cso335264a34.1 for ; Fri, 06 Dec 2024 08:17:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733501872; x=1734106672; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FYNgFZy/4/b6RmhVrXOEIxOyzv8j9mBXffJS69QvJeY=; b=bn23q6YIapx+GrFsUNWpXPB0MrrSognsSNWEqFJ94oOxPijO1hwaqoiNtWYApQAuO9 s+ykULpQ0woDzHnNSvKrCHeTUb5+XHP4tddcaAwvb8SyCuHe5iI06QzV0fCSZuvluPXk rXah9BTOgyncK9Whnc+8oKWvp6lIdRk8Z6S+w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733501872; x=1734106672; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FYNgFZy/4/b6RmhVrXOEIxOyzv8j9mBXffJS69QvJeY=; b=nRclDxxmpLKstvK6yRmm2YlfFZCkszKQroNuBrwwbiSMc3cR6nAm18FmSfvpdqk3Nk E5LRktcD4lyBCn4P3pMePOaqQfFSSZKWIJQp9ZjoNQXzZn9CTfuezQM0edoZMfj2nQSI 4aLN4DGQSWZ3eA6kCfQ7fTkVn4JzkcGRuX/nGxYYghXGblcjGFPNoxPgNyWW3tsYpNz5 3hG/9tzWlGczT/MTKz//Xw5KuokaJGkG4GthuVshavj7rHkPPx1uS+8HoZD7liD4h0Wm 95RrVcCEpAoyiMVM2QjnDkWdUbqTPjEjCfGcUFd+bA5/zHlbas0dim5oJuwIQT//xpHi KcjA== X-Forwarded-Encrypted: i=1; AJvYcCWlhnxjrH8upz/wlZILBRdzVNhPVLYmFlVSRq1pFu+qfqsHrWdSfVGXl85nWsGtf6PKvObJU8TAXw==@kvack.org X-Gm-Message-State: AOJu0YzMIWpxB3UwuM6df9QkUGnMdqHmN7aBYZgNYgTWFPi9rFtsd9Lj KnoZSHdsbne0j4agmZZbvK5kBURVXO7SRGfcUgTp6uD7Er41hwJxelY/W9t689lD4McJH+dfqra hg8EYVYxUJblZDprIX2hprpygvqXfAdbP0IXU X-Gm-Gg: ASbGnctZc2DJTKdtE15wmarwBWyvb+Ay+q6rc+Ek7QqumZ822+ucvEcqyVxhjO9jZvp +f8UL1AnSXboL2dxVYEJ4AgBTMQEo5HFy92LFFXEDbU/9CrnEFGJuiRQ2TPiIG+bh X-Google-Smtp-Source: AGHT+IHRb8erTdDUQTrHJbU0fhtYuKrytZ0PMTCzeH2gffX33C2JMd95VcEBOKpmWKnjXeUJ/vtlcF6fm2BIbgdb3Fs= X-Received: by 2002:a05:6830:d0b:b0:71a:20da:f85f with SMTP id 46e09a7af769-71dcf5c2a07mr815871a34.7.1733501872216; Fri, 06 Dec 2024 08:17:52 -0800 (PST) MIME-Version: 1.0 References: <20241206013934.2782793-1-jeffxu@google.com> <2m3zmlehfigs5r7rptwcoft3j4fipfkgfxmdrdttpf76hwhwae@vclfa5ulcmv2> In-Reply-To: From: Jeff Xu Date: Fri, 6 Dec 2024 08:17:40 -0800 Message-ID: Subject: Re: [PATCH v1] mseal: move can_do_mseal to mseal.c To: Lorenzo Stoakes Cc: "Liam R. Howlett" , akpm@linux-foundation.org, vbabka@suse.cz, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, keescook@chromium.org, pedro.falcato@gmail.com, rdunlap@infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: F16411C0006 X-Stat-Signature: dkcpxqrrbqkqwssxch7hqabyr3mnukqd X-HE-Tag: 1733501854-16689 X-HE-Meta: U2FsdGVkX19U7jkHhsLcpWBZIoJLJ+4S8tOT9I5RvOzsCJRjq1tj/yGg92GhLEMG7ar33ld1J+OEOVxSyLc9u74LXaYToOqXptsqgxOEKWgSEQ/EExsvqW4uFU8h6LGlHuoxpJgFE14bZzJ5RSdfGKvAPZd2k5GPq/9tXDgsMtS97oatt5z1+Hu1ayYGgTM53KWnNDgZS7k4x/aK6YdTrf9KySwoIFzCwaeLurJC3m2hSBjIls2c0wtHcqh2N7Av7/AhR2737q4K/I9IpIVW2d+Fu1+jzWwbf/ciScT6WzfTxePOVZLS2d7V4AwFZagNmyvj/s85/qJ240Nle7cyFbdPEzvYT3UtVN3tdos0iYx6/6rmKMy+KuUH8qbTtn7/4DnBwroxt6OWqJiaQ0W7xGR1AvMekqY7CJan8R8VeZWF9GVwOLHxyu83uklVx3uU1ip4mVmtGPETQyuA0ANGxoz4zCNivzqeJ08rLqZ3POf66lP/Pb9kCftVV+14So2CtNSrnkjxK87BI+VuI7+c7P3wAqzv5/xZtCe5mPnaV2987u/blCSp0bqvDyWIDWznlM307ciiVyxgmjXXYavyToKe53KLLnacQduMZjLWqjBaLU8lFaIG+IVkni674ibj1Q10l5wpJ+hgUg58UM0msqLvi7K2YRbh5NF+ZVFst8JDrMs03nVzusN2h+xGLR4mPi7K0csAcbrgExiDw7e7FVrchhv0YQ0rtEbaYO/C0Edpe+zhDaReDFCKMFKgHSAhqiFYrdW0pQ+GnQ2o8RlctQeF51RyHjKE49+BUtxYJCJVZkuaJbsnL0r3e9Q64lzo8V5z0yxe4etg4jYeUfxD+reDlSpoaDG63J4PsYZ8CWrZck+05YW0S+cWY28jJcsB1hhPFOr912mfJVewV5060kIfhsPXBDtsRTR48UvC3qrxOCR4rqVZtR6h3wjX2KQbO77H8BxjrU9/qLyQ4aZ toWXi4x5 IKlSAp+JwedcKCxLdlNiAWQ2owsqXXhGSG9GcZ9IGRG7t8KXeIRxmPvLHiAyKsB5HIHNzYRxAxae4OSHlRBVRknaY846bxc86xDIbhmZDMRaAwNxswv8oVXIJM7bqhOHBMCZyzC1mFZH5dD0iRnxfqirRiV//pBnxvX8DIlF+BQlEIyiASVm+JsElKnp2atbuf2l53dCHaC1co7ADa8U2bAe3EGyTuhx01GlQE39kIb/pQi2RwMsudVOuTFON30kUmah6P3ujyVHsO3eDNP5AleMN16pLenUHbhRBArymFREAlDpXA73sLKo6oUnj6nRESzhaLXRBjRqAgvoy/p//GnydrP5GdQza6TRytE9U0WqEUW0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 6, 2024 at 1:13=E2=80=AFAM Lorenzo Stoakes wrote: > > On Thu, Dec 05, 2024 at 11:25:43PM -0500, Liam R. Howlett wrote: > > * jeffxu@chromium.org [241205 20:39]: > > > From: Jeff Xu > > > > > > No code logic change. > > > > > > can_do_mseal is called exclusively by mseal.c, > > > and mseal.c is compiled only when CONFIG_64BIT flag is > > > set in makefile. Therefore, it is unnecessary to have > > > 32 bit stub function in the header file. > > > > There is no reason to keep this function at all; it is used in one > > place, and that place uses three lines of code as well. > > > > In fact, having it separate from the comment about flags being reserved > > makes the function very puzzling. > > I entirely agree. Jeff - please just make this inline to do_mseal(): > Sure. > ... > > /* Flags are reserved. */ > if (flags) > retrun -EINVAL; > > ... > > If you do that then cool I'm happy for this patch to be taken. > > An aside - I actually think we need to move the bulk of this code to > mm/vma.c - it makes absolutely no sense to keep the internals in this fil= e, > and that way we can userland test mseal functionality. > Is there a past discussion to read ? That will help me understand your strategy of unit testing mm code. Moving everything to vma.c, will lose log history, e.g. blame no longer helps, did we consider alternatives ? > I may submit a patch to this effect at some point. > > Thanks, Lorenzo > > > > > > > > > Signed-off-by: Jeff Xu > > > --- > > > mm/internal.h | 16 ---------------- > > > mm/mseal.c | 8 ++++++++ > > > 2 files changed, 8 insertions(+), 16 deletions(-) > > > > > > diff --git a/mm/internal.h b/mm/internal.h > > > index 74dc1c48fa31..5e4ef5ce9c0a 100644 > > > --- a/mm/internal.h > > > +++ b/mm/internal.h > > > @@ -1457,22 +1457,6 @@ void __meminit __init_single_page(struct page = *page, unsigned long pfn, > > > unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup= *memcg, > > > int priority); > > > > > > -#ifdef CONFIG_64BIT > > > -static inline int can_do_mseal(unsigned long flags) > > > -{ > > > - if (flags) > > > - return -EINVAL; > > > - > > > - return 0; > > > -} > > > - > > > -#else > > > -static inline int can_do_mseal(unsigned long flags) > > > -{ > > > - return -EPERM; > > > -} > > > -#endif > > > - > > > #ifdef CONFIG_SHRINKER_DEBUG > > > static inline __printf(2, 0) int shrinker_debugfs_name_alloc( > > > struct shrinker *shrinker, const char *fmt, va_li= st ap) > > > diff --git a/mm/mseal.c b/mm/mseal.c > > > index 81d6e980e8a9..e167220a0bf0 100644 > > > --- a/mm/mseal.c > > > +++ b/mm/mseal.c > > > @@ -158,6 +158,14 @@ static int apply_mm_seal(unsigned long start, un= signed long end) > > > return 0; > > > } > > > > > > +static inline int can_do_mseal(unsigned long flags) > > It makes no sense for this to be inline. > > > > +{ > > > + if (flags) > > > + return -EINVAL; > > > + > > > + return 0; > > > +} > > > + > > > /* > > > * mseal(2) seals the VM's meta data from > > > * selected syscalls. > > > -- > > > 2.47.0.338.g60cca15819-goog > > >