From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23EE6D78339 for ; Mon, 2 Dec 2024 17:22:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F29E6B007B; Mon, 2 Dec 2024 12:22:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A2756B0083; Mon, 2 Dec 2024 12:22:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56AD96B0085; Mon, 2 Dec 2024 12:22:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 393AD6B007B for ; Mon, 2 Dec 2024 12:22:48 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D67D2160169 for ; Mon, 2 Dec 2024 17:22:47 +0000 (UTC) X-FDA: 82850688270.07.7DE1626 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) by imf23.hostedemail.com (Postfix) with ESMTP id CF3EA14001A for ; Mon, 2 Dec 2024 17:22:37 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Bz6QPCY9; spf=pass (imf23.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.210.46 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733160160; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0EuSF+5mXGQ+p/ElofT+6RULxRWulOZ82YnMW//ltyo=; b=7S/Lfg+eKD89grcPSBCx0yz+1KGFLJyKfhmA6FzIAe9yhwtrz5tvDqmYytH+EDh3WQ7v8D vx76e4UOALnYqbreKP2WgZTF+rziB0zVeuaj8YqsHelCdIu+WY5q9mQEz5HOMHhEnjdjsg lmc6cUPpLEEOStzsGYAXSYhfYJtzN2s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733160160; a=rsa-sha256; cv=none; b=LXlYmngmJOO7AuFguf/MGylSarWw58db6xySr36lIWRLpksX/rA28eloS8pcNxD/AyerLZ 8OM4KzgsQBvQjYnCzucIeTrq9Us8TVwY1ngKqrff3p7js0vUvDSToMZXrdhzDB8ZbWtVF6 t7iVHsAcZjCndjfiHWdrx34/7f4QUSc= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Bz6QPCY9; spf=pass (imf23.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.210.46 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-71d505aa9edso436083a34.0 for ; Mon, 02 Dec 2024 09:22:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733160165; x=1733764965; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0EuSF+5mXGQ+p/ElofT+6RULxRWulOZ82YnMW//ltyo=; b=Bz6QPCY9XE6P40X8GA8jtdBmENP2lUB5QV3DAaL9dm3T2xvWRTj1oAmnSoGh2Ivqs4 XfQiGTXq5hCFJlaq9ctGMxv0qIKlqrvrC3LRzmHp6KxtcqmkbaT4QIrCi6Fcc7M/YmQj O7GF61mk8M0cOvw/rv6nkCYeNLMMYl1TN+9HY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733160165; x=1733764965; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0EuSF+5mXGQ+p/ElofT+6RULxRWulOZ82YnMW//ltyo=; b=qhUsqgZ1p7z9w7l7mPhQAiO/TfbMLlj/GemNuB+N5j6xXWfTTSD7iNhmBjsPDAo5Wl 480EIfodkziMQpfFVfwKAqGIs0lhtAXUTdDeG0/IEE+5O8/r17tYVlVK5FReEe5EHWoT NBukGf7zp1eTloQYqDBAvvNZla14dhIeLSUrXut3JEYF1pTicSQgx3z5CaubgNTWrJpm 6zNKuMo9PjSRIDjMT6zt8NeXebrK4Xeob61XIgY/wt+Fqf51UhN80+jks1wSIpw7sQpT Tq+fjRxCNgtoHqrJMm6BWx8dfJyIA8AjqkM27eTRwHVyCKtnsqLHwJlYgRknN+5IW13T 5gtw== X-Forwarded-Encrypted: i=1; AJvYcCVAKEFZ2dzYJtLRrnEwekKJMq0ecmOMYhl5usFu68RA7QZaK/9RdRJUlQaNEM9+mOA/jdQ+47pPYA==@kvack.org X-Gm-Message-State: AOJu0YwhzJrnEX8KOxKjmhbr/M+/3CRRiry8pgIqsnmrWb7gxNeaVau5 y61bJoTIh/k4pFMiwwGthIZ85zqxcw1nXpG5AKwNqk9SfMQyDAYkZ3hE+LYBAIAHgWKVPfNgRq9 LMiM4ZbPKq7eYt92w467Uc+9ezPn3o3vjVHuE X-Gm-Gg: ASbGncuq3IgGL6rvGomU1D0vsniDMfNKFFl29Iw3zvqDWIoD1ANpwxOrYpWcEzRiScj DIiza88laLBrcedMSmlKK9Dn6a2kCsrEfwWtOdcpJ988xysFkqJjJbuEQ00RT X-Google-Smtp-Source: AGHT+IG3sLYTMxv9zJvhrV40tQEdad/MSdMn1EYDNRgUNjyGpXvRxgNUgrByjfFZ0L91mLSgiaejCm8Ap+1hflJhmrU= X-Received: by 2002:a05:6830:926:b0:710:f7b0:1d9f with SMTP id 46e09a7af769-71d65d2ebd7mr4962644a34.7.1733160164868; Mon, 02 Dec 2024 09:22:44 -0800 (PST) MIME-Version: 1.0 References: <20241125202021.3684919-1-jeffxu@google.com> <20241125202021.3684919-2-jeffxu@google.com> In-Reply-To: From: Jeff Xu Date: Mon, 2 Dec 2024 09:22:33 -0800 Message-ID: Subject: Re: [PATCH v4 1/1] exec: seal system mappings To: Matthew Wilcox Cc: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, torvalds@linux-foundation.org, adhemerval.zanella@linaro.org, oleg@redhat.com, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, sroettger@google.com, ojeda@kernel.org, adobriyan@gmail.com, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, hch@lst.de, peterx@redhat.com, hca@linux.ibm.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, Liam.Howlett@oracle.com, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, mpe@ellerman.id.au Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: CF3EA14001A X-Stat-Signature: 3srxyxbpwgujcxszphmhqm37xdmq8b38 X-Rspam-User: X-HE-Tag: 1733160157-4205 X-HE-Meta: U2FsdGVkX1+ZPdldPmnFobgzMdrDrkj7sj06Au4HPNyFHTIuTeeU341t4Hhiv3qK6Eziz/KUIxnnbwem7dE0/srWmidQzuIxBaMQuB615neY/2FUwciB528Ntj0P+SRl13khKnKYPYFtYTeg6u4KvdpX7myXpXnRbaZAVBLgsY74cE7SMdlWOXz8uu3Ro9FFbUgg47AdUXLT3L5RA1XvMDD/UB2AmeryHC8tCOEZCGY92HYthApP/Ovf6c+0BXWBpTWZ9G1vqOtvNEKOw2DO0rnSWhly+r4HxJFm6MGRsu56YBI6l6sgvl9LxRtcLL1giwVbR838hFptwCTFVFTfissA4cedJy75NfnFLS9pcOoQ2ygoCuhvJQj/q+NGyQ1d3UpYDuxIzZBz/VNQzXgwCf0yC6g5V01PH08HgqrFZ+YTnrCTerteenbst3hn8/r/g6nQJ4cEWc+LKplFWSPLD+Nucipn2xHEqGXx66RZdj8tRvk/WdXEtq3fOau0qxAuT8N7VsFcnWu7kzAaNUHJ4DtpR8YrBwgty+MvtpQ5IUOCtHGB9Zrl9Kt5DYQmj38CEJYHlbDajZm4VWB7ebNlR4krXpvVyQ8K3rUJQzDD7V6TsA9tizT503PRlJezVA0vEqAb0w4oO7zpCSrfIppkUW/NEAVtSxdM22ljMJgCQ2u+DB7sZWB5tt82bgl8Nx2xz7e+Ck9ME2vNXUiCfJQsYkt+FHLyI15uybCMyFlzQGdXTxhmvgbqOv/Ayo7NExVzRQgllTrqgURj3JsaVr3U+DOTuC+uYO+VhakLII+Vj/nlghn0dp7tB1Iej0aOvlEv5AaR9EsL/kqQ8V65KaALQCoY3y/qPWtsS7wAN6lfvU4ZG4mv8PDumyly8epRYrrDXFdpQgNGakaXmy8BVBxIm8daChhXEj6THdwNfPkUc50iVES49hZyMtZiAommmagLC6M5fIH0Y7XehqU4H5r 553TG9/R zMBUoTqyigxdcYL/E9A2fRt8ExWK7ljaRu2WLI9S93lquD4FWY72So6anTzg9RKeD5h6AFfAihdcsGKuYl+M4h51PWFU3o676VfH8GQIzGq8jaHZu0wU7R9pvEu0rELGtoEFwod7eIcm2e/r+D8bqBHMqbND6AONL7H82g49D1/0TtISOgcQ8BDDyfyYKQJWX94k2LD4XXXK9VxJdywVAW2oDhFYuE+pw7xfl4cUkQFLThZoaUnxhPFP9scVTupBsE4SowHzieQs+A7LlZJFPnnpyqag4NjgB9Hk59ADNNDZG9sZgCyIlEG7HDwJgZttJZHJFbVjWT+CDhzyKsCfSLMp8J7M70nmgJW+x+N4IUo7lVjW7c4TX49DU90bzHh/xngXPE4xEr4KafgQ8bLlWkSvUapLrKSiBh4j+HViqa4oXu0CaJceMTlc5yw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000027, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 25, 2024 at 12:40=E2=80=AFPM Matthew Wilcox wrote: > > On Mon, Nov 25, 2024 at 08:20:21PM +0000, jeffxu@chromium.org wrote: > > +/* > > + * Kernel cmdline override for CONFIG_SEAL_SYSTEM_MAPPINGS > > + */ > > +enum seal_system_mappings_type { > > + SEAL_SYSTEM_MAPPINGS_DISABLED, > > + SEAL_SYSTEM_MAPPINGS_ENABLED > > +}; > > + > > +static enum seal_system_mappings_type seal_system_mappings_v __ro_afte= r_init =3D > > + IS_ENABLED(CONFIG_SEAL_SYSTEM_MAPPINGS) ? SEAL_SYSTEM_MAPPINGS_EN= ABLED : > > + SEAL_SYSTEM_MAPPINGS_DISABLED; > > + > > +static const struct constant_table value_table_sys_mapping[] __initcon= st =3D { > > + { "no", SEAL_SYSTEM_MAPPINGS_DISABLED}, > > + { "yes", SEAL_SYSTEM_MAPPINGS_ENABLED}, > > + { } > > +}; > > + > > +static int __init early_seal_system_mappings_override(char *buf) > > +{ > > + if (!buf) > > + return -EINVAL; > > + > > + seal_system_mappings_v =3D lookup_constant(value_table_sys_mappin= g, > > + buf, seal_system_mappings_v); > > + return 0; > > +} > > + > > +early_param("exec.seal_system_mappings", early_seal_system_mappings_ov= erride); > > Are you paid by the line? > This all seems ridiculously overcomplicated. > Look at (first example I found) kgdbwait: > The example you provided doesn't seem to support the kernel cmd-line ? > static int __init opt_kgdb_wait(char *str) > { > kgdb_break_asap =3D 1; > > kdb_init(KDB_INIT_EARLY); > if (kgdb_io_module_registered && > IS_ENABLED(CONFIG_ARCH_HAS_EARLY_DEBUG)) > kgdb_initial_breakpoint(); > > return 0; > } > early_param("kgdbwait", opt_kgdb_wait); > There is an existing pattern of supporting kernel cmd line + KCONFIG which I followed [1], IMO, this fits this user-case really well, if you have a better example, I'm happy to look. [1] https://lore.kernel.org/lkml/20240802080225.89408-1-adrian.ratiu@collab= ora.com/ > I don't understand why you've created a new 'exec' namespace, and why > this feature fits in 'exec'. That seems like an implementation detail. > I'd lose the "exec." prefix. I would prefer some prefix to group these types of features. vdso/vvar are sealed during the execve() call, so I choose "exec". The next work I'm planning is sealing the NX stack, it would start with the same prefix. If exec is not an intuitive prefix, I'm also happy with "process." prefix. Thanks for reviewing -Jeff