From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99FCAC25B76 for ; Tue, 11 Jun 2024 04:26:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 189096B0096; Tue, 11 Jun 2024 00:26:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1388F6B0098; Tue, 11 Jun 2024 00:26:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F416D6B0099; Tue, 11 Jun 2024 00:26:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D86326B0096 for ; Tue, 11 Jun 2024 00:26:24 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 51E05A117E for ; Tue, 11 Jun 2024 04:26:24 +0000 (UTC) X-FDA: 82217321088.15.FB66384 Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) by imf21.hostedemail.com (Postfix) with ESMTP id 8D58D1C000E for ; Tue, 11 Jun 2024 04:26:22 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=BqdtF2+o; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf21.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.42 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718079982; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IyZsNH9Sc1x7yXcWCuPg478ZMDctoHgE18epfdz43V0=; b=MksnYqP3VhrRk9nhMs3a89p9Juu1zN3byqjZ8LF7I9XJm5PBGOER5qCzfX2NN7ruHelz0a Qj+SxfEN6i8qCSLJ84qc55c0EW9Gh9tlO+pzYKzRTJOfKwpj8Ui5mnONhuV5raFOCdCdfF xoiTKyNRgy83D/diCku7oAVGTF9mAR4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=BqdtF2+o; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf21.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.42 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718079982; a=rsa-sha256; cv=none; b=vJmMRiUuQshrLTKQerxcBUqu2B0vvtop7nTO5tcEr7A8Tw0wxea7+k+b585axbe6A3/u8C C2uZxVgHVg2N0DMO11TugfBmpjuPTtC9px602hif067PsGsBJHQq7oVESv02pKwAnjbA6h gn1EDehDvpQdzB8qtUwTluAOOb0+2o4= Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-254d001d03dso686593fac.3 for ; Mon, 10 Jun 2024 21:26:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1718079981; x=1718684781; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IyZsNH9Sc1x7yXcWCuPg478ZMDctoHgE18epfdz43V0=; b=BqdtF2+oP/C25BZ4fglEUpD/RWys1U137n6hvALPExU2hijo7rfssbZ6m5XpPn4Tny 4ztt0xbcpmaq/ds9Fzd/RlLlB7bzxJ+KbA5ycUMDQyR0gyGzLso2+z45P4voYOmb9AxU aNbBJf86QSpFkhcqcUES63JGf3FovIMpUTfl0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718079981; x=1718684781; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IyZsNH9Sc1x7yXcWCuPg478ZMDctoHgE18epfdz43V0=; b=S0+dYCCw5/AP7d4H1iX6hLLJ+R/Wrz8Mkv1Pd+udNI/acvbshEcU+L4gzQSpJW7bzv QM7hhGU+zjAwMb75W/z9qho8M/qIyZbaYVxfiKvT0fX3ImEJDqHM7Ejm7slTO7dosJtk CbSa/6NyjJIDhZUXM8zeJQa7GqDztAirW3kh9QDzEcJ5mX9H36uP5oaPWS1kNJTGlcLs 2q3wFh4XJ7kRlD9cisjVN+XSJo74Bq3T0RqbLnyhsrbuMuaJPUZ6oMfKy0bZWRXnHop+ A5jPAK0n8yZRfk7lAixRNhmlSTJ6svfDFWLFz9x6ZHWw1JvSIaYSSg9wN12Jr8x6NFfm TzIQ== X-Forwarded-Encrypted: i=1; AJvYcCWjjup0i4mK5rvuwqnNPIvl2RFQp0m+e+plkUkyGUU6VKr+xP0AbRSxSeQS+Twa8n88FA9qKI+kcu87g0tKbl+4he8= X-Gm-Message-State: AOJu0YxK/nsyGfZZHzlDmndvqhhkxxym3oRLqYXr55o2wka8HIH2Is0v QbuV0Ig9Ennn60VtzLeSMtxAdqCzgnNJq7wv3J42aB5s413VoUgTBgGV7IR4sStdaSvpT2Z50n7 jbPgOha2T2i/wKBRRMQsv6Xai3jQFxMLjK0Q3 X-Google-Smtp-Source: AGHT+IFK6lTZPxP5FNiUopooFXMRPUqIKtSzFDv00FIyn1QRlpsxx6oo/JyuSnfToVP5gluNPRqDdITOntAxxf9qVvQ= X-Received: by 2002:a05:6870:56a4:b0:254:826f:a9d9 with SMTP id 586e51a60fabf-254827023d3mr11111691fac.39.1718079981520; Mon, 10 Jun 2024 21:26:21 -0700 (PDT) MIME-Version: 1.0 References: <20240608021023.176027-1-jhubbard@nvidia.com> <20240608021023.176027-2-jhubbard@nvidia.com> In-Reply-To: <20240608021023.176027-2-jhubbard@nvidia.com> From: Jeff Xu Date: Mon, 10 Jun 2024 21:26:10 -0700 Message-ID: Subject: Re: [PATCH 1/5] selftests/mm: mseal, self_elf: fix missing __NR_mseal To: John Hubbard Cc: Andrew Morton , Shuah Khan , Andrei Vagin , Axel Rasmussen , Christian Brauner , David Hildenbrand , Kees Cook , Kent Overstreet , "Liam R . Howlett" , Muhammad Usama Anjum , Peter Xu , Rich Felker , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8D58D1C000E X-Stat-Signature: tr9ctmawxshox1yuwfsoo5kn7mizefra X-Rspam-User: X-HE-Tag: 1718079982-573816 X-HE-Meta: U2FsdGVkX1/J24q004eSr/EzsuxZxtg5nKpLRohPLm44gEWgauH4EPmMiZF89pMZfyi9s4XHgFo3JEdTfRT8/vvuJqBbPd90LO+y7hPgz8BbG6mGfFApCPamlHL0Q+qtJll/pdj4eipfrH+BnKr3ctq3qHC2xBHCLMnpzhiofYe6LdQ01L8zxioeHl8TC8fSqH183cWHSgN6at7MRF1ofPUEOdH5+Oz3em1X23Svs5oUulTEcLy4mFm5Z4mzyYD9fTD8UYVvbTJUcdY0CUlNTwYCM5llcWs7yN+iBryBVAIG53z4kiDaQEBgfsbCukwrGyiPh2u28hICvXijgJeilnOrqK+SnRQ6dCa9E/2MX2vvOZFwc+iSvGbErGgNsvhW2lJezGppy6L+381n5RRzv4IjP4NYkLvGRvbmX2Jb1nJAksHiJGXWbWsS0+Vq/zxMtEwJlGafWEeSEizgmXRolRI/YLliuYD72jaHZNTmCF+F+SIZ+oCQpbXmyhQ7NmILuDIubTPzSbHal0hQRpJxfEf4bt0H7nMSZFrf9poFWZOq6bSdl0VCwhhmBiezsHfnmeEMrPsnk6+9sx4dbBBtDW5CrqLjC0q/jTs58kGrF6yW/la1/6LQ3htPKpJpDAJmiRh8qiweSyLbXzHutZmFHf7UN2ydyZEErqhypgMk3OkvuCULwB8qjwSBf+v6QBLPv4+bYo7seKbjaNzUekmVx0geFg/AJgS/XboCqYJpDdTc3qyGHvipBom34bRafMLqSB2zEuzGSW+4YAUZ1zNWwywv5P4IRxb2LWYG4x2WJnvwz4dEgDnRGsbBASRtEPlzlPHC3ZRyOu0wXqu6y3A35Yy3bbxXMYvkz37MBv8ySSfUBymlLo068B7vgeUYBwHEmv+Hqt5FTxjCpj++hjhOaSTonlgnSZYFPRliuvcCtnvxtYm1fGDvCdsfM3MdFj9y2j07hlZscid2sOVJ/o8 iJNwzPUp gjLNH54XlefbIoNMzdJEkeeyDIpp2lt8UtwjOfbb9Wt26ja4m9oJJN+coN8cEzUrHM1MrkslFX2uXUe6toFx4A9c/ThDnImfPXpTRwEsNyghWbCQ3RaPama+JuqZ0v6AG4Ys6/nPP5DL6aWF9ZDZC+nB0dZJYd6eFGtPs5eOoZLqTBi9Cs2/+4KOgYzAi2OBUo1SzEjqdG5jBTXsFjNNclm9RCsGWyPskRWUc1w8ih7nwvv9IKHxlVtU63H11N3KIKDEh2o7NrpyXWsU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000121, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi On Fri, Jun 7, 2024 at 7:10=E2=80=AFPM John Hubbard w= rote: > > The selftests/mm build isn't exactly "broken", according to the current > documentation, which still claims that one must run "make headers", > before building the kselftests. However, according to the new plan to > get rid of that requirement [1], they are future-broken: attempting to > build selftests/mm *without* first running "make headers" will fail due > to not finding __NR_mseal. > > Therefore, add __NR_mseal, to a new mseal_helpers.h file. That file is > small right now, but subsequent patches will add a lot more content to > it. > > [1] commit e076eaca5906 ("selftests: break the dependency upon local > header files") > > Fixes: 4926c7a52de7 ("selftest mm/mseal memory sealing") > Cc: Jeff Xu > Signed-off-by: John Hubbard Reviewed-by: Jeff Xu Tested-by: Jeff Xu > --- > tools/testing/selftests/mm/mseal_helpers.h | 5 +++++ > tools/testing/selftests/mm/mseal_test.c | 1 + > tools/testing/selftests/mm/seal_elf.c | 1 + > 3 files changed, 7 insertions(+) > create mode 100644 tools/testing/selftests/mm/mseal_helpers.h > > diff --git a/tools/testing/selftests/mm/mseal_helpers.h b/tools/testing/s= elftests/mm/mseal_helpers.h > new file mode 100644 > index 000000000000..b922d453a014 > --- /dev/null > +++ b/tools/testing/selftests/mm/mseal_helpers.h > @@ -0,0 +1,5 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#ifndef __NR_mseal > +#define __NR_mseal 462 > +#endif > diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/self= tests/mm/mseal_test.c > index 41998cf1dcf5..20949617a036 100644 > --- a/tools/testing/selftests/mm/mseal_test.c > +++ b/tools/testing/selftests/mm/mseal_test.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include "mseal_helpers.h" > > /* > * need those definition for manually build using gcc. > diff --git a/tools/testing/selftests/mm/seal_elf.c b/tools/testing/selfte= sts/mm/seal_elf.c > index f2babec79bb6..4053951a535c 100644 > --- a/tools/testing/selftests/mm/seal_elf.c > +++ b/tools/testing/selftests/mm/seal_elf.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include "mseal_helpers.h" > > /* > * need those definition for manually build using gcc. > -- > 2.45.2 >