From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F9A3D3C530 for ; Thu, 17 Oct 2024 20:12:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C36B76B007B; Thu, 17 Oct 2024 16:12:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC0A96B0082; Thu, 17 Oct 2024 16:12:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A39656B0083; Thu, 17 Oct 2024 16:12:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 821776B007B for ; Thu, 17 Oct 2024 16:12:53 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7E780812D9 for ; Thu, 17 Oct 2024 20:12:43 +0000 (UTC) X-FDA: 82684192164.07.7B02CCE Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf25.hostedemail.com (Postfix) with ESMTP id 46D62A0015 for ; Thu, 17 Oct 2024 20:12:44 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Zt7zP3fP; spf=pass (imf25.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.208.47 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729195897; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NBozDxQInUDVX/+SAvu1SlyYGKkBJoWGPhOhoYJAyiw=; b=Dm0eS6uOa5xGfFlCkM8pOFzsgIQbUI1yMaApx5gts6VN+RAh9t9MgYUMl6k7q3E8ilVPZo z4ZJR3qk3FXIjCl6MA3I9/6gHLlrpHoUJfxBxa3BdStxpwXIu1nAS3poQdis1jyL/t6kPp FF3lRpFpEPSHh9Z4RFqmAtq+4pCSpSc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Zt7zP3fP; spf=pass (imf25.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.208.47 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729195897; a=rsa-sha256; cv=none; b=f3tWTW649Vej1vgtRwbJdRyXlQuWFlR0rXwC1cZG8ZtNtA+/CzfxfV8TyWmHq6KnYZhshV Yw7RdZ7m0IDCdHNXz9GKa27h9bZaLdTCY/EjxWyU+4d3LatPWjoxyBJqSa7GcaUoCNOyKK ouVEPdqJA2PfA/c2JXEZuCb1sWACwZo= Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5ca0a1fc1aeso12840a12.2 for ; Thu, 17 Oct 2024 13:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1729195970; x=1729800770; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NBozDxQInUDVX/+SAvu1SlyYGKkBJoWGPhOhoYJAyiw=; b=Zt7zP3fPEgn48h4QaF6JcmWFrOpsnxZfmmpfKU1m8yOv1ErR6oO0c4XyI3DoQytbLp ncvnhEiWcAeAuzzQt1/MBIGEr95s4bfNrP9E2RgWGUrNjK10WxqDj2BV4ChsRr0NE39I hxysTAUzi0ZhDNIImxrF2uKgn+I2CNvj/74FY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729195970; x=1729800770; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NBozDxQInUDVX/+SAvu1SlyYGKkBJoWGPhOhoYJAyiw=; b=Hs+b5uDZMMMxPBNNPLbPWeyUWmi8salce6NLQK3M2kpFzMLnmEUtQ3jhhE5obAeHGo XhG+oVgpki5XwhkHXG//ttL8gqwGV74XLPjtYsXipAeiQGJFP7tu8rh6ADdBd08pGwyS sSUKOIuRpJczbaJ8FM//z0RyMdcaz6p/IOZWP1h52bPMk+8QG6cZ5xBv1m38zXisU2VE 69w+N6tcHOkYQ+fyky725fNhCH6hzC20LJTOHHIjRWJJ+jgcLu4AYPUvSdFAQ56G9/HQ 4eVzm0Tgmj56X+7WlxV/Ze5CDKb79lP19rBbinzeLPy4HJkABr9UbKoZOYaGxM2rbxNQ EdQQ== X-Forwarded-Encrypted: i=1; AJvYcCUETBthqJDbMtE11KfnkwlU0LJc9xGc/QNylgGKlNExUkFLrqOgtoUmqmwGh6YMj0SHJv6IGhCuhw==@kvack.org X-Gm-Message-State: AOJu0YwndleuXEgMysyzpXmsutedBYTV5M5Bw4SLSQj2MYh3SpUBM/fU GVX9ksko5QEMkrM3wVHav7u50Nzi17uX8R4zcE6A+Nf5HhSPmI6dpjGS8mF7h5D/8U76jvA/gi0 6AbqHqBGcOkmB307QVeWA9qg5sR73UidQ7+DH X-Google-Smtp-Source: AGHT+IHMKwVD92dy+ne41XM8ABFquxk2pbEXlPTudUpzl7Zpa7r8kMniYucLBIkvG/gwVEopvNNS96zlSIhybkKunA0= X-Received: by 2002:a05:6402:348a:b0:5c9:879e:6998 with SMTP id 4fb4d7f45d1cf-5ca0ac44384mr2981a12.1.1729195969744; Thu, 17 Oct 2024 13:12:49 -0700 (PDT) MIME-Version: 1.0 References: <20241017022627.3112811-1-jeffxu@chromium.org> <3a1bbbdf-1281-4f44-857d-58cba583e3da@lucifer.local> In-Reply-To: From: Jeff Xu Date: Thu, 17 Oct 2024 13:12:36 -0700 Message-ID: Subject: Re: [PATCH] munmap sealed memory cause memory to split (bug) To: Pedro Falcato Cc: Lorenzo Stoakes , akpm@linux-foundation.org, keescook@chromium.org, torvalds@linux-foundation.org, usama.anjum@collabora.com, corbet@lwn.net, Liam.Howlett@oracle.com, jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, jannh@google.com, sroettger@google.com, linux-hardening@vger.kernel.org, willy@infradead.org, gregkh@linuxfoundation.org, deraadt@openbsd.org, surenb@google.com, merimus@google.com, rdunlap@infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 46D62A0015 X-Stat-Signature: 7m8cgb37j68cfpekpxokb85kuibjbufq X-HE-Tag: 1729195964-413002 X-HE-Meta: U2FsdGVkX1+5kMiRSWh7TJ3WN67uruDI0dLVZnAxE3SWxhmEywjDfUEDoHa/sJ/ZNJN7iAGfvcVtJP41onSmWNXiyOlvPc4C4pSTF4pGcnVKl5tujf/uUh1ML94kC9qCU+wdadkcUfggJCl/GofMv5ySuj3oshGfQRM8AFzzb2KWC9OkujgVat1+TIfbXXWM7HgZsO7JOpCUdH3SJqZw6HKivYhxK1gaCBjG38pn/9eDtqNmjg87yStqnjZ/msDBcPCfmtOL2l2Wf5aIrw37JiOS4WVAzO+BC69p30ZnYDv4gACGtrHox+ttfrLmc8iItUD6Kdixx0VczwK/piplQ+aNh65xP3JOdLocD0iUmaBGyVmSNtug6BYmX3rflVKbjccH3pJ77JZN3zTQAYsLLAtdgq4UXyupGdcY6AJR/04cp8ijEPwMUu85nHX1R7KMcv8URfsSLOU/90zFuPDQTJaEXCldPrbT4e8g5P6xNyGvdO/H19Z8B0EqvVlFc9Yzt9NAKi6nu9JNpplVsO+2j1GteuxBkKHDpt2emYp13dQ0OPi3WpgsFIdVw861yneq+W+r/zRo9UtwVO4iNFARyHJ24z+bGQ+TKXlY2kifHxGTgUHxeG+xqTzCfssXda2UhfTWUOC/zWqMdQ60Ty+6NtPIw4BRhRVHqsonWZoOKf1fKHhoMIHRJ9rPTnWc9KRuPuIAPI1qON3kPYqDtZ3+Q0D8OmUXsBBSrfpZmfNrpZdf6OEwWms19qMjONFkv5W/7kZnNS3ovZd7MM11Y/sjf3wdgPcdfmtUNwIpj22orM7O0PHKI4jyAhNzObvaxs3Q2V5yLsdyEwu+o5B6pgglEx/NJi4DbA0jExAsd86RCOWkO9joIz0QtwH5Jx7r0clwr4MiIOl9wBw/NoJ3rzbak8LswwAcg/zIN38lEChdxEfQM94UHekqFRt6bdd0gSmUlD1dfpkx0DL9d+6WMux jtfiPupv Mt8OLcQnAjB+ARgwozLqDFHdQ4rpmlfk9pIwf6XI05YitmmEb39sLImznCc1grRre7fruW50jNoCrzASqwap4664ZBfoPku2YBNvVkc+Jqi7nmXlFeTuV5AfpgSx4d/OBQca7xcO2YnpdcrhfhTyWPddsjJwrliYmziYzQ9jyj6MTuJ3xfa24eo43gRYGjIIFaDDKgORezsRbZGX6RkkIYa/o5zxxDFxI7MX0nsHjQ4JbqKAyypy4TbZC4XrrX+qtdVmsXOxMmaO+H+x0aTeAmCrZX2pOOLeuzm7srQ853w6BHwk8nQC7bnBBMvWAV0aHGf8y X-Bogosity: Ham, tests=bogofilter, spamicity=0.024217, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 17, 2024 at 12:14=E2=80=AFPM Pedro Falcato wrote: > > On Thu, Oct 17, 2024 at 09:20:20AM -0700, Jeff Xu wrote: > > On Thu, Oct 17, 2024 at 1:18=E2=80=AFAM Lorenzo Stoakes > > wrote: > > > > > > NACK. Greg's bot got to it but... > > > > > > As per Greg's bot, no signed-off-by line. > > > > > Sorry for confusion, I wasn't meant to send this as a PATCH, but > > reporting the issue. > > The diff was just sent as reference to repro the bug, and I forgot to > > remove PATCH from the title. I apologize for the confusion. > > > > Can you explain what the issue is? I don't get it. > The issue is there is one VMA that gets splitted after an unmap call fails. Two splitted VMA share the same attributes. e.g. - Allocate 12 pages (0-11). - Seal middle 4 pages (4567) - munmap (2345) - this will fail due to 4567 being sealed. The VMA for page (0123) is split as 2 VMAs (01)-(23), those 2 VMA have the same attribute, and should be merged as one. > -- > Pedro