From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 570D1C4828D for ; Thu, 1 Feb 2024 22:37:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B21626B007E; Thu, 1 Feb 2024 17:37:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AAAB26B0080; Thu, 1 Feb 2024 17:37:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FCD26B0081; Thu, 1 Feb 2024 17:37:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7991D6B007E for ; Thu, 1 Feb 2024 17:37:50 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BBA25140542 for ; Thu, 1 Feb 2024 22:37:49 +0000 (UTC) X-FDA: 81744698658.06.6709745 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) by imf22.hostedemail.com (Postfix) with ESMTP id 197A1C0019 for ; Thu, 1 Feb 2024 22:37:47 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=TZccnbup; spf=pass (imf22.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.167.178 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706827068; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PmoKB9U9mw3t4FpnGtJps1mksky8tREvppcYUjjJHJs=; b=NdG4LFq1nKc6fnsHRtg7HTnwaivNiNnF1BbkOpIN1Viz47/Vu8tZP4R+KJ73Zq5B2etDYM yLucYFEaenK6YHOoR+hlPK6ItQJbHeDc3NaEMpEBg9DmviT//njBAZT4B7e1nwgAA9uCbY 43Dnsm8IubX5NGwwbErPvI2HjFr9Tb0= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=TZccnbup; spf=pass (imf22.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.167.178 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706827068; a=rsa-sha256; cv=none; b=Wp3GsuL40ydAj4EYUxt6WGuhFO6LMnMMopf7T7IwE2QU5P48wr9qL3VeoJczprBRGqqWdb RZ1KiyX62BKYJAblJrAzPz3aAaxeWMGq/12pr+Pb9/hH5zAge6bTaBXFVuia6jV34BXxs9 uzblBrESyk/vcC4UbXnYL3UscWLLuGU= Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3bd4e6a7cb0so911333b6e.3 for ; Thu, 01 Feb 2024 14:37:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1706827067; x=1707431867; darn=kvack.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PmoKB9U9mw3t4FpnGtJps1mksky8tREvppcYUjjJHJs=; b=TZccnbupULOBxN3vxYeotOUbEnPFE0giZPu+/IWjqzbecFfUifC3nKQSgsgFxKp8rY lvchPaWh9OdwsR/+bFKmM9Zub77M2oKQtbDkwQPRxF578LL49DDPocOQXN9mH4EdDB9E 2ffYoSmJjcmutT7qfMRG+vidkAMU27eKgHwaE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706827067; x=1707431867; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PmoKB9U9mw3t4FpnGtJps1mksky8tREvppcYUjjJHJs=; b=asAwwF2BJ9cY8wGyYn5/Xtb6tehHQdI2W8C1k3MLzmw6WczURSQhC3l50nsOw0CNXM AAXzWetcXERtTH3t9NAtuS7tlYhF8dB4kTzCVj+DJRm0vidcIDnpV+qIX2H/Nxs95aei t9vrW4MVCOB52nSE1WyLS+qImTLIxTM9noo6Opkf0XSFv6/RK9RUprjr3JbiAZu62zBi ET8Q5906apFEj5SgA5d5B5jTDf2wWFk8u4pokv23UxUa1ggCj5aTuYBmUzl/GquzewUC bC9EMulQH2NhLj8ZG/j40VCHd+B5q/WUAEAcO63I3iA72C9V9/dl+cXV+dWbbXeYAz7q zCmQ== X-Gm-Message-State: AOJu0YxNoU2y6tQPI7hyEXyFflCr4TrdBL8lyUWX0ZKvEtUkkY9z/TfX SE8/GBS6rIOL3ekcmKWdE0oGuJ7PksaSkkphNI/bOqRL8nY/NKgG1R2aNvl6EzS77yOwGDJs5c8 mEf26ergJC3Q1qM4VQH70+xIzlCX4vWnFig4r X-Google-Smtp-Source: AGHT+IFXjJjh4U73XklHRwMqQKC6IUK8yT1QB2L/QSJgxVT2r+D8jpRmpXkJyI8e7UxCR3vkuM3rQ/1eDkoKFGaW8GA= X-Received: by 2002:a05:6870:f228:b0:210:7f85:c208 with SMTP id t40-20020a056870f22800b002107f85c208mr7371815oao.46.1706827067224; Thu, 01 Feb 2024 14:37:47 -0800 (PST) MIME-Version: 1.0 References: <20240131175027.3287009-1-jeffxu@chromium.org> <20240131193411.opisg5yoyxkwoyil@revolver> <20240201204512.ht3e33yj77kkxi4q@revolver> In-Reply-To: <20240201204512.ht3e33yj77kkxi4q@revolver> From: Jeff Xu Date: Thu, 1 Feb 2024 14:37:35 -0800 Message-ID: Subject: Re: [PATCH v8 0/4] Introduce mseal To: "Liam R. Howlett" , Jeff Xu , Jonathan Corbet , akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, sroettger@google.com, willy@infradead.org, gregkh@linuxfoundation.org, torvalds@linux-foundation.org, usama.anjum@collabora.com, rdunlap@infradead.org, jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com, linux-hardening@vger.kernel.org, deraadt@openbsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 197A1C0019 X-Rspam-User: X-Stat-Signature: bwdytprhbigusj4i4iap4hd46bwyeoz6 X-Rspamd-Server: rspam01 X-HE-Tag: 1706827067-975275 X-HE-Meta: U2FsdGVkX19rSKP4AYW6kPTNKe/VWccjjOmZ/c9dMTpPW0OWq6TBiKhUNvVJGFhbSRjOCqL+zUpOpAVf2H2OlpMkfZDlEIpQfmKnjn4snIfQdkJa3H5U4OtMKAdhS32AMQo9Bx+EsMw5JAZ77Ar8ZtPZsvsdhT//I+46+3n76vVdMTN8DSXwGADFIxlJQUczZ/klJQP7kuY70ZsfIbbbw0hQ2qsApCGzl5s72mVe+g0OIxXCrEwNw/vw01bwHZmE6DZHQ8ibwaqNjx0gMoH97LoYjhzL6oBXGEbaXEtjXzj5WXlxgvRbIe7bG41uPgNdl78TbVUieVy7M+P7jN1WVbzSFWUCoat3VHuPeh9Lp1NGDwz2HjRxRKDIKbAMbqgSLcw+FroTVY+9qz2rhlQXwjq4UxnQpuC27/RSquwNpvAEIh4h8SCndaRW4iwuslpTkTyiZnn6h/jaT98Sxj5/w7/rAIrKXzRPo13Pq/XlQR+nhYgAOP7YCg9qdfYrgP1fLm+HKSG0835Yq8AM4JtKUfnl0yjGvObr9b1teu56oTcBagttjrUTfTk0RRWVLbzSYT59TesK4dcx2gWWp0wORwyMsb4LAKo8oK3AdJZSh6yZ6V+ycYYanEoDJQJ0flqXMjj138YBfxrh+rMEibRE0mqmuAqP0pP8UPOg2wqH+1XVVzQSB9DFjvrYGY04iYlyMc8L1CLlj4PB88oMRiuP2kp9xruGhvi0cE/2F2wnzMBXpHm5CUJ9KZCm6h1wHTtFKx8WPFcsveUI2TPaECTdLyT21fmyTXKIfndmzEqQtGkWFveeVuOEfSooDKiko1mXMVFiJyvpp4nMSdsiXd4hPIMWkFZobl7ijV9/sXJl9oLOy6mJpnOOnORNPXIKoNfcjjxKsoyRniKq0SwfhtDatyGq/+JFAMt73tF3sKOgAM6PQ/H5Hp3430DTXBvNEmkYgmgBSqKoLJyxDWeR920 h7ckACLh ucnlIwKe+yywalYcJMzpGTCFv9zPtgaGCfqd1KE6HX8bUGD6SHKRKSb/F3OSNCSlFn85ADuoB7TpiHzbMiu7YKMmIE17raVROp2hR4OfvDkHI+IBv1TiN7t/02jDNZ3q+aqvdd6ma1KubACt61OpDR0eERjM78ME9SEKrIFVb6S6/QDJ66flpT/8scGJqI+xJF/6Cpf2DqkuOuaO0LZCqxj8kTm+TamFO3vSj2Zqd1yuFqTi8YTY9g9OVqgwKSFJEQWX1xqvO3KgRvlhb1YU2NHdTmGTQkl8tZLIMdgX9hG12izH/M63Im3R8DXrASSDqU/nRsuOGtLdmIluSrvcWj0NV6cKnNwK5xHz0AF+x2z1PNzqIgnq5IaVx5AURJbtuM1bGJm9a9pOLcEm1gD0cQZkF7O3EmpkRHM/yLoO11k+OFj1mSvrR6ABCTWz1Si5V2dBcF5AnjW8BbW9erYDgygQ2qi0tEHdbgr3TuzQBIdoI5RpSVXeDIlwfHm6Ose+Vw0M0VpwmpN3DIPPBqRZ3vKpXfGnlhSIfu1TXLSzJKDzkeWdTtl0Yqt3CySYXR6zgHNg7s+9M4Z8Ju+w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000115, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 1, 2024 at 12:45=E2=80=AFPM Liam R. Howlett wrote: > > > > I would love to hear more from Linux developers on this. > > Linus said it was really important to get the semantics correct, but you > took his (unfinished) list and kept going. I think there are some > unanswered questions and that's frustrating some people as you may not > be valuing the experience they have in this area. > Perhaps you didn't follow the discussions closely during the RFCs, so I like to clarify the timeline: - Dec.12: RFC V3 was out for comments: [1] This version added MAP_SEALABLE and sealing type in mmap() The sealing type in mmap() was suggested by Pedro Falcato during V1. [2] And MAP_SEALABLE is new to V3 and I added an open discussion in the cover letter. - Dec.14 Linus made a set of recommendations based on V3 [3], this is where Linus mentioned the semantics. Quoted below: "Particularly for new system calls with fairly specialized use, I think it's very important that the semantics are sensible on a conceptual level, and that we do not add system calls that are based on "random implementation issue of the day". - Jan.4: I sent out V4 of that patch for comments [5] This version implements all of Linus's recommendations made in V3. In V3, I didn't receive comments about MAP_SEALABLE, so I kept that as an open discussion item in V4 and specifically mentioned it in the first sentence of the V4 cover letter. "This is V4 of the patch, the patch has improved significantly since V1, thanks to diverse inputs, a few discussions remain, please read those in the open discussion section of v4 of change history." - Jan.4: Linus gave a comment on V4: [6] Quoted below: "Other than that, this seems all reasonable to me now." To me, this means Linus is OK with the general signatures of the APIs. -Jan.9 During comments for V5. [7] Kees suggested dropping RFC from subsequent versions, given Linus's general approval on the v4. [1] https://lore.kernel.org/all/80897.1705769947@cvs.openbsd.org/T/#mbf4749= d465b80a575e1eda3c6f0c66d995abfc39 [2] https://lore.kernel.org/lkml/CAKbZUD2A+=3Dbp_sd+Q0Yif7NJqMu8p__eb4yguq0agEc= mLH8SDQ@mail.gmail.com/ [3] https://lore.kernel.org/all/CAHk-=3DwiVhHmnXviy1xqStLRozC4ziSugTk=3D1JOc8OR= Wd2_0h7g@mail.gmail.com/ [4] https://lore.kernel.org/all/CABi2SkUTdF6PHrudHTZZ0oWK-oU+T-5+7Eqnei4yCj2fsW= 2jHg@mail.gmail.com/#t [5] https://lore.kernel.org/lkml/796b6877-0548-4d2a-a484-ba4156104a20@infradead= .org/T/#mb5c8bfe234759589cadf0bcee10eaa7e07b2301a [6] https://lore.kernel.org/lkml/CAHk-=3Dwiy0nHG9+3rXzQa=3DW8gM8F6-MhsHrs_ZqWaH= tjmPK4=3DFA@mail.gmail.com/ [7] https://lore.kernel.org/lkml/20240109154547.1839886-1-jeffxu@chromium.org/T= /#m657fffd96ffff91902da53dc9dbc1bb093fe367c > You dropped the RFC from the topic and increment the version numbering > on the patch set. I thought it was customary to restart counting after > the RFC was complete? Maybe I'm wrong, but it seemed a bit odd to see > that happen. The documentation also implies there are still questions > to be answered, so it seems this is still an RFC in some ways? > The RFC has been dropped since V6. That said, I'm open to feedback from Linux developers. I will respond to the rest of your email in seperate emails. Best Regards. -Jeff