From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76D39D3C526 for ; Thu, 17 Oct 2024 18:47:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F02666B0083; Thu, 17 Oct 2024 14:47:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB3326B0085; Thu, 17 Oct 2024 14:47:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7A086B0088; Thu, 17 Oct 2024 14:47:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BB7B36B0083 for ; Thu, 17 Oct 2024 14:47:30 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7950780CE4 for ; Thu, 17 Oct 2024 18:47:20 +0000 (UTC) X-FDA: 82683977040.19.5B73BA8 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) by imf01.hostedemail.com (Postfix) with ESMTP id E3E854001F for ; Thu, 17 Oct 2024 18:47:19 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=B6rSQoPV; spf=pass (imf01.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.44 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729190800; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xz9ukrGeZskaQB9yt/h8UcekXyqlQc0oC5gnfYFoitY=; b=8C3uMuWDYOE6HIMX0AEtzARNgnE313Xz3eJh2KlnIpU5pY1WuccWfEIvG5Y4Aq5Gt7He/w 8ke6cT2CZ/DuR2vF1aDBCkQxCOWxyAgnsvDfZN8GOUVS+36wegHNKdl+9Qe7qyz0S2n/aH uUlm1JqJ79aeoFga2eUwp0f1cLf6K2U= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=B6rSQoPV; spf=pass (imf01.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.44 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729190800; a=rsa-sha256; cv=none; b=nxdrIwQzSA5DhPYsJcmdgh/ezIXf++tljSp+XyKiHGMVN0z1PctrbsG6fMta1MPtuJoma6 i6CmlJyBLOVyvnTs68wlMLkGIonLzJXtCqhtsRAJySmllV8+oPPKK4q4EXr9/GtFltPB+f 8YYMj/ccaYjD+XnIYOyepD54EUKOTyc= Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-288824e9cc4so175778fac.1 for ; Thu, 17 Oct 2024 11:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1729190847; x=1729795647; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xz9ukrGeZskaQB9yt/h8UcekXyqlQc0oC5gnfYFoitY=; b=B6rSQoPV5lzR78VoXoCzsowiBs2ELswdIXYJVyijRBdkXyePPIy2CDfyF5pFjg3Eiq QA+0kqfH6G2uz6zMJNhcEgkKSWVtN/o5zPsBYMkpq0wtQzQVNqKjb9ppkl3Q57evFUj5 5sduVfTeSv7AVpnS5uvL1mAKDSbmgMzrk+8fI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729190847; x=1729795647; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xz9ukrGeZskaQB9yt/h8UcekXyqlQc0oC5gnfYFoitY=; b=DkoJDHLwa+1Lg0UldZvSj9BsNM023JSgqfMYjKRyCy9Nq2sMt8fNjXiqgt3X3Aq/71 +SzFaKO6IkkDgbdZ1J/St9S/RV5GNHvLOqLOQQ/fPRq7LaRGT/FaaQUOq9VW4KC+aV6a ewrtQVPZ9g6OWA56YaS6VPECqlTUxXSm5tguEpxg+GZ4JmX3ziHUaf2GWuG2LrZGRlbA Xv3iVRHArJSNxH1wZuzK+cwKDBLYzeFlwEtVlce55QM2U5yjY/c2jKS9ImpYwwzCZDeY yR6s/Fz3U2WjKsduVbJyVQVbeO/Pp8YGSJUOMa6PkUxZbcTfQqu9qh3ptxFEvpmREr70 wk5g== X-Forwarded-Encrypted: i=1; AJvYcCXE7acECwG4OqmjPyOYQzQnC+rpwYuEDGJJf1FsTKt6E+0Et0Zto/Iwsp2LCdlAZzS0f0vsDq1vgg==@kvack.org X-Gm-Message-State: AOJu0YztaJjaG56oP9dMIO/dJC0NU7sALp/C7KOVq0oL9xBpBNAmcVNB 5vqE74K89y7O0UI+8efPOZwZpah8n1kbB0A+Rp9JpZ+eb4ccp5C0tW9gRyyHyqs0QQD61n0VxBU 4JhVEyVFJPEgml9k7guUAw7xzOPvcuwfH806S X-Google-Smtp-Source: AGHT+IHnPnMKVN7xETiLGgLh9nYMnnwfKNJyUoWQMiSO1nxymCwBZOclTUBjKAnm5eGb14csK/tlMg1ClzuBDfswtHY= X-Received: by 2002:a05:6870:64a1:b0:286:f523:4d76 with SMTP id 586e51a60fabf-28929452e7bmr90753fac.6.1729190847169; Thu, 17 Oct 2024 11:47:27 -0700 (PDT) MIME-Version: 1.0 References: <20240830180237.1220027-1-jeffxu@chromium.org> <20240830180237.1220027-5-jeffxu@chromium.org> <4944ce41-9fe1-4e22-8967-f6bd7eafae3f@lucifer.local> In-Reply-To: From: Jeff Xu Date: Thu, 17 Oct 2024 11:47:15 -0700 Message-ID: Subject: Re: [PATCH v3 4/5] selftests/mseal: add more tests for mmap To: Lorenzo Stoakes Cc: Muhammad Usama Anjum , akpm@linux-foundation.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, pedro.falcato@gmail.com, willy@infradead.org, broonie@kernel.org, vbabka@suse.cz, Liam.Howlett@oracle.com, rientjes@google.com, keescook@chromium.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: drj964to8m1y5r481hsep3dt15d6g5be X-Rspamd-Queue-Id: E3E854001F X-Rspamd-Server: rspam11 X-HE-Tag: 1729190839-763399 X-HE-Meta: U2FsdGVkX193SyEVGiss44wcDQjQrjjuclEuzhsTBayoGnmTSA2ySKUVl+6Kb+PxyJ8CSF5V7n1rASUcD2DIVrgUZGgAkiAuqmajyjUa9pEYvmd1kTaStHxHD8Lm3aVstSEoanDd2rzrFbO0v6v3Z7Ebq8HcW0RA4j1OCnMWLvMyS+/ziFk/kuDKEjty5bkeohCGS9348DrPSwEmkML4ju7SIlS2ni6k1U52mTCsc5MTOR27SXsY236HXrMOj9GKgMJjWquQE4/nT9jQmE7rkIUbXfWHQ68a2QECGG9k8hr4UQZqfb0aoW/pe63eXt5YUiyW1fkvSrsf/JdMxDYEkgiMhrNz/DNbnQ6bLrb5nQOOEVkrceU05dKetIp2rzUqlWwXoRcRsl3JRSjK3xl0Ch06xtax6tCOkSrdYSqHQBbvyy5zfw/Tg1ujQjw9Jnh8uuSVVFqWsRDjlt0AGHYRPIVgt96392X7lw3AvyeYqLnKiHAokKkzcPW4gC0Diml3Opnuz8CXtwtjIJLY2Ii5suqLsNXCAVDDQ5tO8gBmclCYtT7HAEfI9iV8d1DAEb+X1X2Wl0HdB5ubHvSg56akmxTaIKaSGQpLo2xSXz7kY1X1DNSKBpoJOmHNSVDlpBg/bJBVyaDyRfepBZ0klLHmjqMxv+aLdfDEAEf56NwndI24DmT2fKb6Ohsfa7r+yoAWBnWryh+dlmzhGEFzhC/MzV4sQbj/FhrEfYX30LTnwYJv4NyVntZ8VELpxIsyYoEl5gkNFYVvNqpoJqucu0JYJMn4UmOfm+bVNzpn0IFU/N1DskjRdH/80PRAfo+H4GubrImgCYvNzmhoFHdTKlWiI5ctL/w+Hx2eMO6PrF0XXdxZ4YBECYTxobFcMI52owtwgDT4fnxT+GliIjkopPykuC6kregW0YnvIPwlAGXRWU0bA4NwOW9yRBkpZIFO/T/HnKs0gCH0YS362qlZuRa uZTf3YLk J0pI9LOiJebK6S7g30cczR64FgbuB99V0XSBux8dPX2fqw2Reu2pZ3KUibumwZ4vn1QaYgbxgf6SBGQs5hrJUjL6rn29a18pA3g4lq+5zNBB2AA9nCxswc1xLsZiP7lQQvU3sBTHGT0A1CWmWkYG1SF+c8BnKZ+NbnHGbNJNjWO019f+G5wfcbvmqSz0Vhd6G+e7ER9snMdJdelXyIqNBO1u85fGJrb2wAWpwHAlQe98TnG3DD246MbUoyBk0j0tl7b2SNGRW2ybiRpmaALcGP/M9+eKYJxtGzHlbQ+x1/ine2G6IMkta5qDHX87u9RSXvDMUNV7cUjGGn8N+MVjnwK1qL5kpDfYmr+OhLHyvw5pYYLvE/fpzjJUPobojLOXOx0DVIo3Vvws36Bo97BZyofz7JQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.040884, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 17, 2024 at 11:29=E2=80=AFAM Lorenzo Stoakes wrote: > > On Thu, Oct 17, 2024 at 11:14:20AM -0700, Jeff Xu wrote: > > Hi Lorenzo and Muhammad > > > > Reviving this thread since the merging window is closed and we have > > more time to review /work on this code in the next few weeks. > > > > On Fri, Sep 13, 2024 at 3:50=E2=80=AFPM Jeff Xu w= rote: > > > > > > Hi Lorenzo > > > > > > On Sat, Sep 7, 2024 at 12:28=E2=80=AFPM Lorenzo Stoakes > > > wrote: > > > > > > > > > > > > I also suggest we figure out this FAIL_TEST_IF_FALSE() thing at thi= s point > > > > too - I may be missing something, but I cannot for the life me unde= rstand > > > > why we have to assert negations only, and other self tests do not d= o this. > > > > > > > My most test-infra related comments comes from Muhammad Usama Anjum > > > (added into this email), e.g. assert is not recommended.[1] , > > > > > > [1] https://lore.kernel.org/all/148fc789-3c03-4490-a653-6a4e58f336b6@= collabora.com/ > > > > > Specifically regarding Lorenzo's comments about FAIL_TEST_IF_FALSE > > > > Muhammad Usama Anjum doesn't want assert being used in selftest (see > > [1] above), and I quote: > > "We don't want to terminate the test if one test fails because of asser= t. We > > want the sub-tests to get executed in-dependent of other tests. > > > > ksft_test_result(condition, fmt, ...); > > ksft_test_result_pass(fmt, ...);" > > > > FAIL_TEST_IF_FALSE is a wrapper for ksft_test_result macro, and > > replacement of assert. > > > > Please let me know if you have questions on this and Muhammad might > > also help to clarify the requirement if needed. > > > > Thanks > > -Jeff > > Right this is about not failing the test i.e. equivalent of an expect > rather than an assert, which makes sense. > > What I'm saying is we should have something more like > > EXPECT_TRUE() > EXPECT_FALSE() > > etc. > > Which would avoid these confusing > > FAIL_TEST_IF_FALSE(!expr) FAIL_TEST_IF_FALSE(expr) is the right way to use this macro. It is same syntax as assert(expr), e.g: man assert(expr) assert - abort the program if assertion is false FAIL_TEST_IF_FALSE is a replacement for assert, instead of aborting the program, it just reports failure in this test. Is this still confusing ? (The FAIL_TEST_IF_FALSE is already a descriptive name, and the syntax of assert is well known.) > > Things. > > Hopefully that's clear? Thanks!