From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5ACAC531DC for ; Thu, 15 Aug 2024 03:46:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F4536B007B; Wed, 14 Aug 2024 23:46:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07DEF6B0082; Wed, 14 Aug 2024 23:46:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E873E6B0083; Wed, 14 Aug 2024 23:46:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C95C56B007B for ; Wed, 14 Aug 2024 23:46:00 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 77267A0AAD for ; Thu, 15 Aug 2024 03:46:00 +0000 (UTC) X-FDA: 82453091280.09.46C5001 Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) by imf05.hostedemail.com (Postfix) with ESMTP id BBD71100004 for ; Thu, 15 Aug 2024 03:45:57 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Am+bfvJ8; spf=pass (imf05.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.52 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723693500; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4TesR0iaPHv+pQXDwuhp3Ea2WallNLcprPIy2NI2Saw=; b=SAhO/iMBkrR5RFqDs6mACM3qOajXz9GozQxkrVLikho/5U/z3CXeOlTLMHkHSvCvjkLLja mWbZKFWfNCh+2Nqks5QF3sb4KLyr+vpJF2GNqBHFR9v2G466YHPaLXlRH1zNypUH02J606 FNuQV1H8IaXZfiiCCDfVarj0BJifS0A= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Am+bfvJ8; spf=pass (imf05.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.52 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723693500; a=rsa-sha256; cv=none; b=Cj4mLYGP9+0Z2z9UV9zpz5cl72DmeK1My32r3ZuPks1lxMCiRkmVCTYt1LjwUbg90Pcgpe B3Q+RoAV5N1dqt+an0i6kP/JFNmgBwurcb80DpHHhbgjzExb4T8q2ue/s0VgmiFSR2YDom 4m2gdBKglEAutgx9JMFCE8gCPsCXQpw= Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-260e12aac26so353678fac.0 for ; Wed, 14 Aug 2024 20:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1723693557; x=1724298357; darn=kvack.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4TesR0iaPHv+pQXDwuhp3Ea2WallNLcprPIy2NI2Saw=; b=Am+bfvJ812DkrpOwz62yiU8/dMzeCD5w1hS/vliBz1Yzv422UwGWF38PZzw0WjTR0y pUtzCMKhieVewbnlHDulKndHS417jR8DMWNmie1b5g6RyOFXNhH6H3t4XTmfJIEwCs09 xKWrHts9uMpFLTLXg+eQKvbhZdYw7YCgutS3Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723693557; x=1724298357; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4TesR0iaPHv+pQXDwuhp3Ea2WallNLcprPIy2NI2Saw=; b=bBfpKCOzFtunSTMyyH9eJagiVVqBLfhASTa+bqTNZE7HwFU5sX+9CwU5hyTC6LjSaP bSzIN6X7EyldOBxn+ub0U0HlYDf27TM3QFW7q/g9gxa0LbKQARW9lJO47DrBE7kfVe3K tsdvSnq7dsqwQgqL874Xfz7aV8UbDINAm/r5wkKOKainEByDhUKrStBqjOJ3aCpB0KNL Zt575tNUTnzhjc3xOj52znD5SjU/totD1wPwIR8c4dNRQ7Qu501SyMWXJXEJSt/DeDtO 4Xv1KrkrSxh3EHK09XUaFJL1OF+omwPbHhuNqkP8DeGTBIc7V6m0xLfLpWhLBwVyEjaH Njcw== X-Forwarded-Encrypted: i=1; AJvYcCWJLTK/fNcWMXKlejsWpdOFKbRroZ+zT68UdBJO6FBk2KvLWzODw2SKQXLIamuXotoICUPWZocUtQ==@kvack.org X-Gm-Message-State: AOJu0YxT9lRYyH9xpjh0Vx00VoUbXSezMnrvV58JgIKPA5AdzbH8xag1 PqyQmriRt01NZ51NnLf3lLkkuPmBsDP4h6q3OB+tamW+GI8OFqXD7EDonR94yN6zwDoZnEcrapO yotde7UWzrl3jCn6RSJQacM5lSukV0UAmoOwf X-Google-Smtp-Source: AGHT+IG/UY7m5KF1rwuDldmERWQ0AsiTHKeHrxEPwTp6C4SOyAl/Y7SgDW/UdHJ6AXFGvkl3b5/OLN3SrL3fX5uC0tA= X-Received: by 2002:a05:6870:71d2:b0:268:bb3a:cfc0 with SMTP id 586e51a60fabf-26fe59d8a6cmr5803059fac.1.1723693556523; Wed, 14 Aug 2024 20:45:56 -0700 (PDT) MIME-Version: 1.0 References: <20240814071424.2655666-1-jeffxu@chromium.org> In-Reply-To: From: Jeff Xu Date: Wed, 14 Aug 2024 20:45:44 -0700 Message-ID: Subject: Re: [PATCH v1 0/2] mremap refactor: check src address for vma boundaries first. To: "Liam R. Howlett" , Jeff Xu , akpm@linux-foundation.org, willy@infradead.org, torvalds@linux-foundation.org, pedro.falcato@gmail.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, jeffxu@google.com, lorenzo.stoakes@oracle.com, mpe@ellerman.id.au, oliver.sang@intel.com, vbabka@suse.cz, keescook@chromium.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: xib6oti7d6b19ir9htmca9exm9wek4h7 X-Rspam-User: X-Rspamd-Queue-Id: BBD71100004 X-Rspamd-Server: rspam02 X-HE-Tag: 1723693557-421804 X-HE-Meta: U2FsdGVkX19MCVCicMqA9vLhl05Zq6k+YOzyaWd6r5HPtN+DmMUlaL9C2ozqeGbBTsuMqs7lT449PhWbJ3AkVThpK8vnm7TvWxovHKW+J4RwAK8p50VaYckeJimpRk5ety87rx8t46BgATchkaGRs5fJEE68l+pnxIzPu6CKnSDDGS3g+6gGMfmMYY3dpRFx01IQ6mqTe/5rbxfjjv19i6S6ra2u5BKh9fUft03/nfA0fVlIiIClRCosr1FYjyfBOaj95nON2hcEJTlAH7wCbxH6/YWgP81G8CU2qkzQZsLFDrde0JzQibOzAWaptoTwe8v0Echgpz0SEw5LXNdLp6mzhdIHApwGH9zOLfg8lU1Ck+8D5mW56Xj+cD5AL8xrvArMxv+ENWikGLqmL33zOfCIgp7d8Wiz9N9F44g1P//eOtjJQTMM1gCab6M7BVt+qqTNSPRwMHU7gkXRk6aC9/fn+CVulRCqhSaQh9qfCKnGVoIrNvtxZFk9sIee3zowWA+CNr/cqTePrtYrVr8uP33w4M/us1Mo/EQeO1YhNKrX/GyyFA4GSCTzhUR5lNZODHLdTfS+09J2HM7D8+bz1WAQsdFwM3GgddE2uNxIpihSIKizTc+MOPYb2l/9egR8qlt3GPoRhhMVPZOIgT/F1TXWrvtKMKsgKizxFfDe5xcEcxdxWsugqkdxFB0tXMrN+KfzfDZs5dn0iMsrxvdfCuUZLby0r7BFimD1ESaofWhimWGkwyQiJkP35JZoDY2WHgrjUagru5LWOZ/wTRgObmE9Zk4hPEoOOrqNEPNq5YFboN5Vb4brkhvX6/t2yV/oFgbkKVtCIE+Po1jzkJQtpJdmm3fSL5WZIvsF+ymw8e3xsap6AHUw0PE3w5qlLGAd8jOwmlVN9NqTZh/sbOGbyGQ0yzKVtNoBThgafnFqIdnhStjz3DiF4nQjtVbujI6L5lINQNRugBQgIaXmart sKgdji7k 4urC8sleLiw3kkS1Yeqnss7CWxzxka3C34LroXIJZKKNPvZ2Zbl3adxLkPdzxFH99RsEcAKZomWtBtkktInDWcIH2DRZo0bP2WYqYvramvrDN81SgZ409MCzGawxZJPdstYHhRrLuxB3O0DN+jj1xvWTyPoTF6Y4cOjPfU8edO0UEblVVccsBluhOnU7CF1xLotADMCLhA8ROD7uMPzOQGjA01YX9Rf5iAv60/CIGGeEjYksa/Vmisu/pi6qNxfZ+FQi5w686R96N9ctXAl62Vk7V4cKLp5K9PlJW+ZeT0qRIVFvs5ffymZomyF1hdqSsUbvoM8GNy9XrPfrepJtWAOAEJ+XKxmO5mPMo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 12:55=E2=80=AFPM Liam R. Howlett wrote: > The majority of the comments to V2 are mine, you only told us that > splitting a sealed vma is wrong (after I asked you directly to answer) > and then you made a comment about testing of the patch set. Besides the > direct responses to me, your comment was "wait for me to test". > Please share this link for " Besides the direct responses to me, your comment was "wait for me to test". Or pop up that email by responding to it, to remind me. Thanks. > You are holding us hostage by asking for more testing but not sharing > what is and is not valid for mseal() - or even answering questions on > tests you run. https://docs.kernel.org/process/submitting-patches.html#don-t-get-discourag= ed-or-impatient > These patches should be rejected in favour of fixing the feature like it > should have been written in the first place. This is not ture. Without removing arch_unmap, it is impossible to implement in-loop. And I have mentioned this during initial discussion of mseal patch, as well as when Pedro expressed the interest on in-loop approach. If you like reference, I can find the links for you. I'm glad that arch_unmap is removed now and resulting in much cleaner code, it has always been a question/mysterial to me ever since I read that code. Thanks to Linus's leadership and Michael Ellerman's quick response, this is now resolved. Best regards, -Jeff