From: Jeff Xu <jeffxu@chromium.org>
To: "Liam R. Howlett" <Liam.Howlett@oracle.com>,
Jeff Xu <jeffxu@chromium.org>,
akpm@linux-foundation.org, willy@infradead.org,
torvalds@linux-foundation.org, pedro.falcato@gmail.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-mm@kvack.org, linux-hardening@vger.kernel.org,
jeffxu@google.com, lorenzo.stoakes@oracle.com,
mpe@ellerman.id.au, oliver.sang@intel.com, vbabka@suse.cz,
keescook@chromium.org
Subject: Re: [PATCH v1 0/2] mremap refactor: check src address for vma boundaries first.
Date: Wed, 14 Aug 2024 20:45:44 -0700 [thread overview]
Message-ID: <CABi2SkVrk-MyMGVDzRZi++7tzCu6k92Vz4hyaVHY2nbYDxd97g@mail.gmail.com> (raw)
In-Reply-To: <mlwues5aus4uie52zi2yi6nwlaopm2zpe4qtrnki7254qlggwl@cqd42ekhrxez>
On Wed, Aug 14, 2024 at 12:55 PM Liam R. Howlett
<Liam.Howlett@oracle.com> wrote:
> The majority of the comments to V2 are mine, you only told us that
> splitting a sealed vma is wrong (after I asked you directly to answer)
> and then you made a comment about testing of the patch set. Besides the
> direct responses to me, your comment was "wait for me to test".
>
Please share this link for " Besides the direct responses to me, your
comment was "wait for me to test".
Or pop up that email by responding to it, to remind me. Thanks.
> You are holding us hostage by asking for more testing but not sharing
> what is and is not valid for mseal() - or even answering questions on
> tests you run.
https://docs.kernel.org/process/submitting-patches.html#don-t-get-discouraged-or-impatient
> These patches should be rejected in favour of fixing the feature like it
> should have been written in the first place.
This is not ture.
Without removing arch_unmap, it is impossible to implement in-loop.
And I have mentioned this during initial discussion of mseal patch, as
well as when Pedro expressed the interest on in-loop approach. If you
like reference, I can find the links for you.
I'm glad that arch_unmap is removed now and resulting in much cleaner
code, it has always been a question/mysterial to me ever since I read
that code. Thanks to Linus's leadership and Michael Ellerman's quick
response, this is now resolved.
Best regards,
-Jeff
next prev parent reply other threads:[~2024-08-15 3:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 7:14 jeffxu
2024-08-14 7:14 ` [PATCH v1 1/2] mseal:selftest mremap across VMA boundaries jeffxu
2024-08-14 7:14 ` [PATCH v1 2/2] mseal: refactor mremap to remove can_modify_mm jeffxu
2024-08-14 14:39 ` [PATCH v1 0/2] mremap refactor: check src address for vma boundaries first Liam R. Howlett
2024-08-14 16:57 ` Jeff Xu
2024-08-14 19:55 ` Liam R. Howlett
2024-08-15 3:45 ` Jeff Xu [this message]
2024-08-15 16:49 ` Liam R. Howlett
2024-08-15 17:22 ` Jeff Xu
2024-08-15 20:14 ` Liam R. Howlett
2024-08-15 20:23 ` Jeff Xu
2024-08-15 20:40 ` Liam R. Howlett
2024-08-15 18:16 ` Jeff Xu
2024-08-15 20:19 ` Jeff Xu
2024-08-16 2:39 ` Oliver Sang
2024-08-16 2:58 ` Jeff Xu
2024-08-18 9:28 ` Oliver Sang
2024-08-19 1:38 ` Oliver Sang
2024-08-19 6:35 ` Oliver Sang
2024-08-21 6:19 ` Oliver Sang
2024-08-21 15:21 ` Jeff Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABi2SkVrk-MyMGVDzRZi++7tzCu6k92Vz4hyaVHY2nbYDxd97g@mail.gmail.com \
--to=jeffxu@chromium.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jeffxu@google.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=oliver.sang@intel.com \
--cc=pedro.falcato@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox