From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2887CA1005 for ; Fri, 30 Aug 2024 16:07:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22CAF6B00B4; Fri, 30 Aug 2024 12:07:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DD6F6B00B6; Fri, 30 Aug 2024 12:07:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07D496B0194; Fri, 30 Aug 2024 12:07:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DC8566B0192 for ; Fri, 30 Aug 2024 12:07:10 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 357B141BAE for ; Fri, 30 Aug 2024 16:07:07 +0000 (UTC) X-FDA: 82509390894.29.B8F075A Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) by imf16.hostedemail.com (Postfix) with ESMTP id 304E41801FB for ; Fri, 30 Aug 2024 16:06:06 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="Z3h/gOk3"; spf=pass (imf16.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.167.173 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725033877; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6QFnBrHUOHBIu1g328bGqUADv8FhXAP6VMkOjyVwhEw=; b=OMSKl4fi80vGgXA3eUW1A0FOK7idBpBBfB0omBErMrZXdGeCAXrV0N9GBMe966RmWyKzo5 xsvF/k+BDp5V6EfGbcZ7TmzdyCR5cuDIYmy+7i2g39QOS74nfIHo2mRW0cYLWBV6Fr77e3 nUsUTCmCkkuZd56lk11L39QvgdeAKoo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725033877; a=rsa-sha256; cv=none; b=pWPb2N2Rqb1NphG1Tn9kJWdRuK6qrc0UCNKxqPEIFMWMgjiKYT8byLZX+iv0z/6nYuB1oY YzQ/deR7ClhQFxoYCENbTfJnCx9yGWBnd7jvrEniOFGvv5S2XBJqmBHs2QljMbc5j0jdrL qyhhYILadE3KbMBwZJQYNUyvEbjZHt4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="Z3h/gOk3"; spf=pass (imf16.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.167.173 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-3dc39305ed6so192047b6e.2 for ; Fri, 30 Aug 2024 09:06:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1725033966; x=1725638766; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6QFnBrHUOHBIu1g328bGqUADv8FhXAP6VMkOjyVwhEw=; b=Z3h/gOk3uvUyI4xKMuYKTMawZcNqS3kAR4TizQ/f+aaXr9y3y1EamGfw5KnDCYrcYg u6X2d6SYKlu+uyyjh0xxOq3f2iI39qVaUSBJcJWMrOSI5xgM/M9dF4d1iWLn6z8UxLgx 1lzfxzTw9+8Ozoc0hJPj414mY4grGXAwk3M74= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725033966; x=1725638766; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6QFnBrHUOHBIu1g328bGqUADv8FhXAP6VMkOjyVwhEw=; b=tqxtpEnqAAAcqGA9Fy8T2SoOLPjDy4P7HvBYJEG5r0v1jen3REOydmIkDg27+1EOi5 y4ByWS7H2+JfRZJknv/BK9EVnAjkBtAhdYUR/I9lBMEslJstYY0DkLyRlR7fwtxEHrez NxbuNFeL44gsMmP0FEhDOmXevYrUBr9isOMZuMtT09vHptPJ3sa42IKWoLIeWFTdkQYy BG6G24TZXTsBPUExcl1uSPDsN1JTgeAdVoR9m7LAbRtsOncWF7kLAPiG2vJ2g+M+/nnt 72yxpd0DhzlnFTViwc/f98Joe9elXT6rzo/oqgKRSJOdILF48rWQEf8YfHHdHyVuMESy LHGQ== X-Forwarded-Encrypted: i=1; AJvYcCW/3bZrHJzWfLmSXtPFuYutD1kwCvQGa3c688rlUlR7oZ8le8BLKAqrzFwzGUfQ+6DKEO/2kxYAMw==@kvack.org X-Gm-Message-State: AOJu0YzD1UjoMyqL8mCnnc5wUkzJpN+l0dwp/G4oo3haqZzOBtAevjKC Y9kuKf6rg36wOSVO4KYbr0pTauctreQkA0l4guueCBfqBCCkxITPv6H6U3ChsugarDuo5S3VLq8 L3Ms4kpwsN6Qos7eQo7aegfKId7pUNFjku20L X-Google-Smtp-Source: AGHT+IFLHlMJJ5EBpVwqu1rWmjCPR3DZ5QkbAb7tP5TcOYOi7XVDZanOxHa7tKmN0cLHKkx7iXFjyBjweMsnL1z/4zo= X-Received: by 2002:a05:6870:d192:b0:25e:44b9:b2ee with SMTP id 586e51a60fabf-277b0b536b8mr1436022fac.2.1725033965860; Fri, 30 Aug 2024 09:06:05 -0700 (PDT) MIME-Version: 1.0 References: <20240830040101.822209-1-Liam.Howlett@oracle.com> In-Reply-To: <20240830040101.822209-1-Liam.Howlett@oracle.com> From: Jeff Xu Date: Fri, 30 Aug 2024 09:05:53 -0700 Message-ID: Subject: Re: [PATCH v8 00/21] Avoid MAP_FIXED gap exposure To: "Liam R. Howlett" Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Suren Baghdasaryan , Lorenzo Stoakes , Matthew Wilcox , Vlastimil Babka , sidhartha.kumar@oracle.com, Bert Karwatzki , Jiri Olsa , Kees Cook , "Paul E . McKenney" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: di19kjedubgmpzkqpwooy3hixp1o5yo4 X-Rspamd-Queue-Id: 304E41801FB X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725033966-911895 X-HE-Meta: U2FsdGVkX1/EEYcReeET0Bny2F25L7ihoOvCFMXTDZA4wkjUP8uDuI9i67Aanw86EAEJz9RMyGP0hr6jZnwkbhyHPM3iA6T146vJgmV5/GIKatL8IRsQjiOHijANHbBUwmSbY4XMbowIrJVSl/LpMh6MSyWSwcGkoh79LdAKOwOjeSfnJn4dzOq6MB+S3L9QZYHh1US+aAkeyBqlLymiWrvvF+9HTgF8A2UOW5hJ+1BStofJpG498rsD8/MkEvGYfGTo0uLK0D+5h5E90/dXZNvRA+0JlErXNCnBoqrzfKhozaNEF+qFjgASqGz8goShGkcmnsKNZb9D/HhKDWCkV8efQoPSFvpk8dc7aOwt99IKITTva9nUb/X31FY+96P5kpmLh8msFYxq8GOdscZv7M6RCpIKSguQYzcAtn2kWuHikvXqvshdXcfPkNl/0YGPxY90qGfnIRepZooHP3uBjdeCzLuXC6spSVqLNf8h3KwYMqNNioibB7DVoDwVWtljBeMm6+ehpKuB5jJ42b8Zbk9z6BtTMiB9jK8g82QEyF0wAw40mrL7ex9FO9Ttour3E7YK55U6vIEE889gnMoGKj18ptpqb6StdNwVe5NCumwgRbdYfdvqJ4+ua/E/7+Y4+xDT89/ZiLuKJ9YsgIvP9uOX2ThiiJACwobEbyQdEHNK9PZWJqJw0rvYMevc959u9nWWUzCYAtTsW7cDfzlUxycAvJ1xiN6JjHCoj8CJCILP4NK7wPdeWzEslnecyxLlk1+Wi2XUpWKtQ6sCfVO3D7j5+yxUeAplBPT42CmlQvOaG/H1JAEGmBpsH3GE+Q2QdI27l5p9becFU/+c257WgSYYOhXpzwya12tc+ceFXiF/k7sVvcPhA0cA1UHafuTTVpT7oIgjxY/gIjxtkXkXNax2GKiC8MTgO93kf05Gt8GJo0fJTW8OT6Qyc/AZXfHz3QRXrxvPeIrkFINXUIr NWymk8yb 5rn8Q+/vrfIQTbzpVJuZhF/W/CtGGA7CErg8IJlzTx9tr6Sv7wL8iPgviCNDsRqkhwZsDxe3CLr4cGiKE+e8lfuFxNx6dz2VT8oarNTvpZHVwKHUWX7PPLsURdcJuXPL2xfK3onxNAOwgNC7fQty2jAftVjYwHOgSqreMBT4i0Zk43Ce+WRqF5hY4IZQHTbHydR+E6J2hdskfUcAxs2RznZ/47Ank6pHXQ96xtYlenZfBJJ9K2DzlMUBNloNMxl81AllXcYa/TUYaUfE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000471, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Liam On Thu, Aug 29, 2024 at 9:01=E2=80=AFPM Liam R. Howlett wrote: > > Changes since v7: > > This is all the patches I've sent for v7 fixups plus the return code for > mseal(). The incorrect return code was introduced in an earlier patch > and then modified (still incorrectly) later, so this version will > hopefully bisect cleanly. > > - Fixed return type of vms_gather_munmap_vmas() to -ENOMEM or -EPERM > - Passed through error returned from vms_gather_munmap_vmas() in > mmap_region() - Thanks Jeff I would think it is cleaner to fix the original commit directly instead of as part of a large patch series, no ? If not possible, maybe mm-unstable should apply my fix first then you can refactor based on that ? -Jeff