From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86C49C282C6 for ; Mon, 3 Mar 2025 19:34:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13C97280002; Mon, 3 Mar 2025 14:34:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0ECFD280001; Mon, 3 Mar 2025 14:34:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECF3D280002; Mon, 3 Mar 2025 14:34:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CE346280001 for ; Mon, 3 Mar 2025 14:34:19 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8F499120EB3 for ; Mon, 3 Mar 2025 19:34:19 +0000 (UTC) X-FDA: 83181241038.11.75D982C Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) by imf20.hostedemail.com (Postfix) with ESMTP id B83341C0019 for ; Mon, 3 Mar 2025 19:34:17 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=E2CwzSrP; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf20.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.210.42 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741030457; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7TRJ44BH31NUhCHJXuBhqstjp6BiV2xjfEwoVOhwUP0=; b=p6u2vnSRO6ViXh/POZ/Q1xsG4ew6ck8N7W7wrdCxm9fRdvccFzw0Q3L5PsmF6PwMGr9mrX KqVeHO+dCHVJrZUlpWwqqAl0XzxDWCdAuL6U0XAst3y6Tx4yikWSMchCHGqW+/xB+iuSMw vWti6GBhfBcQUAQeJqfLvP61+TsrzVs= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=E2CwzSrP; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf20.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.210.42 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741030457; a=rsa-sha256; cv=none; b=TC+efuw2dgm9Huv7i/9gmlPAM8xeY5mcG1MhxnLdhFAUfa8q53nfiALJRCxomdCdn5+6mz LjaMoAy+qxg1L8mOMq89v7LmmSJ9XKmdzvBR8DB0Q2M4GKv3iVZWrI7LiridUER02bKrfN TqAmOgT5fngu66aCpuk4RyDeS/PPWfo= Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-728a2736e7aso605930a34.1 for ; Mon, 03 Mar 2025 11:34:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1741030456; x=1741635256; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7TRJ44BH31NUhCHJXuBhqstjp6BiV2xjfEwoVOhwUP0=; b=E2CwzSrPA9XLX6LFhPMK4ng+K/51MWnKcPyyYAzyIgoBnveiSdkY8pg4fpUlR5BaRX eP8PstdLXjV4R83sWM3M06Hhfe12fL+EaXu1y7L7gcVjvIbTYYT8WeU+YMRf7nF5s5UV GuH8+YaOTJAGq3FfPI5BS7Gmc3lVFEtWtTX/E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741030456; x=1741635256; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7TRJ44BH31NUhCHJXuBhqstjp6BiV2xjfEwoVOhwUP0=; b=WBezJjc69TwEsk0yFXeW9sl34AjP7RIWgdpRVUm0TWy6r+WvpCatlnUMFymv+VNMmF bda6zyB949FZSTJpq8Or5a2r3HbAKfDPVfmm/TxRDujONoEhynnmKHyrUpSsXq5pRprn SfEgrcGW1WSjg7HlRYPaXcv80Zi2OkburaR/AP/6MEm9UYs76yGNve1/Q8rZWr7zkRzw Tm+llTS0rNrKHCZBdQoULHCe0bFpxMLJJg+VmOTyInoCi5X4nI7IbmjhbRKs7LVtFqEX Cvza3qLgjh1fE6ZBKpATH5178n2z1iNMl3b0K/FZFI2sEzjBfCb4RQ/ovEPPf9pFsNkN JuHQ== X-Forwarded-Encrypted: i=1; AJvYcCX1UN0jG0yHmzzQA01mJyYn8DZ/QVodtmaba4ll5HoicnQvod6SuyJZF5CQeLyPEYslxaNb1oi0dA==@kvack.org X-Gm-Message-State: AOJu0YwNOEEvT+f9gsOrYirmCkESaDjgdVt4FNCmBS9uZT1JyXuNuF5+ i5oYZnsYHXiE81UiZ+8xI4HR8j+nkvbJ8tSnFBgwYl5BCST87iAWbmPhCZ5fvZFRRjowmflmMdo Uur2sqBDiRFSr9uG52QHHM7Koe+Y7yClcY656 X-Gm-Gg: ASbGnctFsoNvZipd/s6zL5MOpuQsU4F6UwpGKrqvgbfd/STHH00Q0bsS3fIIrBi8k6M OiecsPrMELdOz8xQBpVcT/o9QH5Iagq9uBd7IkcGeBzwTJZBWSkYaqsa+vhYfo+J4c8Wi1zej7F au26DrATOibJl+03+U3QZXA31t3v3UGVYFqqLjhzkgdFqfsVGIh7NPAnM= X-Google-Smtp-Source: AGHT+IEwrg6wY8Y2ouC1pR3h3Bh3ijMUnINP28bst/fv0Tz3SsD+Thqpp0hOQ1CjWKueIO3bwWa1zIY9jvKARU43hRY= X-Received: by 2002:a05:6808:179f:b0:3f4:3ec:11ff with SMTP id 5614622812f47-3f558304cd2mr3549126b6e.0.1741030456616; Mon, 03 Mar 2025 11:34:16 -0800 (PST) MIME-Version: 1.0 References: <20250303050921.3033083-1-jeffxu@google.com> <20250303050921.3033083-4-jeffxu@google.com> <24be17fd-4899-49ae-9b4e-9372fcb4e0cd@lucifer.local> In-Reply-To: <24be17fd-4899-49ae-9b4e-9372fcb4e0cd@lucifer.local> From: Jeff Xu Date: Mon, 3 Mar 2025 11:34:05 -0800 X-Gm-Features: AQ5f1Jq2xY3e4auvFuYbMS1vMNpdRf4M_yrHWrDo25LJ6mNLdQqRcc_Co3iWjCs Message-ID: Subject: Re: [PATCH v8 3/7] mseal sysmap: enable x86-64 To: Lorenzo Stoakes Cc: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, torvalds@linux-foundation.org, vbabka@suse.cz, Liam.Howlett@oracle.com, adhemerval.zanella@linaro.org, oleg@redhat.com, avagin@gmail.com, benjamin@sipsolutions.net, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, jorgelo@chromium.org, sroettger@google.com, hch@lst.de, ojeda@kernel.org, thomas.weissschuh@linutronix.de, adobriyan@gmail.com, johannes@sipsolutions.net, pedro.falcato@gmail.com, hca@linux.ibm.com, willy@infradead.org, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, peterx@redhat.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, mpe@ellerman.id.au, aleksandr.mikhalitsyn@canonical.com, mike.rapoport@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B83341C0019 X-Rspam-User: X-Stat-Signature: h8w1cpmxz4ucubgca76pbzg5wcu7fpzg X-HE-Tag: 1741030457-127650 X-HE-Meta: U2FsdGVkX18gJIr4k1j4VKjwVYwj5esg8rj7zzHd6QD2nlmBp8ysgJFoucm4QmA+dcreq/Kkvfe6QDwsPuz5asO8KDabHmlTlJDDec8TZqK+yaVhnhs7Od3lg/RscJ4dq7utGe90KJm+cUUfZM2Qf59FPaczPsqAZwpw4pJQlFVv6Tt4hyXLPaP9mFFOjbImKdCzxZtyjVWZFF25kVgAguAGXlMlruMploxwKKYrpLWozlfl5kmKVjIuLR0FbGkRCcRlVpeZw1mPU+ZI/Gs9f154oKex6YlRUmkg3/aPyDqmLGulBewhoFa+R3rVJQ29sZGD8ew1sGQt4yNi6+Gd2jqfkZOQbnsmPabpk3uRwdBKbxdxzxr0Nh4EZKl5VoByHcIHnEcoY+MNHWCQN+9RNlUtTuu7zVrA+6eD13motNvxKDUvwINGECxNRSsb8EAyyofFSqB9yZwm0rzwoHqoE/qq4gR2MjD0s8l4uxUf71x3Ycftz1Jx6GWYY0TyUH7QM0m81YApVaCv9SZypzkfeHberCJ3Zj75MYQZFzY8TQ6Xy9Pbu/4OviOzKcaOIYsh10V0eQOftocrTLUjq4PXa/hXz00qn+cxtChky7M54NUfn/zNFMqXJ5j+OgBBiglv3EBcXqSby9kCc+di2K+jVKNjhxiEmvTNsoHcZXIAGVD8G/kIXmcGSotuNolLd3r+GgZ/gkgeYHu4uigiF33+0n73LoCIU8QIP8y+vRIAtqL2LALrruXShOSBjWhh7lvSopC7713LiyMdRy4s+BlXfOHPG8CjkNGeeY9kDc+qIyxso+OIsNzFjB95C/9AMXBYyEyRv6u24yOUM6+e+hC56MlY2ikcd2doW+LzErGm3rB84UY5QiWdJaOn3ZNMoDx0vXloJix0HwgFp3IpcHdh/g5CYfrcYw3AgqxVDKTD/lSoBMdhmJZdPPMARfOus4rutrk0gC/WMA73Jlqf+2s /fxvtw1i U19mPBNkxa3U16EuGqmUQfWRhpIW9A/mwUrZw4dze5rNl8R26o80tVv5QMR3HXS/Dlja0+Z6xWolbOdy8i7yIFEWnJOEhLJct0ieiU2aAaap82rrT7V2uwqVfTGyPDmF/1nzhl8ttlySo/V3OoEQKcXoe0oDxgMslsXFNmqjjJWKWOMm9Z42nd5tssr/utF2WJwQwAM5EWQBrZs1hSy/+KD5bHGR8KboPchrzU5q7VCvPcV2h9uDqzdXwL+sMAby414n/yCMXn/vVNwa3/qVRXtc3/PGXNDB5mV/uFB01T6NAajbctBodleZEyWxwOEsnTvsC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 3, 2025 at 4:01=E2=80=AFAM Lorenzo Stoakes wrote: > > I tried b4 shazam'ing this and there's a problem applying the patch, seem= s > maybe a conflict? > > Not sure if Andrew can resolve or if something needs to be done here? > > Seems to be commit d77a800944d8 ("mm: make DEBUG_@WX dependent on > GENERIC_PTDUMP")? > > Should be a trivial resolve though. > This version is based on linux-main, if that helps resolving the conflict. I can also rebase using the mm-(unstable/stable) branch or other branches if asked. Thanks -Jeff > On Mon, Mar 03, 2025 at 05:09:17AM +0000, jeffxu@chromium.org wrote: > > From: Jeff Xu > > > > Provide support for CONFIG_MSEAL_SYSTEM_MAPPINGS on x86-64, > > covering the vdso, vvar, vvar_vclock. > > > > Production release testing passes on Android and Chrome OS. > > > > Signed-off-by: Jeff Xu > > --- > > arch/x86/Kconfig | 1 + > > arch/x86/entry/vdso/vma.c | 7 ++++--- > > 2 files changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > > index be2c311f5118..c6f9ebcbe009 100644 > > --- a/arch/x86/Kconfig > > +++ b/arch/x86/Kconfig > > @@ -26,6 +26,7 @@ config X86_64 > > depends on 64BIT > > # Options that are inherently 64-bit kernel only: > > select ARCH_HAS_GIGANTIC_PAGE > > + select ARCH_SUPPORTS_MSEAL_SYSTEM_MAPPINGS > > select ARCH_SUPPORTS_INT128 if CC_HAS_INT128 > > select ARCH_SUPPORTS_PER_VMA_LOCK > > select ARCH_SUPPORTS_HUGE_PFNMAP if TRANSPARENT_HUGEPAGE > > diff --git a/arch/x86/entry/vdso/vma.c b/arch/x86/entry/vdso/vma.c > > index 39e6efc1a9ca..a4f312495de1 100644 > > --- a/arch/x86/entry/vdso/vma.c > > +++ b/arch/x86/entry/vdso/vma.c > > @@ -268,7 +268,8 @@ static int map_vdso(const struct vdso_image *image,= unsigned long addr) > > text_start, > > image->size, > > VM_READ|VM_EXEC| > > - VM_MAYREAD|VM_MAYWRITE|VM_MAYEXEC, > > + VM_MAYREAD|VM_MAYWRITE|VM_MAYEXEC| > > + VM_SEALED_SYSMAP, > > &vdso_mapping); > > > > if (IS_ERR(vma)) { > > @@ -280,7 +281,7 @@ static int map_vdso(const struct vdso_image *image,= unsigned long addr) > > addr, > > (__VVAR_PAGES - VDSO_NR_VCLOCK_PAG= ES) * PAGE_SIZE, > > VM_READ|VM_MAYREAD|VM_IO|VM_DONTDU= MP| > > - VM_PFNMAP, > > + VM_PFNMAP|VM_SEALED_SYSMAP, > > &vvar_mapping); > > > > if (IS_ERR(vma)) { > > @@ -293,7 +294,7 @@ static int map_vdso(const struct vdso_image *image,= unsigned long addr) > > addr + (__VVAR_PAGES - VDSO_NR_VCL= OCK_PAGES) * PAGE_SIZE, > > VDSO_NR_VCLOCK_PAGES * PAGE_SIZE, > > VM_READ|VM_MAYREAD|VM_IO|VM_DONTDU= MP| > > - VM_PFNMAP, > > + VM_PFNMAP|VM_SEALED_SYSMAP, > > &vvar_vclock_mapping); > > > > if (IS_ERR(vma)) { > > -- > > 2.48.1.711.g2feabab25a-goog > >